From patchwork Sat Jun 8 23:10:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49711 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp1781721vqo; Sat, 8 Jun 2024 16:11:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVqs0Zv8NM5Lys+kxDahToi9/uV50f+7YqGDj/OPLJjxwzyFk9TWC0Qj8x5lHoh26nXGsh8u6uYfeI5Y++XrJpiXBsBi1Cyv5IRzg== X-Google-Smtp-Source: AGHT+IH88BMLnvCCrKyQoKFB8VnEjatC6+LGqOr3Us14gafLXsp0s1gidp0d9cSfyQwQy8ImfQF0 X-Received: by 2002:a05:651c:2126:b0:2eb:d95f:10bc with SMTP id 38308e7fff4ca-2ebd95f1469mr17601531fa.10.1717888278163; Sat, 08 Jun 2024 16:11:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717888278; cv=none; d=google.com; s=arc-20160816; b=eFu5b5WRku/SnmoZDrD/YyiiW3R/F5r2Vxdw+ZHn/enendz99OwfgJcwBVXAUc7qbH 9y2IhCpGkXJBGg/ydPhhHqJWcBgb1e/xMLqQmdQmuAp1BUfolPg/eRUOKh7cPmkqSwFS Yrj+U9DwgeFr220OlZPahbdXZql4aQomllbKoyZ9HgmoGUh+qKIyb4QrwbsDoEpK4lM8 VYLWE2T2/19P3hvtKrEt2CvilJoN3jh9jH+mNYJKmeSc/UE6eeP/AeFObBTBCuuji1XN l39VEI/SFQTMybYaoReP2mZQyMP5xSf4gIeJt1D2Z+PN9p7t+e6vcMaJlZEWkRSzTO0E gzZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=mRhUlnneOPcvH0UXtOBKdHmxXnaCIlfpREjfK9EyPw4=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=qs723xIDogWKCtBvcXf7ybTc5MiHEx7WR70fvFOOx/3i+8yJ1N293Y4BBoQJSvh9Oo a7jjf5Ut1jsJyAHPdKm873n3ovYg/b+rbuvUYBDaYG/u6AIfgv4KxwtnMF4cTa1dlUNN bzAO7rgOLiMogGhrMLS2+jIEcACDVimZuLP022nOZAGUT6oE9NjL7TwnKYr+71DSZEsb YkQdN52iVCeueupYQgwTht/Wzg/d9HGnuC9yXwcYcttefvDS6YBXPw26vqTWeiz1QYdi QyDZcZsL8U+izsQ368qkdJlLCLjOv8LJ90B03aODdBCBaZ8noEVYRjHXNh+v3SXRImOV ieCg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=iDjgOKyV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57c74eb06absi355967a12.110.2024.06.08.16.11.17; Sat, 08 Jun 2024 16:11:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=iDjgOKyV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 74A9168D674; Sun, 9 Jun 2024 02:10:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1346168D718 for ; Sun, 9 Jun 2024 02:10:50 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7266EC0003 for ; Sat, 8 Jun 2024 23:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1717888249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vkvTnVm2OnJ6FS00fMThIkQnzeA5KsUktMLm8B+LnFM=; b=iDjgOKyVfnenkJ2zZbta2cOFg+VGFT0cDevYf5dLPezKLl+QNtWwoKowmD7w3+d5bcMWz1 DNZHvgx/ue0Usb2Ha2JCAy4HqBYvolzPIMXE5/RXiMaqOSb8Ad8FJvCkcSeYPvNKMm7RFt nV1rr1554qRTsHxvt8OOyxbypY1HYp0f1LpbFJyLD4ikKcrPE1w9PuJkB+iVCmNWIJ+kWY gZgWo22BB1PY+n5h42Fc4+MWkLFyW+yXy+gwEsNQje/x37SvKSj6Fo1Q5xYexfxCXp6bwI UdghV3I1juZdMpg6Uwt65i9ypz/8hiJYPTtZLhHVU5J/st/wmx0Isihfe9CfxQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 9 Jun 2024 01:10:40 +0200 Message-ID: <20240608231046.3619551-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240608231046.3619551-1-michael@niedermayer.cc> References: <20240608231046.3619551-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/9] avformat/rtsp: initialize reply1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: NAkijBKgaCrc It seems reply1 is initialized by ff_rtsp_send_cmd() in most cases but there are code paths like "continue" which look like they could skip it but even if not writing this so a complex loop after several layers of calls initialized a local variable through a pointer is just bad design. This patch simply initialized the variable. Fixes: CID1473532 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rtsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 28c858077ad..c6fca89d83f 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1462,6 +1462,8 @@ int ff_rtsp_make_setup_request(AVFormatContext *s, const char *host, int port, char cmd[MAX_URL_SIZE]; const char *trans_pref; + memset(&reply1, 0, sizeof(reply1)); + if (rt->transport == RTSP_TRANSPORT_RDT) trans_pref = "x-pn-tng"; else if (rt->transport == RTSP_TRANSPORT_RAW)