From patchwork Sun Jun 9 19:51:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theo Fabi X-Patchwork-Id: 49764 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp2152529vqo; Sun, 9 Jun 2024 12:51:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX80FebYwACOtkc3Tm5no6lLBKKVUPpQVgihiGxSNgbje81RFzsY8XSwA4IwWzSYR4DCDtIe5RR4ADQZCxnOWfBVFpc2xrYWRUqdg== X-Google-Smtp-Source: AGHT+IEbfRg153wQBJxoGkOD7xWgw1LdL8Esz2R+QmWoooHUV1vaj2WPypp7YkMdjvw3VrN6wEiO X-Received: by 2002:a50:8e15:0:b0:57c:5caf:2b94 with SMTP id 4fb4d7f45d1cf-57c5caf3068mr5267261a12.36.1717962701344; Sun, 09 Jun 2024 12:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717962701; cv=none; d=google.com; s=arc-20160816; b=malKQP8JRyESvWa9JGyPvjaVvFW3ZaJ7EcRF9RQLhyWRjLf4ARTlVhIydlR0o94D7k h7ZOit2WFuQcJ+eZl23qKayz6V1R2Jt97GQRmrOSqx5msVbXwIuO+ykPp7UZ6RkjIch4 oCH+zCg+gkkj7Cd7O47vDnXPOFZgwJ4Zj5LaytQZSDvdRrHwZw54TbZpMadw4QyzSvc4 /aSygOger0TXi3rLjmwos7bYQAjg/VG/hQnZFK4hOgEjuub+yZ/pfpElX9ZSWjtHpnvd /47O2JC6XICgBfmvYYNW2WONH5GyyNaRQXrB5bqPKkF3CY0UUjzZz+y/tdh3MwYRcB0i nZnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=GYclpoDwtXK120fpDWhAMHH9qBrCOf/xBIcTQkEiQDs=; fh=ANQuGVJiXGFpLbyy+iL5wt91D8AK041gFHrX/v2dqsM=; b=d9IdCt1aNlULbWDk7ltAUAx7fBon5PDNBNF90d+n8UEjiIon0ycelmNOq4dqpspgd8 EF2vRA+xQC9pFegcGqYltNduUnpQmBGFMlYRwgeDAj2835Jdu9ynHBHIyu5ddJpFnhNk H73LJZO9xmRIKJ0xVBV9uBgratkrlY5i84U7CTqejzqDnB3qXX3+Tu0dMga5+XuGpNiH uaijnV2hD+7v+D0ZsqqovJs8JP3qmtEb/q+x1/A7O4sBWKGvSVQlOu83FozyA1bd5MzT uu/Na2ux6TnRAehM7twKwbrI4LFMi6Qm455hsZaYnDZ60P7RQVklwPM62FDu1E3iSbgY JB8Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=BNKoVFuK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57aae22819dsi3803532a12.363.2024.06.09.12.51.40; Sun, 09 Jun 2024 12:51:41 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=BNKoVFuK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A733B68D6B6; Sun, 9 Jun 2024 22:51:36 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08F3A68D59F for ; Sun, 9 Jun 2024 22:51:30 +0300 (EEST) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4403bb543a4so18266121cf.1 for ; Sun, 09 Jun 2024 12:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717962687; x=1718567487; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Jlz+MnA+KwlQpwg6U8tRlPYaxddr0TUxdT4ZVKTJqY8=; b=BNKoVFuK8858dZRR5+Qn03SzrJG1OO6QqH1Il5HQigMZ1fkdOTvLZh/mMZUdiSU9sC cRwxQ66JtLrZrjZfgXsaBPHIe4CP1Vuk6u/r85L5G14ImQzBIgyg6p6BqMpKpsJPZYyc wUW2ns0ceO0iXeDPY/9mpjRSqJvQY7z1c2Tb3aiBZK77Wbi5w3VC4YTepGwFYC1bsvbq A2hA2W/Xc/3+/oaS8lJrSHWcNG3webyW+mxI24BxCod+LCaw7BKGB5aptfwqVnzxZn0B Yj671tiNxR4ijbqZr0ZL2/ql5Pcqhbtjl6IEKt8CqMtyzqzUPxGaDyOXze8AB4KZuLYv /xIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717962687; x=1718567487; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jlz+MnA+KwlQpwg6U8tRlPYaxddr0TUxdT4ZVKTJqY8=; b=uQ5scXk0AkDzFBDKC1T5ZNQiWlueYS3DLGsS4uI9urb9V9ug23yxA/K4UispPHWHzN 3z+lowufnmUttwVSKMvjKb7yP5iEVHCAEGaZhnaINVf+i1lRGWnUB6G/2c0fu5EM1D2j 6AKOCk8Ke+FkbWEe2l4Vc9RwOzE9oFAwokICLO+hdS3T5/bHCOEIoTPBvRPSctQTSNeV gr7L3EE33iTDPj8zd5wdRnnXd228+L9mGpuZ9CjSEZq/9I5wj0Xwlgw3Pg32EY8OXOJ5 hpe66hhgslwlay1vXDcevCehfW8ig9rvfgpppDzLPWDHCkpMTCGtyJoieODWWjcaM662 vjaQ== X-Gm-Message-State: AOJu0Yxl15cN7mKb7a+1aDKGZqMWjRN9SNats/ns/TFebzm5XwTwKXry z02o1i0JSEinPJsjRCTCgHA5UhNVIuVoVValSqQPkceWfUCgRpbBCETCoQ== X-Received: by 2002:ac8:7d88:0:b0:43d:f0e4:65ef with SMTP id d75a77b69052e-44041c21c5amr85997001cf.4.1717962687390; Sun, 09 Jun 2024 12:51:27 -0700 (PDT) Received: from TheosMacStudio.home ([70.24.176.136]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44055753c23sm17467521cf.81.2024.06.09.12.51.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 09 Jun 2024 12:51:26 -0700 (PDT) From: Theo Fabi To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Jun 2024 15:51:08 -0400 Message-ID: <20240609195108.14606-1-fabi.theo@gmail.com> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] avdevice/avfoundation: add external video devices X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Theo Fabi Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: hjIb4pfYxuLB Video devices categorized by AVFoundation as 'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not recognized by libavdevice. Signed-off-by: Theo Fabi --- libavdevice/avfoundation.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index e558ad7d90..c5a09c6563 100644 --- a/libavdevice/avfoundation.m +++ b/libavdevice/avfoundation.m @@ -788,6 +788,9 @@ static NSArray* getDevicesWithMediaType(AVMediaType mediaType) { #endif #if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 170000 || (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 140000)) [deviceTypes addObject: AVCaptureDeviceTypeContinuityCamera]; + [deviceTypes addObject: AVCaptureDeviceTypeExternal]; + #elif (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED < 140000) + [deviceTypes addObject: AVCaptureDeviceTypeExternalUnknown]; #endif } else if (mediaType == AVMediaTypeAudio) { #if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 170000 || (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 140000))