From patchwork Mon Jun 10 19:03:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 49778 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp2732977vqo; Mon, 10 Jun 2024 12:03:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWc/FFDNDSfnvJSinpQZBbLmP1DvT4lCUC6h1qwbxmSVIITChz5UvYAm9QVJmzeq5LgGC71hVLLMmvQDdMY7IzSH3NKOxly/ni8zA== X-Google-Smtp-Source: AGHT+IE4nQYZ5AeLuxIDLWVQv1gUsYVvCnDgXDhxgX90VHs5bDYTbDuOLkYDNaNyEVj/aqrYuuaX X-Received: by 2002:a17:906:d8a4:b0:a6e:feb5:14a8 with SMTP id a640c23a62f3a-a6efeb515famr404714766b.39.1718046199546; Mon, 10 Jun 2024 12:03:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718046199; cv=none; d=google.com; s=arc-20160816; b=ofmLHbWxGbcAPD0agjQTTgEruvm089OzWB4W71TGwZdGOBlEg7NaVAahCiS4A74JKc 0w+eEaVhcMcxYL7PLJcBFn+ILJYpnaBzl/DLs6SyhFfeVGZLcf6UQgmmXnOYCaY30Y8f fsy1NpWP5kkBUu1076c4wx99a0Wbyd2sHKc4OWSGZvDLj+co+k5GBQkyWuXZttq6rsHd gsqMm2SKsQidNAYAIgIGpm8qidvs35VS5NiZdAkAf0yGo536hIRYJmicNiTFyprFqHHU ZsnCVfH9A31YFbOAftzfNr/CWZbnDhXUZf44dNRbYCZMx4zIQqrcBS6047p2u74aeOQ1 j4KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=tzawTMK0ZYnqZHuk+XEBAxaaFTSIGcM2JCIhLwNDrhs=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=kHZYWLoVzdwHqV+AU4f9GSoYaSGULqQ5GCgUu+PnhDnl5vthJUx3iwtHBipYV2H7QA +JXOzWh5sExajeFvy/nRyURb5eMx3OD2d3N2bAvozRTFZ+naILQyhztnVn1xK9l3qfSY +BI4V70TeRIMMxPE7MUUXe4dFMXNL2KW0qZAV5U9Z+Jr+64d0JbQ16K47PRLZImrmFAU +1FtumI8N5dXSEAoF+lv3l8SOVFo3ZsebWZkBSbS371+CWtuyPOxtaNQvpezG9zE7Ldz IIW1/CsvWPAfxKULZ6n0EBiLR8civJh1Mr59/PvoLcthGNQgZrcWvX6iaSpaQJzwld8h Q0rw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a6f16a19c67si177086666b.743.2024.06.10.12.03.18; Mon, 10 Jun 2024 12:03:19 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6453168D512; Mon, 10 Jun 2024 22:03:15 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9BC2E68D512 for ; Mon, 10 Jun 2024 22:03:08 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id F1DC4C0069 for ; Mon, 10 Jun 2024 22:03:06 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 10 Jun 2024 22:03:06 +0300 Message-ID: <20240610190306.23569-1-remi@remlab.net> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/vc1dsp: match C block layout in inv_trans_4x4_rvv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: H2+T4Sa2VRUF Although checkasm does not verify this, the decoder requires that the transform updates the input block exactly like the C code does. This fixes vc1-ism, vc1_ilaced_twomv, vc1_sa00040, vc1_sa10091, vc1_sa10143, vc1_sa20021, vc1test_smm0005 and wmv3-drm-dec tests. --- libavcodec/riscv/vc1dsp_rvv.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/riscv/vc1dsp_rvv.S b/libavcodec/riscv/vc1dsp_rvv.S index ab10027ae5..c4517d54f5 100644 --- a/libavcodec/riscv/vc1dsp_rvv.S +++ b/libavcodec/riscv/vc1dsp_rvv.S @@ -380,12 +380,12 @@ func ff_vc1_inv_trans_4x4_rvv, zve32x vlsseg4e16.v v0, (a2), a3 li t1, 3 jal t0, ff_vc1_inv_trans_4_rvv - vsseg4e16.v v0, (a2) - addi t1, a2, 1 * 4 * 2 + vssseg4e16.v v0, (a2), a3 + addi t1, a2, 2 * 4 * 2 vle16.v v0, (a2) - addi t2, a2, 2 * 4 * 2 + addi t2, a2, 4 * 4 * 2 vle16.v v1, (t1) - addi t3, a2, 3 * 4 * 2 + addi t3, a2, 6 * 4 * 2 vle16.v v2, (t2) vle16.v v3, (t3) li t1, 7