From patchwork Tue Jun 11 13:44:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 49799 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:613:0:b0:460:55fa:d5ed with SMTP id 19csp411788vqg; Tue, 11 Jun 2024 06:44:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWZvH1hu3EslT2ze6IVba0E654h9UlQnKNHqCs9Yg+55nfr6RUWrzHxHVL1H/uayAMOOPe7EQqOPctgiqLv1EBoOdA8hSqiVfUW2A== X-Google-Smtp-Source: AGHT+IHkTmgHxp3IBcHV3E8rSESSmXK8Xq/KnhZWHgAygchobLulQYbafFX07gHIaC1g/3Teei81 X-Received: by 2002:a17:906:eea:b0:a69:edd:332d with SMTP id a640c23a62f3a-a6cd5615839mr716415466b.1.1718113492323; Tue, 11 Jun 2024 06:44:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718113492; cv=none; d=google.com; s=arc-20160816; b=Fe+lEfGYepEqiZ2Xc5qh39n2F/gvG5vTcL9IUy4OpmH1VDLDh8rzi5kMa02Cpp0mtu YjaLeF9JlJc4Fa+11M0uC6UBzy5Yc8FBnqgOpKFX9oGPK8UPb3/23/qwwRU6qWWC2nGL zYG+V2nJFveIDjSu8e1DDDDm6O6i4ORyR9lbB1PvDmcsA+nyX3MTvBhIoqH8g1Kke1qP 5nTrFnS7RPDErH9QDMLSQIcS00f2s+Yo011JL8mpk6dJKSK8gsFE1lCJspOduoYo6yL4 pgOTYgszC+NOiuX8NXIiJd+Qa3jTEGCi8nuWNYZMcJq6zsGq4O5EnR0jDbHisEMWV1Oh gb+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=1xVT8qZTpLvO9qwOEta1zECYW5+tnFU8rCSuKJswfHQ=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=QHPBU1voAgM54vjYPkFmGuSOgVNqh1G9ZwuzvhLbZ2WNWlye43zJhupobNt6fGnMnX TqfX9pjh65WJkO2XIz3z5nt460hy/MF5s7QvNDkBJ2Zy8DWP9+lGSOpjxkkmLiKHXcki yH7Pwe2ByA8vVc+K+I9sjvwAuDi2mB/3/v2dJdrPXVimbGWfTwX5Mgiis5JxSqVIdtEy 52kHW2lUfaM8faYxT9Xhka2k5/gcyabbisiNaOOzNpWrYn+qw5MahU/ox0WrKGy+K5W8 Zj7iNUSzXlkslkwpTSUG3lVfiV07rnSJe4hl4YFWpgXwCFoIeh7bvI32/9TYFCM0TPvY +ctQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=G+jhhEEJ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57c59c72873si4546725a12.654.2024.06.11.06.44.51; Tue, 11 Jun 2024 06:44:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=G+jhhEEJ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AE6468D84D; Tue, 11 Jun 2024 16:44:33 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 466F368D69E for ; Tue, 11 Jun 2024 16:44:26 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9FC081C0007 for ; Tue, 11 Jun 2024 13:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1718113465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JBJi2qanfZthi3asXEe92TTufa16h6CtVUU9aDl9nM4=; b=G+jhhEEJHW4FR1yf67P4EQYGjKuxXjJkrTY96sGMVXoQ+Lfpn09B3GgY76k+gRjOb7VHb/ DoKsrX7yR7uAg0AnBFUzFAYXKd6s32YUOl/ED5s8ia/W2N8ZojOPH+EmKVUPNr+sAnAXK7 M4m/ClZuuwwvDT77M7sZ4un2QThz5yGlZYZDsCZoDxV3Z6rlPTAjLtgz9H9KGP/MIaWiyC r/pUwBCHOUSXcqCAUrZ0Qsxk+rMkFsWMGjkIJW0SpQ0Jb4RPgGZmfiradiEbyL2QCQgfyP jxAyhcua3Iv+/kQb0rtb7HvkWz4DG4ZpLe6xuYQcNLZbXsqvuny0v/c2i63r2g== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 11 Jun 2024 15:44:21 +0200 Message-ID: <20240611134422.3172010-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240611134422.3172010-1-michael@niedermayer.cc> References: <20240611134422.3172010-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 3/4] avfilter/af_mcompand: compute half frequency in double X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 1dac84xDjHCd Fixes: CID1422217 Result is not floating-point Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_mcompand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index 89fe806a021..e63820efceb 100644 --- a/libavfilter/af_mcompand.c +++ b/libavfilter/af_mcompand.c @@ -418,8 +418,8 @@ static int config_output(AVFilterLink *outlink) } new_nb_items += sscanf(tstr2, "%lf", &s->bands[i].topfreq) == 1; - if (s->bands[i].topfreq < 0 || s->bands[i].topfreq >= outlink->sample_rate / 2) { - av_log(ctx, AV_LOG_ERROR, "crossover_frequency: %f, should be >=0 and lower than half of sample rate: %d.\n", s->bands[i].topfreq, outlink->sample_rate / 2); + if (s->bands[i].topfreq < 0 || s->bands[i].topfreq >= outlink->sample_rate / 2.0) { + av_log(ctx, AV_LOG_ERROR, "crossover_frequency: %f, should be >=0 and lower than half of sample rate: %f.\n", s->bands[i].topfreq, outlink->sample_rate / 2.0); return AVERROR(EINVAL); }