From patchwork Sun Jun 16 08:54:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lynne X-Patchwork-Id: 49942 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:9196:0:b0:460:55fa:d5ed with SMTP id s22csp1304456vqg; Sun, 16 Jun 2024 01:55:32 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUIiXZg/i17UMBcF0azaOFM04HYTRDXuHBKWMtl3Gx/lyz0qxyRgW3vEijpVK8BvzphFBqHl6V6IjdoakUSUNE4Ab8K+RPRoh72cA== X-Google-Smtp-Source: AGHT+IH7dVCg33aDNUXBh33Z6Xt0gd/3CupbSZJqDKskW20cgOs6Mp85p10sGD+TABFmsMflwx38 X-Received: by 2002:a2e:961a:0:b0:2e9:8a0a:ea05 with SMTP id 38308e7fff4ca-2ec0e46dbfamr48713321fa.17.1718528131950; Sun, 16 Jun 2024 01:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718528131; cv=none; d=google.com; s=arc-20160816; b=UjXSmzgMfJJBfnpiSaMiRYaBRiwtTF6SIIlIVqVJmBYbuiAL0g3GKptD1cGEFWTXWT /faXrpF3hvFjZJK7GhXfNhJO9+CdrVCs2JNkulklX3o14o69nm+CuzEjwjKN5tnnm/QD nkEmDhDkEN5we+YPuHGvcumRs9aidpFv2Ke1DwHz6lhJPAduZ9RizzdiRn5QmKWdgq+5 51MfZhOs83HvUi+5xXciB43kyhnwpQo4366gMb0aArP5+b8xjFoHYyiI6E5rlR9O4Plp 5t9525POvlXoK0d609bLCDGuyu07KhRxTtyBztUN76GIOQabYvhW8fXR6//j+6XfuR2L AU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to:from :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:delivered-to; bh=M4Hw+2oBhyvgAuvG6GPxMgjyJtMg4v9LdivJB1W1g0s=; fh=nenT92/WZoU6unXd3J6UhGUdod4piddKfVtctNBOh6k=; b=uxWd5ysXVdyILdPzHvftQTlUYkfwfXyAFmw01X68vXFOxTqDzzEYHpRVt/UYWO3Fk0 o+RuPrggU0VZGViIxg6vFT0Ygo0XVAf33ByCs6K4xv2NSNuHEafxoseq6cR+8IPyg2Tt ljsG2BY7ddWxqE7NFcXd3Ufm9Qjsr/XI8zwepvNF+wCclhUZ6D0I2/oQDoZd5mKgsPAR 0uZW4OKzG0jI6DIBKV/3WxMpaA3ttf4kM3ty4/ioyP+42yTYGvXv9Au13MrXd2kdmx4N oNHOcFcqZ7qCbQVDOUls2ct2KMU6ag80ZFcUs1LemQPxLWNxDmHO8le44vbB+zILvIW2 Si0Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 38308e7fff4ca-2ec05c7573csi19795321fa.466.2024.06.16.01.55.31; Sun, 16 Jun 2024 01:55:31 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B388568D6DF; Sun, 16 Jun 2024 11:55:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vidala.lynne.ee (vidala.pars.ee [116.203.72.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8CFAC68D1BB for ; Sun, 16 Jun 2024 11:55:01 +0300 (EEST) To: ffmpeg-devel@ffmpeg.org Date: Sun, 16 Jun 2024 10:54:45 +0200 Message-ID: <20240616085454.2560973-3-dev@lynne.ee> X-Mailer: git-send-email 2.45.1.288.g0e0cd299f1 In-Reply-To: <20240616085454.2560973-1-dev@lynne.ee> References: <20240616085454.2560973-1-dev@lynne.ee> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/6] aacdec_ac: fix an overread X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lynne via ffmpeg-devel From: Lynne Reply-To: FFmpeg development discussions and patches Cc: Lynne Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: lgb9fvWMBDJ9 Fixes reading state->last[i + 1] in ff_aac_ac_get_context for the last array member. --- libavcodec/aac/aacdec_ac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec_ac.h b/libavcodec/aac/aacdec_ac.h index 0b98c0f0d9..b8d4ade4c6 100644 --- a/libavcodec/aac/aacdec_ac.h +++ b/libavcodec/aac/aacdec_ac.h @@ -25,7 +25,7 @@ #include "libavcodec/get_bits.h" typedef struct AACArithState { - uint8_t last[512 /* 2048 / 4 */]; + uint8_t last[512 /* 2048 / 4 */ + 1]; int last_len; uint8_t cur[4]; uint16_t state_pre;