From patchwork Tue Jun 18 19:20:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 50001 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:9196:0:b0:460:55fa:d5ed with SMTP id s22csp2770708vqg; Tue, 18 Jun 2024 12:20:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVwUxOgR8iJpmsa5olxP8lBEeY5uzRvO4FLH/4duhT6N07z0olKXb41nOsoXtjw0R979+VVtutiL8xqNWiyUT/VmGHnJCi+yAc0Fg== X-Google-Smtp-Source: AGHT+IFcZIOmWcxdpfsCgwgTpDS1I1ugWUSO3Mp51fc65vuoWzP1cQeR57pDZhTw0zQQ3PCSkS5F X-Received: by 2002:a2e:a548:0:b0:2ec:3e14:fa1c with SMTP id 38308e7fff4ca-2ec3e14faf7mr746371fa.5.1718738457024; Tue, 18 Jun 2024 12:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718738457; cv=none; d=google.com; s=arc-20160816; b=CbHlEx1yqhMyzn3AE3VBd0PWJHurbBri83XQinaqu3SqQuum/gG2BzHCyQJ1AMUyrg qVjOlNTkNXu507AEUbwhPUvOe7u7ezpB3X0yeYZy6a2JynMjj/PF5wx+l3L29qIiGBNt VVB8QpjW+NIkuStks/lAAbP9ydjmDu+jujZmIBessw7a7EVbRFhM+xqaPI6orE1cglDc IvT3AxfbUBy2YVChYhPF0VK/WVu3wHoq50gv64NVVXzrUCuuqotl2gHisxoYEZBAI3cq YnMH1CxiAmIMNhMZELmy+s0gi3k+hSmLF/MAeiEkkn/BoeMQ6xlexGiTaCXjenqZaflD xeEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=NTOCXMPP1JP0h1FGwZHc6g+r2uTx7UQ9vpRl0A2Mp5I=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=xA7hfLv4lYqxuolqBzYtrNaEX9dCDJDgNh9A6uIo76vTAUa4XiEI2G0R4l8ayBgAHy +ja4+IwfaQg880aLt1/pwTnt/okVjmV8m8yKTbNcBEPhgxELhOOvsi6/IsDhOVV8kLdu WPWgNpDoUv5QixCQBEmpYK1573bwhFrupPmrvNmWmU1JhNxsl8I0fEQcxc6zd6t0JFK6 gup9uggcfQ/jUGoykUvvhUoeqtNJGlz/yYl/yICnYdSkNBq1+bRjcOlW7fcTSBX21qqO V+MoBzJQnM/6o6NnodhqseJKQI35UI/ikeE/yPZ5CJiann016CoPn6B6nqY/fOv92vMZ hZWw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=FgbPmJ4R; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 38308e7fff4ca-2ec0625ef9fsi33432411fa.205.2024.06.18.12.20.56; Tue, 18 Jun 2024 12:20:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=FgbPmJ4R; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02353688177; Tue, 18 Jun 2024 22:20:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D8E8D68CCCD for ; Tue, 18 Jun 2024 22:20:45 +0300 (EEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7041e39a5beso4291901b3a.3 for ; Tue, 18 Jun 2024 12:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718738443; x=1719343243; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=qbSqH86A5CZ4QsOsRAfWigsXlC8JEaRAzgfxjjZu2Zk=; b=FgbPmJ4RNF3YFvQhM/gu5fDMP4JFmUsT66vJbO/puz4M1pZ69agsqBVomple5p7u2q pX+xxaqQIgd9rekMomrnQVeacbja6cvoIHSzEuRYTRFukMQ8+FElpCQ4+Lm7dl6NhxGe oEl78C3etehf6AO3X6XZqTqNEnjnjyQq6hunshetw+XRT9jPq3+GY820ZJlrEKOJ5Apr 4vGJaIPozn+5jR2QOywUz6XGie91qjBsxVM1YNOaxSYcn8kmuzDtG5W7pc8fkM6PLZUI eA7OOTBuX72+EAwbwhyWb+d5S9OGK0GreWa0TSfC+103M1tNSZIkxbu9ErWAs/yY5fYS MEqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718738443; x=1719343243; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qbSqH86A5CZ4QsOsRAfWigsXlC8JEaRAzgfxjjZu2Zk=; b=ODSTS7x6fWIBWxHlRWMvPeWUj07M2w5bwN9toGrVjKAdxCTDLuaOSUFXOvRwpLf/oj Wg1BfAylV2VhYEIPo5hqDUgfRLAYCc08WFHFunm9EH2oRa8D+Y9QwW61WNBfF2Fam+sg e96IQfZuQTKO3UiJKbT9CmoJWfl80NI7Dm37YnGwv4sNW54BlLQm0PV5dLgCYXO/xh89 Ds327y6mH2mL5Nz/j5z1f+kwFTmrbOF9vFs9ZK41gKcxuDVA8BQv7lxzu/ZfciOHRkXO bXfBGKOVTViOuNKvShHMADnYDPFHcbaiC5FMjAp8NHj8O3AOLQZ9XRSAHA85lMJHREWw it7Q== X-Gm-Message-State: AOJu0YwDPU/QLwsiSWsgdTcoiNCU7yjYYei6iBGdxMYls4YRG3q8QCkJ zWI1c1g3FsGefZGA6wMdjMex9uNvQb9ComUiWzMbU8wg4y1xdWd7zoAE+A== X-Received: by 2002:a05:6a20:4694:b0:1b8:391f:df9a with SMTP id adf61e73a8af0-1bcbb580adcmr463207637.22.1718738443046; Tue, 18 Jun 2024 12:20:43 -0700 (PDT) Received: from localhost.localdomain ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb3d273sm9300175b3a.136.2024.06.18.12.20.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 12:20:42 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Tue, 18 Jun 2024 16:20:32 -0300 Message-ID: <20240618192034.5027-1-jamrial@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] avutil/ambient_viewing_environment: set a sane default value for AVRational fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: DcDoTmm6XnIN Prevent potential divisions by 0 when using them immediately after allocation. Signed-off-by: James Almer --- libavutil/ambient_viewing_environment.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavutil/ambient_viewing_environment.c b/libavutil/ambient_viewing_environment.c index c47458cfa8..e359727776 100644 --- a/libavutil/ambient_viewing_environment.c +++ b/libavutil/ambient_viewing_environment.c @@ -21,6 +21,13 @@ #include "ambient_viewing_environment.h" #include "mem.h" +static void get_defaults(AVAmbientViewingEnvironment *env) +{ + env->ambient_illuminance = + env->ambient_light_x = + env->ambient_light_y = (AVRational) { 0, 1 }; +} + AVAmbientViewingEnvironment *av_ambient_viewing_environment_alloc(size_t *size) { AVAmbientViewingEnvironment *env = @@ -28,6 +35,8 @@ AVAmbientViewingEnvironment *av_ambient_viewing_environment_alloc(size_t *size) if (!env) return NULL; + get_defaults(env); + if (size) *size = sizeof(*env); @@ -44,6 +53,7 @@ AVAmbientViewingEnvironment *av_ambient_viewing_environment_create_side_data(AVF return NULL; memset(side_data->data, 0, side_data->size); + get_defaults((AVAmbientViewingEnvironment *)side_data->data); return (AVAmbientViewingEnvironment *)side_data->data; }