From patchwork Tue Jun 18 19:35:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Haas X-Patchwork-Id: 50008 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:9196:0:b0:460:55fa:d5ed with SMTP id s22csp2780239vqg; Tue, 18 Jun 2024 12:43:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWRtTfZXjGbS1/x+XrV2ryTa5P/67AXNYriptIga+BMhXaFs1YR1fJ5MAji5mepUq4ogmgxxXBgifnhwR41VFVk8HRCwD7XyOa+Yg== X-Google-Smtp-Source: AGHT+IFoJ4E9e7Qqf1DlDlduCMTVuHn75J3x9Hw/PDnybBuzMWX0nN52g96rZY44fUpt2rkTxmlX X-Received: by 2002:a05:6000:2c8:b0:360:83d6:e2f0 with SMTP id ffacd0b85a97d-36319a856d8mr353706f8f.6.1718739802122; Tue, 18 Jun 2024 12:43:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718739802; cv=none; d=google.com; s=arc-20160816; b=NnQJhI2VovY5Yeju7V6ber7V2GAeSjgtJZdDoIBCy1TEGgAu1Shx9E/tujif6LxuoQ DkD2eRAOMZQLnk2eao6s3g5aWzxOJ/UJmaShQ/K/sndd36nkr7DURNNFOCnB+o+ChfTB V9pQ3z6kUJuXxNjpitzSuHiujj3OFg7gTiaghPPbbEu1h1sSeYE7rpxN6iiQxNePaehL sR6HAY1B45SxIRM9N25jU1IyC6wlXj2wAVYMGpN9kzwggNwHkeznZWqb7+FNwqEDzQnr kNv4LPaoJS8Ib9yLYETk95IZu5gpM/av19KQVeFQvjnaZES5d/AhI8l84wiDWyCa7O/K JD3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=4wyVxv89nfbGksDqmWcQj4qYhATvubKodaRzXud9g4o=; fh=xmAeKtysnShNOmkhiJmYkS30uw4Fu2hvBJ7qlIwukxQ=; b=ltP4vrNk+3tzSMiR3ndORsqM7Yvl+KJB2q8HG4sy/CQD/lTVBqUTm+RhXOauoiO1Ma UDwOYpgW/l0IVzT5A2qu0YJ8ziOftU7CpTvwr7cS7O8cgQq+5q/TXI+z2L0b4Whn8gHL eQHF8NDfq6Ca94qy4hW8RffIfBufV+Zb8hxFu7z5ODiOqZsvVGPGqYj/reja50tp3fpH QlreDoBeox6tL/XWi4IkdSQJ6Og/t5nUtyHrsFSr8RqCR571Wea6tBlnG4pWQ3+8iFuN KVgqRBBXrf+AhlrQhn+FA6RyO1lNLP3RPP2XvM49W/o+4GyM7s0XSKJKoLDR0sdZltmN e0KQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@haasn.xyz header.s=mail header.b=lAyKTxvV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57d039881c2si476990a12.216.2024.06.18.12.43.21; Tue, 18 Jun 2024 12:43:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@haasn.xyz header.s=mail header.b=lAyKTxvV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A9EA68D7BB; Tue, 18 Jun 2024 22:42:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE5BD68D74A for ; Tue, 18 Jun 2024 22:42:28 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1718739744; bh=Jn+NBhd1MOHJyrtBkMSijrBbQYMMSWSa2jD4amswplU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lAyKTxvVyPhnUCrkmGUgU0ngO9toxprpsXlrBGm7WjF7lTDv4ejtwAUd7zmMjG3TN JJWemuyH0CXCdaWOAk7qiZpxy6biyQZrTFwGJUZLf91XWaX0+j5jIQio8Ianpv2XEr QZrIy48lngCu7WHus512xsntghfPbaY9GA4W5zWo= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 7EB774371F; Tue, 18 Jun 2024 21:42:24 +0200 (CEST) From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Tue, 18 Jun 2024 21:35:35 +0200 Message-ID: <20240618194221.26073-6-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240618194221.26073-1-ffmpeg@haasn.xyz> References: <20240618194221.26073-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 5/8] avcodec/dovi_rpuenc: make encapsulation optional X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 2bn7t6FSDXR/ From: Niklas Haas And move the choice of desired container to `flags`. This is needed to handle differing API requirements (e.g. libx265 requires the NAL RBSP, but CBS BSF requires the unescaped bytes). --- libavcodec/dovi_rpu.h | 16 ++++++++++------ libavcodec/dovi_rpuenc.c | 22 ++++++++++------------ libavcodec/libaomenc.c | 3 ++- libavcodec/libsvtav1.c | 3 ++- libavcodec/libx265.c | 2 +- 5 files changed, 25 insertions(+), 21 deletions(-) diff --git a/libavcodec/dovi_rpu.h b/libavcodec/dovi_rpu.h index 65a4529106..226a769bff 100644 --- a/libavcodec/dovi_rpu.h +++ b/libavcodec/dovi_rpu.h @@ -123,16 +123,20 @@ int ff_dovi_attach_side_data(DOVIContext *s, AVFrame *frame); */ int ff_dovi_configure(DOVIContext *s, AVCodecContext *avctx); +enum { + FF_DOVI_WRAP_NAL = 1 << 0, ///< wrap inside NAL RBSP + FF_DOVI_WRAP_T35 = 1 << 1, ///< wrap inside T.35+EMDF +}; + /** - * Synthesize a Dolby Vision RPU reflecting the current state. Note that this - * assumes all previous calls to `ff_dovi_rpu_generate` have been appropriately - * signalled, i.e. it will not re-send already transmitted redundant data. + * Synthesize a Dolby Vision RPU reflecting the current state. By default, the + * RPU is not encapsulated (see `flags` for more options). Note that this + * assumes all previous calls to `ff_dovi_rpu_generate` have been + * appropriately signalled, i.e. it will not re-send already transmitted + * redundant data. * * Mutates the internal state of DOVIContext to reflect the change. * Returns 0 or a negative error code. - * - * This generates a fully formed RPU ready for inclusion in the bitstream, - * including the EMDF header (profile 10) or NAL encapsulation (otherwise). */ int ff_dovi_rpu_generate(DOVIContext *s, const AVDOVIMetadata *metadata, int flags, uint8_t **out_rpu, int *out_size); diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c index d8f113c5c4..65c36ed0ae 100644 --- a/libavcodec/dovi_rpuenc.c +++ b/libavcodec/dovi_rpuenc.c @@ -697,9 +697,7 @@ int ff_dovi_rpu_generate(DOVIContext *s, const AVDOVIMetadata *metadata, flush_put_bits(pb); rpu_size = put_bytes_output(pb); - switch (s->cfg.dv_profile) { - case 10: - /* AV1 uses T.35 OBU with EMDF header */ + if (flags & FF_DOVI_WRAP_T35) { *out_rpu = av_malloc(rpu_size + 15); if (!*out_rpu) return AVERROR(ENOMEM); @@ -726,10 +724,8 @@ int ff_dovi_rpu_generate(DOVIContext *s, const AVDOVIMetadata *metadata, flush_put_bits(pb); *out_size = put_bytes_output(pb); return 0; - - case 5: - case 8: - *out_rpu = dst = av_malloc(1 + rpu_size * 3 / 2); /* worst case */ + } else if (flags & FF_DOVI_WRAP_NAL) { + *out_rpu = dst = av_malloc(4 + rpu_size * 3 / 2); /* worst case */ if (!*out_rpu) return AVERROR(ENOMEM); *dst++ = 25; /* NAL prefix */ @@ -752,10 +748,12 @@ int ff_dovi_rpu_generate(DOVIContext *s, const AVDOVIMetadata *metadata, } *out_size = dst - *out_rpu; return 0; - - default: - /* Should be unreachable */ - av_assert0(0); - return AVERROR_BUG; + } else { + /* Return intermediate buffer directly */ + *out_rpu = s->rpu_buf; + *out_size = rpu_size; + s->rpu_buf = NULL; + s->rpu_buf_sz = 0; + return 0; } } diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index aa51c89e29..fd9bea2505 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -1294,7 +1294,8 @@ FF_ENABLE_DEPRECATION_WARNINGS const AVDOVIMetadata *metadata = (const AVDOVIMetadata *)sd->data; uint8_t *t35; int size; - if ((res = ff_dovi_rpu_generate(&ctx->dovi, metadata, 0, &t35, &size)) < 0) + if ((res = ff_dovi_rpu_generate(&ctx->dovi, metadata, FF_DOVI_WRAP_T35, + &t35, &size)) < 0) return res; res = aom_img_add_metadata(rawimg, OBU_METADATA_TYPE_ITUT_T35, t35, size, AOM_MIF_ANY_FRAME); diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index b6db63fd7a..e7b12fb488 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -541,7 +541,8 @@ static int eb_send_frame(AVCodecContext *avctx, const AVFrame *frame) const AVDOVIMetadata *metadata = (const AVDOVIMetadata *)sd->data; uint8_t *t35; int size; - if ((ret = ff_dovi_rpu_generate(&svt_enc->dovi, metadata, 0, &t35, &size)) < 0) + if ((ret = ff_dovi_rpu_generate(&svt_enc->dovi, metadata, FF_DOVI_WRAP_T35, + &t35, &size)) < 0) return ret; ret = svt_add_metadata(headerPtr, EB_AV1_METADATA_TYPE_ITUT_T35, t35, size); av_free(t35); diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4302c3d587..718bd21b20 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -783,7 +783,7 @@ static int libx265_encode_frame(AVCodecContext *avctx, AVPacket *pkt, sd = av_frame_get_side_data(pic, AV_FRAME_DATA_DOVI_METADATA); if (ctx->dovi.cfg.dv_profile && sd) { const AVDOVIMetadata *metadata = (const AVDOVIMetadata *)sd->data; - ret = ff_dovi_rpu_generate(&ctx->dovi, metadata, 0, + ret = ff_dovi_rpu_generate(&ctx->dovi, metadata, FF_DOVI_WRAP_NAL, &x265pic.rpu.payload, &x265pic.rpu.payloadSize); if (ret < 0) {