From patchwork Thu Jul 4 09:40:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramiro Polla X-Patchwork-Id: 50331 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:cc64:0:b0:482:c625:d099 with SMTP id k4csp3667839vqv; Thu, 4 Jul 2024 05:09:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX4lnxe5XMOjUJfAFYKyy1yEnWAK0Q6qi80Ojrbv5yufWCepqmCFlFdoSgh9MH2Zha0txd8xN5lYf+NRHU0FzyDdNT33ktJRgSOrg== X-Google-Smtp-Source: AGHT+IFNT2I4g2icSwUc0GKUZnZXzBcEmcWe8DLJAGJejW7CvhtjuqhpnIYvWbNZ+5zytCG1ZhIK X-Received: by 2002:a19:5e1a:0:b0:52e:74f5:d13 with SMTP id 2adb3069b0e04-52ea064174cmr948807e87.30.1720094946792; Thu, 04 Jul 2024 05:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720094946; cv=none; d=google.com; s=arc-20160816; b=psEZrD+fD2UJcU3j5dj6nDJQC5GxpnTRr8JgyMwjnZsPT8zoYxQgMYfTkgMv11xPeR 5Yryb8GeVze4gDidP0X+uMj82RUNHwVO7Zv5NXvYv0G9GDJcblaRgidb+jABmGZgu83E zO+Q1UEv3WmSuExQZXEiIvh26/vigUXqvzLI9F39j3ATCUpApEm/U/b8bNGvONVEv0JJ fQDuuiCJw2lccNHxTZo3PAGq0UXjGoXX/1VFzv/9vRH/UU/blM9j+EbPnATQxGYFfUT+ /MwgzcKEbwgCjUVTR4WIpDL2RsNvs6oe+TN/gPVSe1Zd/7HD6ZEvlH33sU3NZMsz7Wnm MW9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=/JK/t/EgwZFW5B7jw/3C5DuSBhp4l0+U9nA09fh/+ms=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=tuJx07DTtsxaeF6wt5AliJ6IyBCmEqy1A/Lpe1HFQlQAOu3mGohhGYcRwKU06JkgcR S2tk7je8CLowh34LL7ZQcrNlhJS0YKpZ5OnnX5zG1DjquTZoxm/xSHi261qyeqj9/fbf A/Uc7+AokpM0Js2IE5bzI/J8Wo+zWFih9eeCb1FhO+NBmHc/JrNhAj99EuBljkqMf8NS G89KNPxPW7vbkm6m581t/n1ehPl2nwyIHCrAdpuzPc/SaPwwO5uSm+4EKlz5CsfL2RWc Vo6X8IkjZjahmZuGsFZr5syJBwAYbf1voiNPN0c8cM318Q3VlqaUpzrEAzhO3c64xXnm EVVQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=R1CNUSZd; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 2adb3069b0e04-52e99459ee8si960154e87.63.2024.07.04.05.09.06; Thu, 04 Jul 2024 05:09:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=R1CNUSZd; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B76B668CC66; Thu, 4 Jul 2024 12:40:41 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DB5B68D87D for ; Thu, 4 Jul 2024 12:40:34 +0300 (EEST) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ec408c6d94so4445181fa.3 for ; Thu, 04 Jul 2024 02:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720086032; x=1720690832; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=oTBXyEtUttMHKvqDIuJeLUenfeihzH1hAROo+1DOp1c=; b=R1CNUSZdAZl14Me3MV3dnWM+opfItqeciKYybHP9svvs/oBZGTpUGNyKTfRAy7L9wI VWRJBrjitYHUnChyO5CTEg5GZGyplJydZKZbgx4XwDg149aeHQ5Ujbt4BhaMjhmEa8cV Oa66B0p1ri28vdnfmLcEjM6AqcqJ1cMtmGMonVv3CsVUznzx8mKQYdCF0MZygPFr1hVj oHQtrIWiuvdtU26Lu+p0qwaPGjKOKyhJQS/g2tqAB5DRoUuMm3o+9jly4AlQtmBc152V WUnEtfA6n/2z5x3lRdqo1avCExpehnMhooR9M4EdMQg/FP1zEpZp89Zbj8b4WrEuBCcJ NRIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720086032; x=1720690832; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oTBXyEtUttMHKvqDIuJeLUenfeihzH1hAROo+1DOp1c=; b=dd3PV4zIxh4U4mP7f0dQKtIjw+N+Em/A/+Ai2W1CQAZ5rAWXkyORTspnfX1k6F/u5H 68Iv2rvslT4+3C//HMVIPgSvdkIRh89pdMMHw8iOp4kxF4QXVBAgt0Uxg1OLUvau3tS+ 5Z7kSBLYcm+jrCuzVw2VpDuBxy3pV1GxOMZQ6c9uK/nCDcFrh9eMN/2GN4QtuTRdEQ9n 1roObrllClmiioL6ANl86lJafB5xdgS0wwioEGHVInV5dfy12qF74yAUi97FmY0znjSD GD/ISJzossPqn4QICwFkP9LyHIkO1iN5EV9X2LH9N6UPRq05a4vogn6exWRt3fH9XQc8 3efA== X-Gm-Message-State: AOJu0YwDKtacM/HZjs1KRofq5BF1MCpROcSSh2fnHp0cv1a1hSNiSFri KJLhiQtf0jc3d/LacHKRtrMsK/e6vclpcEC8aJ8ClGGoxmUch/HszWmk2spo X-Received: by 2002:a2e:b04a:0:b0:2ee:8573:eb51 with SMTP id 38308e7fff4ca-2ee8edd32bfmr7877411fa.34.1720086031160; Thu, 04 Jul 2024 02:40:31 -0700 (PDT) Received: from localhost.localdomain (35-44-144-178.mobileinternet.proximus.be. [178.144.44.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3679224d11dsm3926852f8f.12.2024.07.04.02.40.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 02:40:30 -0700 (PDT) From: Ramiro Polla To: ffmpeg-devel@ffmpeg.org Date: Thu, 4 Jul 2024 11:40:17 +0200 Message-Id: <20240704094018.410514-1-ramiro.polla@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] swscale: remove unconditional #define DITHER1XBPP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: SsQl8/muJ9/K This seems to have had an use in the past, but it is now defined unconditionally. --- libswscale/swscale_internal.h | 2 -- libswscale/utils.c | 4 ---- libswscale/x86/swscale.c | 2 -- libswscale/x86/swscale_template.c | 20 -------------------- libswscale/x86/yuv2rgb.c | 2 -- libswscale/x86/yuv2rgb_template.c | 4 ---- 6 files changed, 34 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 0818f50c7f..e5610161d0 100644 --- a/libswscale/swscale_internal.h +++ b/libswscale/swscale_internal.h @@ -46,8 +46,6 @@ #define MAX_FILTER_SIZE SWS_MAX_FILTER_SIZE -#define DITHER1XBPP - #if HAVE_BIGENDIAN #define ALT32_CORR (-1) #else diff --git a/libswscale/utils.c b/libswscale/utils.c index 12dba712c1..bc8d7627e2 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1952,14 +1952,10 @@ static av_cold int sws_init_single_context(SwsContext *c, SwsFilter *srcFilter, av_log(c, AV_LOG_INFO, "%s scaler, from %s to %s%s ", scaler, av_get_pix_fmt_name(srcFormat), -#ifdef DITHER1XBPP dstFormat == AV_PIX_FMT_BGR555 || dstFormat == AV_PIX_FMT_BGR565 || dstFormat == AV_PIX_FMT_RGB444BE || dstFormat == AV_PIX_FMT_RGB444LE || dstFormat == AV_PIX_FMT_BGR444BE || dstFormat == AV_PIX_FMT_BGR444LE ? "dithered " : "", -#else - "", -#endif av_get_pix_fmt_name(dstFormat)); if (INLINE_MMXEXT(cpu_flags)) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index ad7f67f90e..43319fd6b2 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -40,8 +40,6 @@ const DECLARE_ALIGNED(8, uint64_t, ff_dither8)[2] = { #if HAVE_INLINE_ASM -#define DITHER1XBPP - DECLARE_ASM_CONST(8, uint64_t, bF8)= 0xF8F8F8F8F8F8F8F8LL; DECLARE_ASM_CONST(8, uint64_t, bFC)= 0xFCFCFCFCFCFCFCFCLL; diff --git a/libswscale/x86/swscale_template.c b/libswscale/x86/swscale_template.c index 6190fcb4fe..6bff2a44aa 100644 --- a/libswscale/x86/swscale_template.c +++ b/libswscale/x86/swscale_template.c @@ -384,11 +384,9 @@ static void RENAME(yuv2rgb565_X_ar)(SwsContext *c, const int16_t *lumFilter, YSCALEYUV2RGBX "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%0), %%mm2\n\t" "paddusb "GREEN_DITHER"(%0), %%mm4\n\t" "paddusb "RED_DITHER"(%0), %%mm5\n\t" -#endif WRITERGB16(%4, "%5", %%FF_REGa) YSCALEYUV2PACKEDX_END } @@ -408,11 +406,9 @@ static void RENAME(yuv2rgb565_X)(SwsContext *c, const int16_t *lumFilter, YSCALEYUV2RGBX "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%0), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%0), %%mm4 \n\t" "paddusb "RED_DITHER"(%0), %%mm5 \n\t" -#endif WRITERGB16(%4, "%5", %%FF_REGa) YSCALEYUV2PACKEDX_END } @@ -461,11 +457,9 @@ static void RENAME(yuv2rgb555_X_ar)(SwsContext *c, const int16_t *lumFilter, YSCALEYUV2RGBX "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%0), %%mm2\n\t" "paddusb "GREEN_DITHER"(%0), %%mm4\n\t" "paddusb "RED_DITHER"(%0), %%mm5\n\t" -#endif WRITERGB15(%4, "%5", %%FF_REGa) YSCALEYUV2PACKEDX_END } @@ -485,11 +479,9 @@ static void RENAME(yuv2rgb555_X)(SwsContext *c, const int16_t *lumFilter, YSCALEYUV2RGBX "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%0), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%0), %%mm4 \n\t" "paddusb "RED_DITHER"(%0), %%mm5 \n\t" -#endif WRITERGB15(%4, "%5", %%FF_REGa) YSCALEYUV2PACKEDX_END } @@ -891,11 +883,9 @@ static void RENAME(yuv2rgb555_2)(SwsContext *c, const int16_t *buf[2], YSCALEYUV2RGB(%%FF_REGBP, %5) "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%5), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%5), %%mm4 \n\t" "paddusb "RED_DITHER"(%5), %%mm5 \n\t" -#endif WRITERGB15(%%FF_REGb, DSTW_OFFSET"(%5)", %%FF_REGBP) "pop %%"FF_REG_BP" \n\t" "mov "ESP_OFFSET"(%5), %%"FF_REG_b" \n\t" @@ -920,11 +910,9 @@ static void RENAME(yuv2rgb565_2)(SwsContext *c, const int16_t *buf[2], YSCALEYUV2RGB(%%FF_REGBP, %5) "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%5), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%5), %%mm4 \n\t" "paddusb "RED_DITHER"(%5), %%mm5 \n\t" -#endif WRITERGB16(%%FF_REGb, DSTW_OFFSET"(%5)", %%FF_REGBP) "pop %%"FF_REG_BP" \n\t" "mov "ESP_OFFSET"(%5), %%"FF_REG_b" \n\t" @@ -1240,11 +1228,9 @@ static void RENAME(yuv2rgb555_1)(SwsContext *c, const int16_t *buf0, YSCALEYUV2RGB1(%%FF_REGBP, %5) "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%5), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%5), %%mm4 \n\t" "paddusb "RED_DITHER"(%5), %%mm5 \n\t" -#endif WRITERGB15(%%FF_REGb, DSTW_OFFSET"(%5)", %%FF_REGBP) "pop %%"FF_REG_BP" \n\t" "mov "ESP_OFFSET"(%5), %%"FF_REG_b" \n\t" @@ -1261,11 +1247,9 @@ static void RENAME(yuv2rgb555_1)(SwsContext *c, const int16_t *buf0, YSCALEYUV2RGB1b(%%FF_REGBP, %5) "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%5), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%5), %%mm4 \n\t" "paddusb "RED_DITHER"(%5), %%mm5 \n\t" -#endif WRITERGB15(%%FF_REGb, DSTW_OFFSET"(%5)", %%FF_REGBP) "pop %%"FF_REG_BP" \n\t" "mov "ESP_OFFSET"(%5), %%"FF_REG_b" \n\t" @@ -1293,11 +1277,9 @@ static void RENAME(yuv2rgb565_1)(SwsContext *c, const int16_t *buf0, YSCALEYUV2RGB1(%%FF_REGBP, %5) "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%5), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%5), %%mm4 \n\t" "paddusb "RED_DITHER"(%5), %%mm5 \n\t" -#endif WRITERGB16(%%FF_REGb, DSTW_OFFSET"(%5)", %%FF_REGBP) "pop %%"FF_REG_BP" \n\t" "mov "ESP_OFFSET"(%5), %%"FF_REG_b" \n\t" @@ -1314,11 +1296,9 @@ static void RENAME(yuv2rgb565_1)(SwsContext *c, const int16_t *buf0, YSCALEYUV2RGB1b(%%FF_REGBP, %5) "pxor %%mm7, %%mm7 \n\t" /* mm2=B, %%mm4=G, %%mm5=R, %%mm7=0 */ -#ifdef DITHER1XBPP "paddusb "BLUE_DITHER"(%5), %%mm2 \n\t" "paddusb "GREEN_DITHER"(%5), %%mm4 \n\t" "paddusb "RED_DITHER"(%5), %%mm5 \n\t" -#endif WRITERGB16(%%FF_REGb, DSTW_OFFSET"(%5)", %%FF_REGBP) "pop %%"FF_REG_BP" \n\t" "mov "ESP_OFFSET"(%5), %%"FF_REG_b" \n\t" diff --git a/libswscale/x86/yuv2rgb.c b/libswscale/x86/yuv2rgb.c index 41dfa80f33..ddc7cca2c8 100644 --- a/libswscale/x86/yuv2rgb.c +++ b/libswscale/x86/yuv2rgb.c @@ -39,8 +39,6 @@ #if HAVE_X86ASM -#define DITHER1XBPP // only for MMX - //SSSE3 versions #undef RENAME #define RENAME(a) a ## _ssse3 diff --git a/libswscale/x86/yuv2rgb_template.c b/libswscale/x86/yuv2rgb_template.c index a4741e6873..abaf80eec2 100644 --- a/libswscale/x86/yuv2rgb_template.c +++ b/libswscale/x86/yuv2rgb_template.c @@ -75,11 +75,9 @@ static inline int RENAME(yuv420_rgb15)(SwsContext *c, const uint8_t *src[], YUV2RGB_LOOP(2) -#ifdef DITHER1XBPP c->blueDither = ff_dither8[y & 1]; c->greenDither = ff_dither8[y & 1]; c->redDither = ff_dither8[(y + 1) & 1]; -#endif RENAME(ff_yuv_420_rgb15)(index, image, pu - index, pv - index, &(c->redDither), py - 2 * index); } @@ -95,11 +93,9 @@ static inline int RENAME(yuv420_rgb16)(SwsContext *c, const uint8_t *src[], YUV2RGB_LOOP(2) -#ifdef DITHER1XBPP c->blueDither = ff_dither8[y & 1]; c->greenDither = ff_dither4[y & 1]; c->redDither = ff_dither8[(y + 1) & 1]; -#endif RENAME(ff_yuv_420_rgb16)(index, image, pu - index, pv - index, &(c->redDither), py - 2 * index); }