From patchwork Thu Jul 4 14:30:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Haas X-Patchwork-Id: 50339 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:cc64:0:b0:482:c625:d099 with SMTP id k4csp3764492vqv; Thu, 4 Jul 2024 07:49:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUqw0JhSsalzmifi8Zvqrqs9oPNU9TqRPvHvjYD1Tc7uKegzexRktd1wc7oUoM0h6soACQ1w49P1K0JvGTjQkGWhyqY9YENWKbuNg== X-Google-Smtp-Source: AGHT+IENMaDVxoMQSXnZ/ooNUGNdTcKtBs5N4vVKMbxickg+RJ1H2hXS3bvkf92gPHXfwZiZBdNu X-Received: by 2002:a05:6512:3e19:b0:52e:7542:f469 with SMTP id 2adb3069b0e04-52ea04352edmr2269606e87.0.1720104548871; Thu, 04 Jul 2024 07:49:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720104548; cv=none; d=google.com; s=arc-20160816; b=MH9Mu428HB2CKkVXYW08gxzwrG3gZJTNi01lGKXlT5bzeFX2Zb/Q/EKB5TLNIjy6zr eMATe6tJdQRra6Y1MD5xEML0nAu2fBSp+kOpZjXik36i/9lK6suTjgjxtacqgeaaTCRS Qjuu3ak8YrRcVXzVpWAsSMSqyCb/qnkIZi9oVcDFn+TLRNew5TZW8KjzIwmuyZDNn+0P DseGzUeKaWxyjbpQ64XFtumBHNVajZ3wTGI6b9A7D/3Xs/+lFvSpTfziBSv0XjMhI88s Ci+K8bb5BMLVcW/6DzLMrcO2bwnbFNFJ4bwaigPd5PQgakeae1gveMwq0hLrZjwVVKK9 pt4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=hXB2lwVPaIKpGLxEArgZI78H0KBho68NRciyDkLVE4c=; fh=xmAeKtysnShNOmkhiJmYkS30uw4Fu2hvBJ7qlIwukxQ=; b=t+aEj0yEBw0szuxkAY6gM5ATwm0LMkfS25TMdIDPYVxFmDnbWDNg2D5kOeZGUVgLZz coopYQnmwfcOlK1B4EJaOHtcr6c0hOdEJj7P1ydSc/ClJYof3S4MVzFrI1y+hB0WO93F ZmBgvByvKs0V7+O5PJdeKjTaR3GzioIzcWYtZ2X4RIzbn9QC7ti/hseq4EDF0wpmAFgl vxBKrqcoT4CAO4b7nP04xAe0kMZgKsrtuSncyBc5jOjZg5AWtexKGJmcOOQ2ZfX2Efus C9VRlFHPcfOrBmY7btlOMmc6gRWrSm7MXI1Zu4/SyvVQJDsJsKXzu4ZyuK4sIIDmr/jd iFHw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@haasn.xyz header.s=mail header.b=V+AqU2+V; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 2adb3069b0e04-52e99fddd2dsi998366e87.578.2024.07.04.07.49.08; Thu, 04 Jul 2024 07:49:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@haasn.xyz header.s=mail header.b=V+AqU2+V; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F07F68D9FA; Thu, 4 Jul 2024 17:31:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4DBFF68D9AE for ; Thu, 4 Jul 2024 17:31:07 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1720103467; bh=dRaAxaJdeXgnr5OlANUQFjp62oieGYX7zyJCc7x2UYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V+AqU2+V8eeBrj3II1xtei6UrLbZezdWEhDTefCorxmhHgUSHuBt8eB2uu+thSEXx jVH8Yd1p6TRr2w+GHtbCVrGtHFKxRs9JUjDBAXadXFWF8d+NjBTxtFBBG0ApvdfJmw PeOuLjEGvaM9m8uyndrb1U5PVbG9+wUnzrKYsirg= Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 0DA94405C5; Thu, 4 Jul 2024 16:31:07 +0200 (CEST) From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Thu, 4 Jul 2024 16:30:58 +0200 Message-ID: <20240704143104.1821386-2-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240704143104.1821386-1-ffmpeg@haasn.xyz> References: <20240704143104.1821386-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 2/8] avfilter/vf_setparams: allow setting chroma location X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: XdBJN989mIca From: Niklas Haas Shockingly, there isn't currently _any_ filter for overriding this. --- doc/filters.texi | 17 +++++++++++++++++ libavfilter/vf_setparams.c | 19 ++++++++++++++++--- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index c9c4f7cf6b..ca8f6e461a 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -22073,6 +22073,23 @@ Keep the same colorspace property (default). @item chroma-derived-c @item ictcp @end table + +@item chroma_location +Set the chroma sample location. +Available values are: + +@table @samp +@item auto +Keep the same chroma location (default). + +@item unspecified, unknown +@item left +@item center +@item topleft +@item top +@item bottomleft +@item bottom +@end table @end table @section sharpen_npp diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c index b7da8eb54b..ba32a6699c 100644 --- a/libavfilter/vf_setparams.c +++ b/libavfilter/vf_setparams.c @@ -41,6 +41,7 @@ typedef struct SetParamsContext { int color_primaries; int color_trc; int colorspace; + int chroma_location; } SetParamsContext; #define OFFSET(x) offsetof(SetParamsContext, x) @@ -119,6 +120,17 @@ static const AVOption setparams_options[] = { {"chroma-derived-c", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCOL_SPC_CHROMA_DERIVED_CL}, INT_MIN, INT_MAX, FLAGS, .unit = "colorspace"}, {"ictcp", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCOL_SPC_ICTCP}, INT_MIN, INT_MAX, FLAGS, .unit = "colorspace"}, {"ipt-c2", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCOL_SPC_IPT_C2}, INT_MIN, INT_MAX, FLAGS, .unit = "colorspace"}, + + {"chroma_location", "select chroma sample location", OFFSET(chroma_location), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCHROMA_LOC_NB-1, FLAGS, .unit = "chroma_location"}, + {"auto", "keep the same chroma location", 0, AV_OPT_TYPE_CONST, {.i64=-1}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"unspecified", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_UNSPECIFIED}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"unknown", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_UNSPECIFIED}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"left", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_LEFT}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"center", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_CENTER}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"topleft", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_TOPLEFT}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"top", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_TOP}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"bottomleft", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_BOTTOMLEFT}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, + {"bottom", NULL, 0, AV_OPT_TYPE_CONST, {.i64=AVCHROMA_LOC_BOTTOM}, INT_MIN, INT_MAX, FLAGS, .unit = "chroma_location"}, {NULL} }; @@ -174,17 +186,18 @@ FF_ENABLE_DEPRECATION_WARNINGS frame->flags &= ~AV_FRAME_FLAG_TOP_FIELD_FIRST; } - /* set range */ + /* set straightforward parameters */ if (s->color_range >= 0) frame->color_range = s->color_range; - - /* set color prim, trc, space */ if (s->color_primaries >= 0) frame->color_primaries = s->color_primaries; if (s->color_trc >= 0) frame->color_trc = s->color_trc; if (s->colorspace >= 0) frame->colorspace = s->colorspace; + if (s->chroma_location >= 0) + frame->chroma_location = s->chroma_location; + return ff_filter_frame(ctx->outputs[0], frame); }