From patchwork Fri Jul 5 00:21:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 50347 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:cc64:0:b0:482:c625:d099 with SMTP id k4csp4000246vqv; Thu, 4 Jul 2024 17:22:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXlT33aEccN2gN1GXIXUYxkSFXVclhsQKxGV5Tu2Voq5AuVAU9fXXhSBcRKb1Np/GMjjUOOAl5N8qy1+hsSzq1vKLhwTYHX+6zeKg== X-Google-Smtp-Source: AGHT+IHUOCszsFktxS8UXMROPBzFd82laN5zOtwaYA7NmMAwb4BRJQEayP96/lWRT7xQfEBDZ84o X-Received: by 2002:a17:907:969e:b0:a77:ab40:6d7f with SMTP id a640c23a62f3a-a77ba482a47mr257842166b.43.1720138958365; Thu, 04 Jul 2024 17:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720138958; cv=none; d=google.com; s=arc-20160816; b=tW25F8miWQVoHeUh5tH62sK2bn6OKas28BNbduvqHaTrUW1Mrx3IXyV/wZWxng6jYU ZzoDsDf/+iLQrWKmIsVtuIvNIMqfEGzuh/evSDRBdvy/i2ZSMLaib2LDFTzNLS+vrBby 0KuNdCtMh82ry0AXWegGUJTPZadA5evNctuxK6Tg0yd+NJO3DLI2UJk0IceIdXnr8HbZ 4XeZt8jnwHeMAxzFWYzHgKznKfWk2Ki1PN1PSV6EDm3pwEEREeWiNueMSyMKdB/f8NU5 ag39cMSlA7f4E+rrPYoHvFv40GQJeJiBbTMN2eQT+hq8ggRzrfdu1EOfKCMzwiNaYSCb nz7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=ZrA+skl0emfKA1w6FYPKQ3CtT5Eszfy+r4owSS5LPuU=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=AVMvhtDlJvBFQgQpK/T9J/Fy/zL3eYcXwve7kjVAFoH84qA0d2t/m3SLnhbZUWNzF6 yAJOkIRIzPC0QNe8KWTz6+EnlU0aiQj7c2knlO5WbMWScy3bbmPIetz2kBRf11K7GXdy 7or785UHYViWAD1cu3nL+eMR8A0Zqy9uydWwvurrtYbtCZSmsWFL9OFllmRfgJFNs6Of 93g3cZb/yTmGn+xrUJPVRIUwqh0c2T0gQwRQuxGNFVfuJ7W5KYcI3Gwu8GJ/VQkUFMtM Grluqg980MYDbe9X6DTtLK97f2qxiyCvIWNDdJNr3b1/XktgFTmcVTYbU4WHEGXb5ybZ Dvug==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=ey924W2z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a72ab04a09bsi747261966b.429.2024.07.04.17.22.38; Thu, 04 Jul 2024 17:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=ey924W2z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3BC6168DAEF; Fri, 5 Jul 2024 03:22:15 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 575E168D9FF for ; Fri, 5 Jul 2024 03:22:00 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B48C420003 for ; Fri, 5 Jul 2024 00:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720138919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a1tYX33PBCguPFmcykFTk3PAjYim9KA9MitjsSFqGFE=; b=ey924W2zbL/tvjfF8m/EroUpAectwPzS+nqdg384UWkC5kVQ3At5rmNFyxlTxQkDr2klWy Xt7RjuSo/OQQYu4V75SATfv3aWb3dnPs2vL4XLsBT08KjYI71W3aTuEJ6dsPO/0cWury+I Lh+Vev9KZa8XWuhfq3lJ1gNPcXrSI6U7opZJHHFxaMWyF9iTB2J9V232ZidqsV9XycKedQ HFuRIIoY80Wn/g6pToR3vOSE2KMLfdoiSn2O/TWgl5IRUMLLYZUeMG5yWaB2JW/zdoPdnw XEFqJlYDvN6k5bKe3pNoFEwN1Phpaq+ly8ujIufr0XcrsMq9m3+qx1ggXSXLwQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 5 Jul 2024 02:21:45 +0200 Message-ID: <20240705002156.1964272-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240705002156.1964272-1-michael@niedermayer.cc> References: <20240705002156.1964272-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 04/15] avcodec/golomb: Document return for get_ur_golomb_jpegls() and get_sr_golomb_flac() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: UifG2eY3Ne8K Found while reviewing code related to CID1604409 Overflowed return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/golomb.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h index 164c2583b6c..9f60fe03976 100644 --- a/libavcodec/golomb.h +++ b/libavcodec/golomb.h @@ -424,6 +424,8 @@ static inline int get_ur_golomb(GetBitContext *gb, int k, int limit, /** * read unsigned golomb rice code (jpegls). + * + * @returns -1 on error */ static inline int get_ur_golomb_jpegls(GetBitContext *gb, int k, int limit, int esc_len) @@ -535,6 +537,8 @@ static inline int get_sr_golomb(GetBitContext *gb, int k, int limit, /** * read signed golomb rice code (flac). + * + * @returns INT_MIN on error */ static inline int get_sr_golomb_flac(GetBitContext *gb, int k, int limit, int esc_len)