From patchwork Fri Jul 5 00:21:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 50356 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:cc64:0:b0:482:c625:d099 with SMTP id k4csp4015757vqv; Thu, 4 Jul 2024 18:14:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW6m0T9kDS3tkM53SrecpIWrn6RKBDN6BNuunCNMuVkoGkMoC08h5Zz+t4clo8iGTCvSRFGTl9/Klx/3NzFcYNVHe4hB9Zq61mPYQ== X-Google-Smtp-Source: AGHT+IFzYOkuBaI4rotbLT+7n3A2vIGq2EJdReG6RcYUUJ56AL2pQJuYHZYfkZTWuqgCh/4vsA6V X-Received: by 2002:a05:6512:3ef:b0:52c:e728:cca1 with SMTP id 2adb3069b0e04-52ea063ab43mr2021020e87.39.1720142045971; Thu, 04 Jul 2024 18:14:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720142045; cv=none; d=google.com; s=arc-20160816; b=HOZixOgKg80FvRx0GfIRUZ5givoEh74bW/sq6RM63BbkgWCsiL0KUR1BAOOBpP+PF9 RlFrv84Gsli9YcFNgUIVKV246/O6qKNlblSBkmLhzWK0gLi15+E7fuyhs4Nt5/CHkw+h tYVotx6F1uCtHz7Mc8KxDNujI9pGfjFEfPAwt9GJszoOlUKE2Yq825L+L+Yly8L89c6f PjkYA2ugEQupIdWr1FIZHGTjuV8bbNMvt6KVdq7u+WWr55GqGEwUxshkDxfX1gYpE/x0 yNLsKP5wBu1SUhBATvkzBP2EaFvMPRfvixgEEWxb2P/IrLb11cCtpifNaGIoG2hOf5wD SKfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=gV3FaQD7U7qA+7KiT0kTwD4pDTm/6bcmgQRex8pM2fk=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=JGu0jBAg2qeL6X1AnPXKHn8n7YTU736VDmK/EGj1B0XuZNp9j6QjvQormq5+gNEUNA jAFbBi65UiLEQhXbF6zIZVy90y2hilSwImjTbLDui0mHQuarsSPLQmgj/ekI1xIfirX7 8phzngytzN/g7oYvB9h0iLOrtfesiW/MTsslvSkDYbZAECbtb6JptXHAxiYS55oHb8/v pqChmpfAi2dt8CV/xFvZbYtCoaUPw6Uzcgq7nqAJ0C3yEZv3SBJNs7Vi9zyP+SkkFKxs Gvz8Y4TQPDyBK+WQLrxIUv2MO7zPcOicc77JdGcY4xi6+QNAeWlNSajs4zCnXqSLuJ8E RBPw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=fAR2oG77; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 2adb3069b0e04-52ea168c6d2si711198e87.593.2024.07.04.18.14.05; Thu, 04 Jul 2024 18:14:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=fAR2oG77; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 917A168DB26; Fri, 5 Jul 2024 03:22:34 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B1ACD68D9AB for ; Fri, 5 Jul 2024 03:22:04 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1DBB1240003 for ; Fri, 5 Jul 2024 00:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720138924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SsrgdTjONhfblDrPkf8HG8qTP1E1Pguxn240/rj2eNg=; b=fAR2oG77u087R04LEu5h+gcs/Q9rq7qxZIKAc5EvoZi3zdEexbI2/pNiwgHxlI3s0h6lQy NOjo/MOhyUI/XaaXlfDkGWQ+usdVl0T/X+QQIdO73fT3jjH7EHhA21Ou2wr8RrHwGHm2BA mULluBpQLYFi9KJWnCVKJC6cSQzX0QChwuqZEZVPVhHR2urjbpJsR4Ch1/E365OzCYJ7Jd 1RDu333jEifDn/vTds1rk79WWkxhDDGC5vQnzQOj2DEeiBCp2X0sYec9xy7NjMgdWAy6z/ Y5L69i7ba4WfqwFsL5OKSfjjITPGMmyWMFcm4einIop/nSCYm/yki65o/9jKrg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 5 Jul 2024 02:21:50 +0200 Message-ID: <20240705002156.1964272-9-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240705002156.1964272-1-michael@niedermayer.cc> References: <20240705002156.1964272-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 09/15] avcodec/leaddec: Check init_get_bits8() for failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: XNts2LPRJmku Fixes: CID1604416 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/leaddec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index 947c7275bec..2f5152c2261 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -194,7 +194,9 @@ static int lead_decode_frame(AVCodecContext *avctx, AVFrame * frame, i++; } - init_get_bits8(&gb, s->bitstream_buf, size); + ret = init_get_bits8(&gb, s->bitstream_buf, size); + if (ret < 0) + return ret; if (avctx->pix_fmt == AV_PIX_FMT_YUV420P && zero) { for (int mb_y = 0; mb_y < avctx->height / 8; mb_y++)