From patchwork Mon Jul 8 22:24:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 50420 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:612c:fad:b0:482:c625:d099 with SMTP id kf13csp29002vqb; Mon, 8 Jul 2024 15:24:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVaGu5EcnEA9BquO/Jcauh+JhyOUhM/XplCZPQiFSdftNh7iwoWi/jirSCRh9JbKMtyJ2PYsw/W7Nigcr+H6nW0LA3/IybbzeF0DQ== X-Google-Smtp-Source: AGHT+IGiUgj/pFSyqZBpN+9GXVJEAWmkplXSRg4yMHceO8SkfRGomQodKGXQDPgcjM9acSBl1rx4 X-Received: by 2002:a2e:8e76:0:b0:2ec:5685:f061 with SMTP id 38308e7fff4ca-2eeb30e46d7mr7765431fa.21.1720477473057; Mon, 08 Jul 2024 15:24:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720477473; cv=none; d=google.com; s=arc-20160816; b=ZLuZz3VxDYToBHqhqnBjnJvwB2re5kwl56thx5ihxm9Dh/o0v6Aa/DylSHinHZGPZ1 digD4x93/cy+LE4DndcVfTkeDbE4hkBUbIyExNClubkPi5ggid2/xRNG64zSdcVEAimA Jt+bLjWVpsE1jpQ7Ijr92Ylplh1HObYDW89D5lCHR4QbQbZ00U2NdVixo5Gt8gTw6Cax a89jBISXVFzFzUdpQQEx3DjyoDEQT0XeNkih0GCzA7FhfnTJNgHzdGWTYQ8bgqnixS04 PJ1zSTaa5gKGKNiXyD3H7sLrqMdOVxIXxEPP2Jb4/5DtUyfSohgHJbDUpdHhmwVmGAWG CY0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=avFGP71jyV/f4zHx9eICCyLeI5dezv2bcTLZ+uGnV8s=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=T5ea643usXTFVxlkL+CY05YGFCbCHpnGNCH+wGKH+lK11tSxUTQgB7eInFgrZaKT0a TAF4my2tI3y8IcUjuP3umn/UTH2yRcPH3ee5a0xiknYikGDBmDI5x9RcAIr0jf2gLDJm fpfPsMxHXMh3ThEpD6Ge/GrKc35ndEY4qRjszDmJGXKJXlpW2g9lnIWpliP1kwluDc5M smKvpIZANxVnFJqCB6kexYvlx76m/SFTg5r4Cmuc/BmfiekiZBulwqxFDleHxaSUa0l4 bIkGc9rkEff+Cghd22onj5WZw1wj+MFgSiPDsYffbfU9dmv0pPYl7qhXIciPm1qCWEDm vrMg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=l9C6meF8; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a780a9dd8b3si31526766b.226.2024.07.08.15.24.32; Mon, 08 Jul 2024 15:24:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=l9C6meF8; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6CF2268D9C6; Tue, 9 Jul 2024 01:24:23 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F4A768DA2B for ; Tue, 9 Jul 2024 01:24:13 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 73BCC1C0002 for ; Mon, 8 Jul 2024 22:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720477452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fFDt9peNAidf4ZJptH5yVrwvHgYMgvbKAFwjMPeCu08=; b=l9C6meF8DkY5MSOWmB13rk6dFSDdpzCcic59KOm/DklkIX0IRqBnl4lcOiyfVSUOMe/AEU n4GsX0s0rv8BC3TvgXXrWXgXYAumEA771xTTatO5XpgxkAlO4FpKZ7B0dY/IY/YCnuCw6i DBo1KDziZlSz/UPup0AdBxHR7bBTWwvhZeEVYZa1jkb7j3pw/xiFycYbElULdTZUr2G13V jtbSDCtgrqibJKc2PgSe5+TV6p0R40g1ehlrI0r8GLonDZpTT/DeYpE6ASGpvBIGTxdgp2 oahO2n0cRKop4p/oC1k8IG2ipQxROjiNvxY9TLtLdtqeEb4UEpKCK6iCiQCiLg== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Tue, 9 Jul 2024 00:24:04 +0200 Message-ID: <20240708222410.773456-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240708222410.773456-1-michael@niedermayer.cc> References: <20240708222410.773456-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 2/8] avfilter/vf_fftfilt: Remove dead depth code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: HmkV0T+hvmWk Fixes: CID1509373 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/vf_fftfilt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_fftfilt.c b/libavfilter/vf_fftfilt.c index 1ffbe02ec41..af0e1f51d24 100644 --- a/libavfilter/vf_fftfilt.c +++ b/libavfilter/vf_fftfilt.c @@ -382,11 +382,9 @@ static int config_props(AVFilterLink *inlink) if (s->depth <= 8) { s->rdft_horizontal = rdft_horizontal8; s->irdft_horizontal = irdft_horizontal8; - } else if (s->depth > 8) { + } else { s->rdft_horizontal = rdft_horizontal16; s->irdft_horizontal = irdft_horizontal16; - } else { - return AVERROR_BUG; } return 0; }