From patchwork Wed Jul 10 22:50:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 50459 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:b968:0:b0:482:c625:d099 with SMTP id w8csp706621vqx; Wed, 10 Jul 2024 15:50:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVujHb4mWbSWpemgag/w7wOZ37f4HHcR5wMrkl07kpjxXtkLA0fJQVMjiqqIZcH9QCKTHyLKij67D09c3d/7TaCSqhQXW6CwrLH4Q== X-Google-Smtp-Source: AGHT+IH/Hedx2pmoKPYn/YBxZsvfkxLKiDJoEq0s/5of/lc+EScFSkWyxtOCozKyPdaikIXvOZxY X-Received: by 2002:a17:906:1c0b:b0:a77:de2a:aef3 with SMTP id a640c23a62f3a-a780b6b1698mr428609266b.19.1720651827344; Wed, 10 Jul 2024 15:50:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720651827; cv=none; d=google.com; s=arc-20160816; b=HSU2imd/dFllMjq60HSnlRHibvZASwyPSkdyBvykMQ/La/uk+8nu8bUfeNxABzF8Pg kOOoClb1CvOsheEajfhwrpXD8/umUHBDtXvZ2AJCtadXx2h4L5w7i1wPZRAf9bGbvs3e 7aI1nFXv+JPjW9c3wLa0zNqEyjtrs0J1T6+foZSaqxWU4c5xdCI3/X2SMHBFwhBADCIN HM2E28X72CE8ssEXxuG0cJ+JhpwjxhM/i37g9IBA0Dz8n28Y50LPJgzi10b9HFO0dUr1 uEfT36Ykn+agNPCn9Ys51DuELZJcNyj2d/Qqkqdsy1P2y21w/h4x187jnSYncS/d924S 8Z2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=c/cgHuCeJTUv9TjOBhODo1Iq8jcNHlnlnV+I3813XJg=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=c6FzbFEKvYUkPielEYZVEZ5vQusMOHUt1VqeOD+ydd4F+ywB19opxFZKLyZ+jDJbb7 PvcEY+yEA52qQYyD554U+tjn8C7DkYTTIO4f/+osEM/fNtgOq1EtK9MpPwwVPCP4oMgg M6rl0UScvtSztLr9NPCSmQo1kFJqz59Z2QoAI7RPVc+b9ZGiowBFnNgtWfS6LATT9jM2 S15ck0mhv2h3BoJwaY2b3zhPp2AL2UlXnG8YPAQkt7voJrZdaEotafmsGDF8AWYjnvIg EZiYzJOl+uueodlFrNczL5mGpRaZgxi63H1aOg4jHxIZPVT/Bht2nF8IxHPUk37q6lHx 1rnw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=oPlrphMY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a780a9c88cfsi250598066b.165.2024.07.10.15.50.26; Wed, 10 Jul 2024 15:50:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=oPlrphMY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 65DEA68DB3A; Thu, 11 Jul 2024 01:50:22 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C563D68DA82 for ; Thu, 11 Jul 2024 01:50:14 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 96F0B40004 for ; Wed, 10 Jul 2024 22:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1720651813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FB2oTq5lWTsSHDQpMV8eKJjI+gDX5eAjUgEYj8fSuD8=; b=oPlrphMYS2CLYprZGMElxAxWyZnFm8fN1f773xjeOaJRwa8mNn2xyH6sanPty+TY0mgs+s 3sNevRH76KWQArH92Z8QxWbkAkGzjLbQdEeV4EmyqV1HNL36mj121W+xKafyygVLcCw4Qd Jr/nXQbpXN9jeOjyNz3yX3/O/xmrPDyBKk1MyPBIaUFfRWjBfzpfAgrodiSXBrVgt4Nqwj vB/zw97WFk7e/4kqYXoV1uC2+uE8XV6eB/lTpvMGPUFux+JvAYU/lnVcx/IJkhabgdHKOl OjoSaQ5OOZ4LUiAggXJqhyMqOJXNIYGVoVSc4tQQ5bDqHhxStiKodl63kk8v6Q== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 11 Jul 2024 00:50:07 +0200 Message-ID: <20240710225012.691594-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 1/6] avfilter/vf_tiltandshift: Free dst on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ZJFipcx+e9Tz Fixes: CID1559901 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/vf_tiltandshift.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshift.c index b49a713339d..08bcb062473 100644 --- a/libavfilter/vf_tiltandshift.c +++ b/libavfilter/vf_tiltandshift.c @@ -237,8 +237,10 @@ static int output_frame(AVFilterLink *outlink) // set correct timestamps and props as long as there is proper input ret = av_frame_copy_props(dst, s->input); - if (ret < 0) + if (ret < 0) { + av_frame_free(&dst); return ret; + } // discard frame at the top of the list since it has been fully processed list_remove_head(s);