diff mbox series

[FFmpeg-devel,5/5] fftools/ffprobe: implement dv_md_compression

Message ID 20240716112317.35745-5-ffmpeg@haasn.xyz
State New
Headers show
Series [FFmpeg-devel,1/5] avutil/dovi_meta: add dv_md_compression to cfg record | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Niklas Haas July 16, 2024, 11:23 a.m. UTC 
From: Niklas Haas <git@haasn.dev>

---
 fftools/ffprobe.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Cosmin Stejerean July 16, 2024, 11:32 a.m. UTC | #1 
> On Jul 16, 2024, at 1:23 PM, Niklas Haas <ffmpeg@haasn.xyz> wrote:
> 
> From: Niklas Haas <git@haasn.dev>
> 
> ---
> fftools/ffprobe.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index 0b7d4ce0d7..265718467f 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2611,6 +2611,7 @@ static void print_pkt_side_data(WriterContext *w,
>             print_int("el_present_flag", dovi->el_present_flag);
>             print_int("bl_present_flag", dovi->bl_present_flag);
>             print_int("dv_bl_signal_compatibility_id", dovi->dv_bl_signal_compatibility_id);
> +            print_int("dv_md_compression", dovi->dv_md_compression);
>         } else if (sd->type == AV_PKT_DATA_AUDIO_SERVICE_TYPE) {
>             enum AVAudioServiceType *t = (enum AVAudioServiceType *)sd->data;
>             print_int("service_type", *t);
> -- 
> 2.45.2
> 
> 

LGTM
Michael Niedermayer July 17, 2024, 6:07 p.m. UTC | #2 
On Tue, Jul 16, 2024 at 01:23:17PM +0200, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> ---
>  fftools/ffprobe.c | 1 +
>  1 file changed, 1 insertion(+)

breaks fate / needs update to fate

thx

[...]
Niklas Haas July 18, 2024, 10:52 a.m. UTC | #3 
On Wed, 17 Jul 2024 20:07:54 +0200 Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Tue, Jul 16, 2024 at 01:23:17PM +0200, Niklas Haas wrote:
> > From: Niklas Haas <git@haasn.dev>
> > 
> > ---
> >  fftools/ffprobe.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> breaks fate / needs update to fate

Fixed, thanks for pointing that out.

> 
> thx
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The smallest minority on earth is the individual. Those who deny 
> individual rights cannot claim to be defenders of minorities. - Ayn Rand
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 0b7d4ce0d7..265718467f 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2611,6 +2611,7 @@  static void print_pkt_side_data(WriterContext *w,
             print_int("el_present_flag", dovi->el_present_flag);
             print_int("bl_present_flag", dovi->bl_present_flag);
             print_int("dv_bl_signal_compatibility_id", dovi->dv_bl_signal_compatibility_id);
+            print_int("dv_md_compression", dovi->dv_md_compression);
         } else if (sd->type == AV_PKT_DATA_AUDIO_SERVICE_TYPE) {
             enum AVAudioServiceType *t = (enum AVAudioServiceType *)sd->data;
             print_int("service_type", *t);