Message ID | 20240720005241.726089-5-michael@niedermayer.cc |
---|---|
State | New |
Headers | show
Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:a742:0:b0:482:c625:d099 with SMTP id f2csp894249vqm; Fri, 19 Jul 2024 17:53:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVsNsuC1cmkHDk2hWECHc0fmjKJM6iM4NNiE2dqPDl1n2vZrBZNhu8EO5JpxF2/hlToDssGTBh2f9Hw3BF7sJniPvR6fMCW3D04yA== X-Google-Smtp-Source: AGHT+IHwP+nka+VIgjpJQjoL846crGtYVFbE+V+tvVXW48EeOQR0uk21NAgObbkiagLT4pFXHNOB X-Received: by 2002:a05:6512:3ba3:b0:52c:d8c7:49ce with SMTP id 2adb3069b0e04-52ee53b27demr7060052e87.22.1721436813101; Fri, 19 Jul 2024 17:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721436813; cv=none; d=google.com; s=arc-20160816; b=FFVrUJqKM/dCY9V8mn+74X/TD9zhCxHS/n/cUDrUOPXFYehQQMVa+gGLif0+3l/SbA RBe1ZvqL01tf/xWODOBk8YLDvFr2yZaQD6mntUTRysxKXSwhZP/HdQiYe4voqLxI6RnC R4uEJq3kc3PdAhHETcF1hjwQlg5j3hFkcdljsfk0oeNFQ2rB0GN6C57A5+cgCKENNb+D CCV39bRyAgVOpRQgeX5jEnuW/IfLdgCZgA8uqw/VzeUm9QqCH7R3sYIJyhnkDUXNcr31 rds5jekSnNLCk7BZbpv4LuE3dQJpkk4jmaFUqwynrbEKMRsWKikVp3HI5snPzMONU8MA f00Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=3HELPSJx2fQ+O/PGjojahOmpa3ZZ+q9iIg9qXMMkL0I=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=1H2WO1jUimPf7UuEPCI9mQ0y9wENp89aKT3l0PMqJKcqqydkO7grLpnLG6S2KUiQs1 0HCric3E8TzsRwLri8fXqKHjPz/T60Kw77svYdUVk5yl17haoUJ4e3Wk8Zy0zmvOSnJD 7Y2uUezBzQJjkIoVSP2SB1jfxlmXMy9pupt+tncjfsh4ACt0B48r4MjcMo8jxy0OJtvz tPlcwHA5yBHB2frt9Y77LcjmCUA6O9OVIqYOhW4M8b9ut6H8zWSXqmaeUKFAeLnovwp/ x6Lr2I/hIEH9xKnmlnipzuDe6cA18c2QGkJs8Xy90AbMm8phLspYQzIVcKmKeHHctZhC DPTg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=DI8edWTC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 2adb3069b0e04-52ef5542e60si667759e87.395.2024.07.19.17.53.32; Fri, 19 Jul 2024 17:53:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=DI8edWTC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 310FB68DA6F; Sat, 20 Jul 2024 03:52:56 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A49B168D8EC for <ffmpeg-devel@ffmpeg.org>; Sat, 20 Jul 2024 03:52:46 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1752EE0005 for <ffmpeg-devel@ffmpeg.org>; Sat, 20 Jul 2024 00:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1721436766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TZjvhaKj6snGc2/Iajjn+sqR+AK1G68HKDcBmJqx6zA=; b=DI8edWTCIoxcsuUpWqwPGp2q1mw1s3qCoQuUktf6vgmMe9PhtvVaX8So8RxyaIL04K7wri AnM+l9KJnD9TD8x5dthsVChyG+XOgFVrhdqFBzd+PRj0ZrwnbeALabhVgCwrWD4eWZQGRA gxUxsOKpDvKllzO1cYI6jlpJEN+CzKLgvrd2GWuh6EJtKsheMdbdEYp/FYeW7ERqUHvnme wZXKLWix9LTOFrf5FAE1D4kZRlYH6Pm0HmOYOX+BBCV43fvtGkRmDA5e3KvINSwbVwTtvk woIFdbgyaIPGzu5ls73zYu8qDKIYhxV6NdMRDr0wSBehMiN36zGa2AYoBaAr9g== From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Date: Sat, 20 Jul 2024 02:52:35 +0200 Message-ID: <20240720005241.726089-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240720005241.726089-1-michael@niedermayer.cc> References: <20240720005241.726089-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 05/11] avcodec/aac/aacdec_lpd: Check kv indec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> X-TUID: S5AT5J0llxgx |
Series |
[FFmpeg-devel,01/11] avcodec/alsdec: Clear shift_value
|
expand
|
diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c index 91a32688895..20bbb007ff3 100644 --- a/libavcodec/aac/aacdec_lpd.c +++ b/libavcodec/aac/aacdec_lpd.c @@ -130,6 +130,9 @@ int ff_aac_parse_fac_data(AACUsacElemData *ce, GetBitContext *gb, if (use_gain) ce->fac.gain = get_bits(gb, 7); + if (len/8 > 8) + return AVERROR_PATCHWELCOME; + for (int i = 0; i < len/8; i++) { ret = parse_codebook_idx(gb, ce->fac.kv[i], 1, 1); if (ret < 0)
Fixes: index 9 out of bounds for type 'uint32_t [8][8]' Fixes: 70363/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-6723855293415424.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/aac/aacdec_lpd.c | 3 +++ 1 file changed, 3 insertions(+)