From patchwork Mon Jul 22 18:12:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 50683 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:a742:0:b0:482:c625:d099 with SMTP id f2csp2200854vqm; Mon, 22 Jul 2024 11:51:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUQZcjh2W7+3s3VFAmf4G+Dnh6mHNyFbq9ZaY1Uh/DwN2C5GI12s39YSclR7eqJLQW/kiJ3eatARsk5vgFc9lbJRliiiMzA4Do25Q== X-Google-Smtp-Source: AGHT+IG/hMVXvk61GPLJxsWW5xKKeFVQN5tyu4+Muhs0vmwt0A7NpWjmVV2SasnlohlFHShql9aQ X-Received: by 2002:a05:6512:2392:b0:52e:9dee:a6ee with SMTP id 2adb3069b0e04-52efb75c1cfmr5321942e87.26.1721674312432; Mon, 22 Jul 2024 11:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721674312; cv=none; d=google.com; s=arc-20160816; b=cQ9lUtwMPB4SmR7ywvAUScnIaIem9e2HcsO5rh3TUOE2hMVey+uVUudyP5D4dZlPAT m9j1g07COMw7WgyXYKu736p+hWaEZlNlnmXiPPOhL1pR6ABW2rRrDXjVY7SZthR3NOEI 0u6mU8PGm+MqrqMfbxXatUoAaKwyQGs1b/LfUqdeYCH0F6cxHDo0YvzYOCga+V9Hcy8n wRz8fttswmADV2CTBIVgVtCegPksnScMgPQxPuguJbZ/L7R/gCDC+2Y9Tc0lW2260IZE nRogxkKIY+SSopN3Y789XNSh0xlx8S6sgjMJlBwUu71awt7F2yAlzX0QOj03ITkvHKOf rsZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=3AEooBBSwaEtLiX690ZcSYlcNvQDfx9mSxo7kWou8yM=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=wlZlF/gHEg1fM3lxuet/2wo4hz6/3d6IU5haGefqZy9OmiF5fI1LIsxDDz97ixjBFt QnuxtzKmNgtiEU3HABawlURJucRgus/iZ8deUkWkvwuaDSXe6bE9ir1twuue3OwM+hDv zjRTN30UEUP7U1ugfhzoUBMqdg/KleWJFD4LMi8rssufE8P7LDwryjsJ9L6jwmQd/t6k oE05iUXU90s2OlcxhPYl3v1slCDnhJt5H/Ih3qIy1ZY3DJDEqmxd2EN5BmX9AWkOR4Ug CCTdf1q39Ht5AogIzK/9/HcyU1FX50KTOc38bBOIMqCnEKXEnQHjeVs1krVPmk5UJxwC 5nMw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 2adb3069b0e04-52eff21e058si1252653e87.194.2024.07.22.11.51.51; Mon, 22 Jul 2024 11:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B70368D6FF; Mon, 22 Jul 2024 21:12:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC20968D695 for ; Mon, 22 Jul 2024 21:12:02 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 58405C01F0 for ; Mon, 22 Jul 2024 21:12:02 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 22 Jul 2024 21:12:00 +0300 Message-ID: <20240722181201.24563-3-remi@remlab.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240722181201.24563-1-remi@remlab.net> References: <20240722181201.24563-1-remi@remlab.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/4] lavc/vp9dsp: copy 8 pixels at once X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 08SrNWxsOTC+ In the 8-bit case, we can actually read/write 8 aligned pixel values per load/store, which unsurprisingly tends to be faster on 64-bit systems (and makes no differences on 32-bit systems). This requires ifdef'ing though. --- libavcodec/vp9dsp_template.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/libavcodec/vp9dsp_template.c b/libavcodec/vp9dsp_template.c index da3cc28e5e..9e5b25142d 100644 --- a/libavcodec/vp9dsp_template.c +++ b/libavcodec/vp9dsp_template.c @@ -49,14 +49,22 @@ static void vert_8x8_c(uint8_t *restrict _dst, ptrdiff_t stride, { pixel *dst = (pixel *) _dst; const pixel *top = (const pixel *) _top; +#if BIT_DEPTH == 8 + uint64_t p8 = AV_RN64A(top); +#else pixel4 p4a = AV_RN4PA(top + 0); pixel4 p4b = AV_RN4PA(top + 4); +#endif int y; stride /= sizeof(pixel); for (y = 0; y < 8; y++) { +#if BIT_DEPTH == 8 + AV_WN64A(dst, p8); +#else AV_WN4PA(dst + 0, p4a); AV_WN4PA(dst + 4, p4b); +#endif dst += stride; } } @@ -66,18 +74,28 @@ static void vert_16x16_c(uint8_t *restrict _dst, ptrdiff_t stride, { pixel *dst = (pixel *) _dst; const pixel *top = (const pixel *) _top; +#if BIT_DEPTH == 8 + uint64_t p8a = AV_RN64A(top); + uint64_t p8b = AV_RN64A(top + 8); +#else pixel4 p4a = AV_RN4PA(top + 0); pixel4 p4b = AV_RN4PA(top + 4); pixel4 p4c = AV_RN4PA(top + 8); pixel4 p4d = AV_RN4PA(top + 12); +#endif int y; stride /= sizeof(pixel); for (y = 0; y < 16; y++) { +#if BIT_DEPTH == 8 + AV_WN64A(dst + 0, p8a); + AV_WN64A(dst + 8, p8b); +#else AV_WN4PA(dst + 0, p4a); AV_WN4PA(dst + 4, p4b); AV_WN4PA(dst + 8, p4c); AV_WN4PA(dst + 12, p4d); +#endif dst += stride; } } @@ -87,6 +105,12 @@ static void vert_32x32_c(uint8_t *restrict _dst, ptrdiff_t stride, { pixel *dst = (pixel *) _dst; const pixel *top = (const pixel *) _top; +#if BIT_DEPTH == 8 + uint64_t p8a = AV_RN64A(top); + uint64_t p8b = AV_RN64A(top + 8); + uint64_t p8c = AV_RN64A(top + 16); + uint64_t p8d = AV_RN64A(top + 24); +#else pixel4 p4a = AV_RN4PA(top + 0); pixel4 p4b = AV_RN4PA(top + 4); pixel4 p4c = AV_RN4PA(top + 8); @@ -95,10 +119,17 @@ static void vert_32x32_c(uint8_t *restrict _dst, ptrdiff_t stride, pixel4 p4f = AV_RN4PA(top + 20); pixel4 p4g = AV_RN4PA(top + 24); pixel4 p4h = AV_RN4PA(top + 28); +#endif int y; stride /= sizeof(pixel); for (y = 0; y < 32; y++) { +#if BIT_DEPTH == 8 + AV_WN64A(dst + 0, p8a); + AV_WN64A(dst + 8, p8b); + AV_WN64A(dst + 16, p8c); + AV_WN64A(dst + 24, p8d); +#else AV_WN4PA(dst + 0, p4a); AV_WN4PA(dst + 4, p4b); AV_WN4PA(dst + 8, p4c); @@ -107,6 +138,7 @@ static void vert_32x32_c(uint8_t *restrict _dst, ptrdiff_t stride, AV_WN4PA(dst + 20, p4f); AV_WN4PA(dst + 24, p4g); AV_WN4PA(dst + 28, p4h); +#endif dst += stride; } }