From patchwork Wed Aug 14 22:37:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 51033 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:a746:0:b0:489:2eb3:e4c4 with SMTP id f6csp1238823vqm; Wed, 14 Aug 2024 16:16:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXS+2dYoZk3FpqvBrF3Kv1/h1obXYdBqiOhSAKtgpqI6mbE4lC0PG+bv2XCm8GhwPDkNjqaFY3SbzF1dQcKPxuB5hU0bPpPwXtEKw== X-Google-Smtp-Source: AGHT+IEp7gt4eg/hIkHha8avF/JsPNT+B63fADDfWgVXUjNs8T6/GmjFOIjyQSdTtOo1Kd0xwqYX X-Received: by 2002:a05:6512:3b0a:b0:52f:cf7e:b1bc with SMTP id 2adb3069b0e04-533097c6896mr167288e87.1.1723677379427; Wed, 14 Aug 2024 16:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1723677379; cv=none; d=google.com; s=arc-20160816; b=bMZG4tVFFicSgeKcItVsuDDJT4FU7oHuklWvea8xeCopmpc1qaI6MUWVDiWFcDjO8q zJxJOjksQft2TsHlf/GefJFwhCaYXlrn0j7qqKCmkNq5+32YvTQYUvTPZAcU3bLZhF5y FOtjiwZQ4WZ/15Cjo0FTJ6yVc7Ypfcjk6RMChTYX11Wjfj08/IPmfsMasN9f/ipiMI3z XHCMwXUDK1iyKqjY360Q55NweITiBRNjXEjUPsjx0hBhcvQKKuWMSTj6hAudvpw9HbP3 23+KudiYpMsE0Hta3MHyMwtR5XkwQkFSHA/nsahZC5w31MRtK0Q34lydq6pzajNeEwyh dqsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=qUr7o0hCpWMQcekEyhief9S7xAISij9NO1KYzYMHujs=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=bdErholYuScDZ30qOoyj5tREC35y9IBIQdov+opRoPQxJ5wgONVd+dQS1PYSwzbmLZ 6llicy2QAacWZfD0yDxWlkZyhoaGEyjQ5sA4yHoD5+1NxB6xT6JyurOsmMkrax24xc6w po7vRbPDxu4HbjDIUNKdeSD/ynHV91EbnwrnzKJTdRNxLW1JFN37zBocOD5X/pn8YfUR NXeM+6CdN+E3LzT/wEbj9Gkdljlrwhku6UVqtUC7ZFFxsWAtn5EFP7MUTujHMQhP+Rjq fYupbY48YJDxyco4L6jhLil0CyDLYQ1mN/oLFhfY8lkbNcjmVyf+lElZS/XarpUofqRU fuug==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=YYLyGn8x; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a8383971616si9199666b.883.2024.08.14.16.16.13; Wed, 14 Aug 2024 16:16:19 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b=YYLyGn8x; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6AD4E68DB5E; Thu, 15 Aug 2024 01:37:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 21B7E68D9D5 for ; Thu, 15 Aug 2024 01:37:20 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 77C74E0005 for ; Wed, 14 Aug 2024 22:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1723675039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tagf/zz/HjqndFEARa8LZtv35+p+7ERmnUrZAZ5svbI=; b=YYLyGn8xSHXjy0fYL/nPMxzSgo62QTFdkzV9ztT6/illE2hfTEfV+yhmOf2SSbMu93ia3y /kQagz15MdbzlEvZDg+Cl2s6ze0ZyfwgZ7gyaE9oK5+EHCp9aT8woeW7w+9MYhJObCHnS8 KzdaSBnY3+dkIYmCNXIZeXCQNr9uwDksKnHPuIjhzcnkZeN64gOVzD/LH2h4oE+/+jF7oM hqwGyCaIO1FpmxKT1+sqLF0v9OC8T/1Pku4DoV7acX8yoOiz7qPWPYL3HdMhjJ3kRJ9sT1 jGLmGpbZVUVTagYC8JpKbujsraGjYxhlYrEIjU2SO9GrtQDfKs64r9qD+A6qIw== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 15 Aug 2024 00:37:06 +0200 Message-ID: <20240814223714.2436993-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240814223714.2436993-1-michael@niedermayer.cc> References: <20240814223714.2436993-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 5/5] avcodec/msmpeg4dec: init dc_pred_dir X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: fkWiO/H2HgG2 Its not really used but its passed as a argument and then not used Fixes: 70965/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSMPEG4V1_fuzzer-5583223747313664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/msmpeg4dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/msmpeg4dec.c b/libavcodec/msmpeg4dec.c index 31b17c2839e..12bef4f5066 100644 --- a/libavcodec/msmpeg4dec.c +++ b/libavcodec/msmpeg4dec.c @@ -628,7 +628,7 @@ int ff_msmpeg4_decode_block(MpegEncContext * s, int16_t * block, int n, int coded, const uint8_t *scan_table) { int level, i, last, run, run_diff; - int av_uninit(dc_pred_dir); + int dc_pred_dir = -1; //unused but its passed around, so it needs to be initialized const RLTable *rl; const RL_VLC_ELEM *rl_vlc; int qmul, qadd;