diff mbox series

[FFmpeg-devel] avfilter/vf_quirc: add missing header to unbreak build

Message ID 20240819150356.739-1-ffmpeg@gyani.pro
State New
Headers show
Series [FFmpeg-devel] avfilter/vf_quirc: add missing header to unbreak build | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Gyan Doshi Aug. 19, 2024, 3:03 p.m. UTC 
filters.h has been needed since 42cbf66fff for FilterLink.
---
 libavfilter/vf_quirc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dennis Mungai Aug. 19, 2024, 3:14 p.m. UTC | #1 
On Mon, Aug 19, 2024, 18:04 Gyan Doshi <ffmpeg@gyani.pro> wrote:

> filters.h has been needed since 42cbf66fff for FilterLink.
> ---
>  libavfilter/vf_quirc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c
> index 760f5d97de..afd172fa34 100644
> --- a/libavfilter/vf_quirc.c
> +++ b/libavfilter/vf_quirc.c
> @@ -27,6 +27,7 @@
>  #include "libavutil/imgutils.h"
>  #include "libavutil/opt.h"
>  #include "avfilter.h"
> +#include "filters.h"
>  #include "formats.h"
>  #include "video.h"
>  #include <quirc.h>
> --
> 2.44.0
>
> "
>



Hmm, a candidate for back-porting to ffmpeg release/6x and 7x series.

>
James Almer Aug. 19, 2024, 5:05 p.m. UTC | #2 
On 8/19/2024 12:14 PM, Dennis Mungai wrote:
> On Mon, Aug 19, 2024, 18:04 Gyan Doshi <ffmpeg@gyani.pro> wrote:
> 
>> filters.h has been needed since 42cbf66fff for FilterLink.
>> ---
>>   libavfilter/vf_quirc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c
>> index 760f5d97de..afd172fa34 100644
>> --- a/libavfilter/vf_quirc.c
>> +++ b/libavfilter/vf_quirc.c
>> @@ -27,6 +27,7 @@
>>   #include "libavutil/imgutils.h"
>>   #include "libavutil/opt.h"
>>   #include "avfilter.h"
>> +#include "filters.h"
>>   #include "formats.h"
>>   #include "video.h"
>>   #include <quirc.h>
>> --
>> 2.44.0
>>
>> "
>>
> 
> 
> 
> Hmm, a candidate for back-porting to ffmpeg release/6x and 7x series.

I don't see why. The change that made this addition necessary is four 
days old.
Gyan Doshi Aug. 20, 2024, 7:24 a.m. UTC | #3 
Patch withdrawn, superfluous since 1afe42852b.

On 2024-08-19 08:33 pm, Gyan Doshi wrote:
> filters.h has been needed since 42cbf66fff for FilterLink.
> ---
>   libavfilter/vf_quirc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c
> index 760f5d97de..afd172fa34 100644
> --- a/libavfilter/vf_quirc.c
> +++ b/libavfilter/vf_quirc.c
> @@ -27,6 +27,7 @@
>   #include "libavutil/imgutils.h"
>   #include "libavutil/opt.h"
>   #include "avfilter.h"
> +#include "filters.h"
>   #include "formats.h"
>   #include "video.h"
>   #include <quirc.h>
diff mbox series

Patch

diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c
index 760f5d97de..afd172fa34 100644
--- a/libavfilter/vf_quirc.c
+++ b/libavfilter/vf_quirc.c
@@ -27,6 +27,7 @@ 
 #include "libavutil/imgutils.h"
 #include "libavutil/opt.h"
 #include "avfilter.h"
+#include "filters.h"
 #include "formats.h"
 #include "video.h"
 #include <quirc.h>