diff mbox series

[FFmpeg-devel,v3,2/3] suppress build warnings

Message ID 20240823172400.268575-2-rajivharlalka009@gmail.com
State New
Headers show
Series [FFmpeg-devel,v3,1/3] avfilter: add pu21 filter | expand

Checks

Context Check Description
andriy/commit_msg_x86 warning The first line of the commit message must start with a context terminated by a colon and a space, for example "lavu/opt: " or "doc: ".
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Rajiv Harlalka Aug. 23, 2024, 5:23 p.m. UTC 
Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
---
 libavfilter/vf_pu21.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Zhao Zhili Aug. 23, 2024, 5:38 p.m. UTC | #1 
Please squash these patches into a single one. We don’t use a incomplete patch and
then fix it with another one (of course unless the first one has already got merged).

> On Aug 24, 2024, at 01:23, Rajiv Harlalka <rajivharlalka009@gmail.com> wrote:
> 
> Signed-off-by: Rajiv Harlalka <rajivharlalka009@gmail.com>
> ---
> libavfilter/vf_pu21.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libavfilter/vf_pu21.c b/libavfilter/vf_pu21.c
> index c3b56f9c1b..e47ef065e8 100644
> --- a/libavfilter/vf_pu21.c
> +++ b/libavfilter/vf_pu21.c
> @@ -8,7 +8,7 @@
> #include "libavutil/internal.h"
> #include "video.h"
> 
> -static enum pu21_mode {
> +enum pu21_mode {
>   BANDING,
>   BANDING_GLARE,
>   PEAKS,
> @@ -165,9 +165,7 @@ static int filter_frame(AVFilterLink* inlink, AVFrame* input) {
>   return ff_filter_frame(outlink, out);
> }
> 
> -static av_cold void uninit(AVFilterContext* ctx) {
> -  PU21Context* s = ctx->priv;
> -}
> +static av_cold void uninit(AVFilterContext* ctx) {}
> 
> static int config_input(AVFilterLink* inlink) {
>   const AVPixFmtDescriptor* desc = av_pix_fmt_desc_get(inlink->format);
> -- 
> 2.25.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavfilter/vf_pu21.c b/libavfilter/vf_pu21.c
index c3b56f9c1b..e47ef065e8 100644
--- a/libavfilter/vf_pu21.c
+++ b/libavfilter/vf_pu21.c
@@ -8,7 +8,7 @@ 
 #include "libavutil/internal.h"
 #include "video.h"
 
-static enum pu21_mode {
+enum pu21_mode {
   BANDING,
   BANDING_GLARE,
   PEAKS,
@@ -165,9 +165,7 @@  static int filter_frame(AVFilterLink* inlink, AVFrame* input) {
   return ff_filter_frame(outlink, out);
 }
 
-static av_cold void uninit(AVFilterContext* ctx) {
-  PU21Context* s = ctx->priv;
-}
+static av_cold void uninit(AVFilterContext* ctx) {}
 
 static int config_input(AVFilterLink* inlink) {
   const AVPixFmtDescriptor* desc = av_pix_fmt_desc_get(inlink->format);