Message ID | 20240902143201.3661485-2-michael@niedermayer.cc |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel,1/2] MAINTAINERS: aacdec_usac seems not actively maintained | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
Hi Michael, I am new to community, and I am not sure about qualifications of maintainer but If you prefer I can be the maintainer. Best Regards, Yiğithan Yiğit > On 2 Sep 2024, at 16:39, Michael Niedermayer <michael@niedermayer.cc> wrote: > A ping from last month by Yigithan Yigit had no reaction > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d73536370a0..0b323962ed4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -324,6 +324,7 @@ Filters: > af_hdcd.c Burt P. > af_loudnorm.c Kyle Swanson > af_pan.c Nicolas George > + af_volumedetect.c [0] > avf_showcqt.c Muhammad Faiz > vf_bwdif Thomas Mundt (CC <thomas.mundt@hr.de>) > vf_chromakey.c Timo Rothenpieler > -- > 2.46.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Hi Yiğithan Yiğit On Mon, Sep 02, 2024 at 11:52:52PM +0200, Yigithan Yigit wrote: > Hi Michael, > > I am new to community, and I am not sure about qualifications of maintainer but If you prefer I can be the maintainer. some libavfilter filters may be difficult to maintain currently (thats because of pauls fork and paul working on libavfilter) So if you want to try, you can, but there likely will be problems that would not occur in other parts of teh codebase. if you want to try, some suggestions on what you could do * setup a clone of ffmpeg (on github or elsewhere) unless you already have one * set a branch up there with your changes, make sure requested modifications have been done * once you are happy with the code and everyone else had a chance to review it and noone had remaining complaints and the latest patches are on ffmpeg-devel with noone complaining, -> simply ask me to apply the patches, ill then wait another 24h and if noone complains apply them * if this works for a few iterations then you should send a patch that adds you to MAINTAINERS * Now the extra problem, if you want a challence. As Paul also works on it. As maintainer, you should look at pauls work and bring it to ffmpeg. This has several complexities beyond what you might expect. First obvious, the authorship of all commits needs to be correct Second, paul has changed the license in COPYING to GPLv2 but not in the file header of af_volumedetect.c So before any work from pauls fork can be included, this contradition needs to be understood / resolved. You could start a discussion about this here or with paul ... And obviously once this is clarified, any included code from paul must comply to the license. Which could also mean that no changes from him to af_volumedetect can be included. Thx [...]
On Wed, Sep 04, 2024 at 09:26:19PM +0200, Michael Niedermayer wrote: > Hi Yiğithan Yiğit > > On Mon, Sep 02, 2024 at 11:52:52PM +0200, Yigithan Yigit wrote: > > Hi Michael, > > > > I am new to community, and I am not sure about qualifications of maintainer but If you prefer I can be the maintainer. > > some libavfilter filters may be difficult to maintain currently > (thats because of pauls fork and paul working on libavfilter) > > So if you want to try, you can, but there likely will be > problems that would not occur in other parts of teh codebase. > > if you want to try, some suggestions on what you could do > * setup a clone of ffmpeg (on github or elsewhere) unless you already have one > * set a branch up there with your changes, make sure requested modifications have been done > * once you are happy with the code and everyone else had a chance to > review it and noone had remaining complaints and the latest patches are on ffmpeg-devel > with noone complaining, > -> simply ask me to apply the patches, ill then wait another 24h and if noone complains > apply them > * if this works for a few iterations then you should send a patch that adds you to > MAINTAINERS > * Now the extra problem, if you want a challence. As Paul also works on it. > As maintainer, you should look at pauls work and bring it to ffmpeg. > This has several complexities beyond what you might expect. > First obvious, the authorship of all commits needs to be correct > Second, paul has changed the license in COPYING to GPLv2 but not in the file it was LICENSE.md not COPYING [...]
diff --git a/MAINTAINERS b/MAINTAINERS index d73536370a0..0b323962ed4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -324,6 +324,7 @@ Filters: af_hdcd.c Burt P. af_loudnorm.c Kyle Swanson af_pan.c Nicolas George + af_volumedetect.c [0] avf_showcqt.c Muhammad Faiz vf_bwdif Thomas Mundt (CC <thomas.mundt@hr.de>) vf_chromakey.c Timo Rothenpieler
A ping from last month by Yigithan Yigit had no reaction Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)