Message ID | 20240908172725.459656-3-ms+git@mur.at |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel,1/3] libavcodec: implementation of DNxUncompressed decoder | expand |
Context | Check | Description |
---|---|---|
yinshiyou/configure_loongarch64 | warning | Failed to apply patch |
andriy/configure_x86 | warning | Failed to apply patch |
> On Sep 9, 2024, at 01:27, Martin Schitter <ms+git@mur.at> wrote: > > --- > libavcodec/dnxucdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/dnxucdec.c b/libavcodec/dnxucdec.c > index 502e736..e9a2157 100644 > --- a/libavcodec/dnxucdec.c > +++ b/libavcodec/dnxucdec.c > @@ -486,7 +486,7 @@ const AVCodecParser ff_dnxuc_parser = { > > const FFCodec ff_dnxuc_decoder = { > .p.name = "dnxuc", > - CODEC_LONG_NAME()"DNxUncompressed (SMPTE RDD 50)", > + CODEC_LONG_NAME("DNxUncompressed (SMPTE RDD 50)"), > .p.type = AVMEDIA_TYPE_VIDEO, > .p.id = AV_CODEC_ID_DNXUC, > .init = dnxuc_decode_init, > -- > 2.45.2 If there are defects in a patch, fix the patch instead of add a new commit. For example, use git commit —amend. If it’s a patch in a patchset, use git rebase —interactive. We don’t merge a patch if there is know issue, then fix it with another patch. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
On 08.09.24 19:52, Zhao Zhili wrote: > If there are defects in a patch, fix the patch instead of add a new commit. > For example, use git commit —amend. If it’s a patch in a patchset, use > git rebase —interactive. We don’t merge a patch if there is know issue, > then fix it with another patch. Thanks, that's really helpful advice! martin
diff --git a/libavcodec/dnxucdec.c b/libavcodec/dnxucdec.c index 502e736..e9a2157 100644 --- a/libavcodec/dnxucdec.c +++ b/libavcodec/dnxucdec.c @@ -486,7 +486,7 @@ const AVCodecParser ff_dnxuc_parser = { const FFCodec ff_dnxuc_decoder = { .p.name = "dnxuc", - CODEC_LONG_NAME()"DNxUncompressed (SMPTE RDD 50)", + CODEC_LONG_NAME("DNxUncompressed (SMPTE RDD 50)"), .p.type = AVMEDIA_TYPE_VIDEO, .p.id = AV_CODEC_ID_DNXUC, .init = dnxuc_decode_init,