diff mbox series

[FFmpeg-devel] lavc/vaapi_encode_av1: Fix encode fail since 9db68ed0

Message ID 20240913031551.1246087-1-fei.w.wang@intel.com
State New
Headers show
Series [FFmpeg-devel] lavc/vaapi_encode_av1: Fix encode fail since 9db68ed0 | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Wang, Fei W Sept. 13, 2024, 3:15 a.m. UTC 
From: Fei Wang <fei.w.wang@intel.com>

Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
 libavcodec/vaapi_encode_av1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lynne Sept. 13, 2024, 8:45 a.m. UTC | #1 
On 13/09/2024 05:15, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> From: Fei Wang <fei.w.wang@intel.com>
> 
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
>   libavcodec/vaapi_encode_av1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c
> index 6d1be9fc07..1b350cd936 100644
> --- a/libavcodec/vaapi_encode_av1.c
> +++ b/libavcodec/vaapi_encode_av1.c
> @@ -637,7 +637,7 @@ static int vaapi_encode_av1_init_picture_params(AVCodecContext *avctx,
>               slot = ((VAAPIEncodeAV1Picture*)ref_pic->codec_priv)->slot;
>               av_assert0(vpic->reference_frames[slot] == VA_INVALID_SURFACE);
>   
> -            vpic->reference_frames[slot] = ((VAAPIEncodePicture *)ref_pic)->recon_surface;
> +            vpic->reference_frames[slot] = ((VAAPIEncodePicture *)ref_pic->priv)->recon_surface;
>           }
>       }
>   

LGTM
thanks
Xiang, Haihao Sept. 18, 2024, 7:31 a.m. UTC | #2 
On Vr, 2024-09-13 at 10:45 +0200, Lynne via ffmpeg-devel wrote:
> On 13/09/2024 05:15, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> > From: Fei Wang <fei.w.wang@intel.com>
> > 
> > Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> > ---
> >   libavcodec/vaapi_encode_av1.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c
> > index 6d1be9fc07..1b350cd936 100644
> > --- a/libavcodec/vaapi_encode_av1.c
> > +++ b/libavcodec/vaapi_encode_av1.c
> > @@ -637,7 +637,7 @@ static int
> > vaapi_encode_av1_init_picture_params(AVCodecContext *avctx,
> >               slot = ((VAAPIEncodeAV1Picture*)ref_pic->codec_priv)->slot;
> >               av_assert0(vpic->reference_frames[slot] ==
> > VA_INVALID_SURFACE);
> >   
> > -            vpic->reference_frames[slot] = ((VAAPIEncodePicture *)ref_pic)-
> > >recon_surface;
> > +            vpic->reference_frames[slot] = ((VAAPIEncodePicture *)ref_pic-
> > >priv)->recon_surface;
> >           }
> >       }
> >   
> 
> LGTM
> thanks

Will apply,

Thanks
Haihao
diff mbox series

Patch

diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c
index 6d1be9fc07..1b350cd936 100644
--- a/libavcodec/vaapi_encode_av1.c
+++ b/libavcodec/vaapi_encode_av1.c
@@ -637,7 +637,7 @@  static int vaapi_encode_av1_init_picture_params(AVCodecContext *avctx,
             slot = ((VAAPIEncodeAV1Picture*)ref_pic->codec_priv)->slot;
             av_assert0(vpic->reference_frames[slot] == VA_INVALID_SURFACE);
 
-            vpic->reference_frames[slot] = ((VAAPIEncodePicture *)ref_pic)->recon_surface;
+            vpic->reference_frames[slot] = ((VAAPIEncodePicture *)ref_pic->priv)->recon_surface;
         }
     }