diff mbox series

[FFmpeg-devel,21/23] tests/fate/hevc: add a test for nontrivial values of nuh_layer_id

Message ID 20240914111036.17164-22-anton@khirnov.net
State New
Headers show
Series [FFmpeg-devel,01/23] compat: drop gcc, suncc, and pthreads stdatomic emulation | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Anton Khirnov Sept. 14, 2024, 10:45 a.m. UTC 
Typical files use 0 for the base layer and 1 for the secondary one, but
any value for the secondary layer should be supported.
---
 tests/fate/hevc.mak                 |  4 ++++
 tests/ref/fate/hevc-mv-nuh-layer-id | 15 +++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 tests/ref/fate/hevc-mv-nuh-layer-id

Comments

James Almer Sept. 15, 2024, 9:56 p.m. UTC | #1 
On 9/14/2024 7:45 AM, Anton Khirnov wrote:
> Typical files use 0 for the base layer and 1 for the secondary one, but
> any value for the secondary layer should be supported.
> ---
>   tests/fate/hevc.mak                 |  4 ++++
>   tests/ref/fate/hevc-mv-nuh-layer-id | 15 +++++++++++++++
>   2 files changed, 19 insertions(+)
>   create mode 100644 tests/ref/fate/hevc-mv-nuh-layer-id
> 
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index eb9d3a875c..df827d821f 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -272,6 +272,10 @@ FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_PARSER SCALE_FILTER) += fate-hevc-sm
>   fate-hevc-pir: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/pir.hevc
>   FATE_HEVC-$(call FRAMECRC, HEVC, HEVC) += fate-hevc-pir
>   
> +# multiview stream, where the secondary layer has a nontrivial nuh_layer_id=6
> +fate-hevc-mv-nuh-layer-id: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/mv_nuh_layer_id.bit -map 0:view:all

Can you put this sample somewhere?

> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC) += fate-hevc-mv-nuh-layer-id
> +
>   FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>   FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>   
> diff --git a/tests/ref/fate/hevc-mv-nuh-layer-id b/tests/ref/fate/hevc-mv-nuh-layer-id
> new file mode 100644
> index 0000000000..3cbefe17f6
> --- /dev/null
> +++ b/tests/ref/fate/hevc-mv-nuh-layer-id
> @@ -0,0 +1,15 @@
> +#tb 0: 1/25
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 128x128
> +#sar 0: 0/1
> +0,          0,          0,        1,    24576, 0xdfd350a6
> +0,          1,          1,        1,    24576, 0xf8f638da
> +0,          2,          2,        1,    24576, 0x8ac574d5
> +0,          3,          3,        1,    24576, 0xd22675a4
> +0,          4,          4,        1,    24576, 0xdd0f4704
> +0,          5,          5,        1,    24576, 0x60da42e6
> +0,          6,          6,        1,    24576, 0x8bf28fdd
> +0,          7,          7,        1,    24576, 0xe0577f6e
> +0,          8,          8,        1,    24576, 0x8b3e3c29
> +0,          9,          9,        1,    24576, 0x8d9944bd
Anton Khirnov Sept. 16, 2024, 9:43 a.m. UTC | #2 
Quoting James Almer (2024-09-15 23:56:13)
> On 9/14/2024 7:45 AM, Anton Khirnov wrote:
> > Typical files use 0 for the base layer and 1 for the secondary one, but
> > any value for the secondary layer should be supported.
> > ---
> >   tests/fate/hevc.mak                 |  4 ++++
> >   tests/ref/fate/hevc-mv-nuh-layer-id | 15 +++++++++++++++
> >   2 files changed, 19 insertions(+)
> >   create mode 100644 tests/ref/fate/hevc-mv-nuh-layer-id
> > 
> > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> > index eb9d3a875c..df827d821f 100644
> > --- a/tests/fate/hevc.mak
> > +++ b/tests/fate/hevc.mak
> > @@ -272,6 +272,10 @@ FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_PARSER SCALE_FILTER) += fate-hevc-sm
> >   fate-hevc-pir: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/pir.hevc
> >   FATE_HEVC-$(call FRAMECRC, HEVC, HEVC) += fate-hevc-pir
> >   
> > +# multiview stream, where the secondary layer has a nontrivial nuh_layer_id=6
> > +fate-hevc-mv-nuh-layer-id: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/mv_nuh_layer_id.bit -map 0:view:all
> 
> Can you put this sample somewhere?

Sure,
https://ups.khirnov.net/4f77224ddfc0e702f7d6947718d0467d5aeab846befbbb971063192b5a264409/mv_nuh_layer_id.bit

Thanks,
diff mbox series

Patch

diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
index eb9d3a875c..df827d821f 100644
--- a/tests/fate/hevc.mak
+++ b/tests/fate/hevc.mak
@@ -272,6 +272,10 @@  FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_PARSER SCALE_FILTER) += fate-hevc-sm
 fate-hevc-pir: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/pir.hevc
 FATE_HEVC-$(call FRAMECRC, HEVC, HEVC) += fate-hevc-pir
 
+# multiview stream, where the secondary layer has a nontrivial nuh_layer_id=6
+fate-hevc-mv-nuh-layer-id: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/mv_nuh_layer_id.bit -map 0:view:all
+FATE_HEVC-$(call FRAMECRC, HEVC, HEVC) += fate-hevc-mv-nuh-layer-id
+
 FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
 FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
 
diff --git a/tests/ref/fate/hevc-mv-nuh-layer-id b/tests/ref/fate/hevc-mv-nuh-layer-id
new file mode 100644
index 0000000000..3cbefe17f6
--- /dev/null
+++ b/tests/ref/fate/hevc-mv-nuh-layer-id
@@ -0,0 +1,15 @@ 
+#tb 0: 1/25
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 128x128
+#sar 0: 0/1
+0,          0,          0,        1,    24576, 0xdfd350a6
+0,          1,          1,        1,    24576, 0xf8f638da
+0,          2,          2,        1,    24576, 0x8ac574d5
+0,          3,          3,        1,    24576, 0xd22675a4
+0,          4,          4,        1,    24576, 0xdd0f4704
+0,          5,          5,        1,    24576, 0x60da42e6
+0,          6,          6,        1,    24576, 0x8bf28fdd
+0,          7,          7,        1,    24576, 0xe0577f6e
+0,          8,          8,        1,    24576, 0x8b3e3c29
+0,          9,          9,        1,    24576, 0x8d9944bd