| Message ID | 20240920102718.2005536-2-ms+git@mur.at |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] doc: Add email URLs for Fate samples-request | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Fri, Sep 20, 2024 at 12:27:19PM +0200, Martin Schitter wrote: > v2 adds the <samples-request@ffmpeg.org> address as a second (L: ...)-entry > to the Fate info in MAINTAINERS. > > I'm not sure if this is correct because I couldn't find other lines, > where the same kind of entry gets used twice. > > Btw.: the fate info and the "webserver"-entry one line above use > (S:...)-entries, which aren't mentioned as a possible variant in the > descriptive top section of MAINTAINERS. Shouldn't these be (T:...)- > or (W: ...)-entries or the (S: ...) kind be added as another option > to the describtion? they should be T: feel free to send a patch fixing that, or ill fix it later > > martin > > --- > MAINTAINERS | 2 +- > doc/developer.texi | 2 +- > doc/fate.texi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 036066d..7d7ef36 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -62,7 +62,7 @@ Communication > ============= > > website (S: https://git.ffmpeg.org/ffmpeg-web) Deby Barbara Lepage > -fate.ffmpeg.org (L: fate-admin@ffmpeg.org) (W: https://fate.ffmpeg.org) (P: https://ffmpeg.org/fate.html) (S: https://git.ffmpeg.org/fateserver) Timo Rothenpieler > +fate.ffmpeg.org (L: fate-admin@ffmpeg.org) (L: samples-request@ffmpeg.org) (W: https://fate.ffmpeg.org) (P: https://ffmpeg.org/fate.html) (S: https://git.ffmpeg.org/fateserver) Timo Rothenpieler I think this should possible use more than 1 line also as there are 2 "L:" there should be a note when to use which thx [...]
On 24.09.24 00:31, Michael Niedermayer wrote: >> Btw.: the fate info and the "webserver"-entry one line above use >> (S:...)-entries, which aren't mentioned as a possible variant in the >> descriptive top section of MAINTAINERS. Shouldn't these be (T:...)- >> or (W: ...)-entries or the (S: ...) kind be added as another option >> to the describtion? > > they should be T: > feel free to send a patch fixing that, or ill fix it later Done >> -fate.ffmpeg.org (L: fate-admin@ffmpeg.org) (W: https://fate.ffmpeg.org) (P: https://ffmpeg.org/fate.html) (S: https://git.ffmpeg.org/fateserver) Timo Rothenpieler >> +fate.ffmpeg.org (L: fate-admin@ffmpeg.org) (L: samples-request@ffmpeg.org) (W: https://fate.ffmpeg.org) (P: https://ffmpeg.org/fate.html) (S: https://git.ffmpeg.org/fateserver) Timo Rothenpieler > > I think this should possible use more than 1 line > also as there are 2 "L:" there should be a note when to use which I hope, that's better now. Fixed line breaks would make the first few sections with all long list of names in general much more readable. Martin
On 24.09.24 01:48, martin schitter wrote: >> they should be T: >> feel free to send a patch fixing that, or ill fix it later Although you fixed one occurrence of this issue by f2aba7 it's still present on the next line. My patch would have fixed both of them. ;) Martin
On Tue, Sep 24, 2024 at 08:30:07PM +0200, martin schitter wrote: > > > On 24.09.24 01:48, martin schitter wrote: > > > they should be T: > > > feel free to send a patch fixing that, or ill fix it later > > Although you fixed one occurrence of this issue by f2aba7 it's still present > on the next line. > > My patch would have fixed both of them. ;) I didnt apply it because it contained unrelated changes, i thought i would help if i fix that seperate issue so only realted remain ... thx [...]
diff --git a/MAINTAINERS b/MAINTAINERS index 036066d..7d7ef36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -62,7 +62,7 @@ Communication ============= website (S: https://git.ffmpeg.org/ffmpeg-web) Deby Barbara Lepage -fate.ffmpeg.org (L: fate-admin@ffmpeg.org) (W: https://fate.ffmpeg.org) (P: https://ffmpeg.org/fate.html) (S: https://git.ffmpeg.org/fateserver) Timo Rothenpieler +fate.ffmpeg.org (L: fate-admin@ffmpeg.org) (L: samples-request@ffmpeg.org) (W: https://fate.ffmpeg.org) (P: https://ffmpeg.org/fate.html) (S: https://git.ffmpeg.org/fateserver) Timo Rothenpieler Trac bug tracker (W: https://trac.ffmpeg.org) Alexander Strasser, Michael Niedermayer, Carl Eugen Hoyos Patchwork [2] (W: https://patchwork.ffmpeg.org) Andriy Gelman mailing lists (W: https://ffmpeg.org/contact.html#MailingLists) Baptiste Coudurier diff --git a/doc/developer.texi b/doc/developer.texi index 41b2193..b732560 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -876,7 +876,7 @@ accordingly]. @section Adding files to the fate-suite dataset -If you need a sample uploaded send a mail to samples-request. +If you need a sample uploaded send a mail to @email{samples-request@@ffmpeg.org}. When there is no muxer or encoder available to generate test media for a specific test then the media has to be included in the fate-suite. diff --git a/doc/fate.texi b/doc/fate.texi index 17644ce..6f6df3a 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -172,7 +172,7 @@ the synchronisation of the samples directory. @chapter Uploading new samples to the fate suite -If you need a sample uploaded send a mail to samples-request. +If you need a sample uploaded send a mail to @email{samples-request@@ffmpeg.org}. This is for developers who have an account on the fate suite server. If you upload new samples, please make sure they are as small as possible,