From patchwork Mon Sep 23 21:32:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 51778 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:ad12:0:b0:48e:c0f8:d0de with SMTP id w18csp22554vqy; Mon, 23 Sep 2024 16:29:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVLdC2/ZmvfUXo0bDdc+3jePu3y7U5aVpN0aL+CutzR8JeCkhf/KUtA2Zw12W1g4MOTqiv44/S22ZPDA8VUDiSM@gmail.com X-Google-Smtp-Source: AGHT+IHgEesrmw0Kprffm9/JnT4pwnJSIQ5Cv8NCDkh1St2KzRlOJ6XN5JkL+Pu89QhC7QbOBPRC X-Received: by 2002:a05:6512:3d94:b0:52c:76ac:329b with SMTP id 2adb3069b0e04-536ac2f5febmr9175210e87.35.1727134159864; Mon, 23 Sep 2024 16:29:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727134159; cv=none; d=google.com; s=arc-20240605; b=PlHtuOEbz/XVWN7EidsWDqQsKaDUhhXnhwbfXopWOEBh7SPleC9XtbeOqQ557KCHuo LslgSIxKl4JXUnemLHHrYtC7knNwUFvDLY5CvtBLK4fV23xv2AOuCXfTAJDw+KrOf0f+ uMP3CCjADoZf85uQM5sCq0SWgjTv2M12S3PQdyHeXInDZCZfwfslvnBqrc5CWk9hiiZp 7xQ5s/bwnj4ghwrl457pBqPb+eTHkpTE8dyjqnZ9jwa/FkXxmunhUGk4zHLorUBXp3QY nIDVeFbWYM79HqyVwQA5RfP5l0KBONiCykfMyO+H27b7mkg2DAywranIVAILgRN+yZfa Ealw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=cQ9mdL5yt5u7030cRSRN3ieeZp0Ar4CxlyBdNe8LUZU=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=j8x5xkD19e+7T+PIhMmG6oquDFunMo7RtUUAlwVD2obafCT94wDKNuWdwckMJGDHZL IPXLzXIU0PaiipTMnN9WK/K8ikG5j+bM4osL2Dh0Cp88y7sB3p66UFgCDjBezG6E8NqT eKqp+FHTsQ2hqik7H2FxDwSoRutMlJty9W3m6A9Qsl3/GxdhUvAkIwNoCsPqi842xIRF k+1lK8dG6nNRLlWrcZClZPUQx3V1QFlfB77G3P4V8pzNG6D3Cs7WmKCOz/encDhMEUkn pRN85/D0mAjnNLRlkriTuWh8xivSmOkClWNJCm+PV3HjJxPedLSwbNZKcTTTs6lSliWK W/tA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="fgH/j+/K"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a9392f2b1b6si13379566b.101.2024.09.23.16.29.19; Mon, 23 Sep 2024 16:29:19 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@niedermayer.cc header.s=gm1 header.b="fgH/j+/K"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F169468DB83; Tue, 24 Sep 2024 00:33:07 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9B65A68DAE2 for ; Tue, 24 Sep 2024 00:32:57 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id F035A1C0004 for ; Mon, 23 Sep 2024 21:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1727127177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EI0mfQlRmWnxBxRdBOdfJliN1aCTNC8r/hcjbIm+n9k=; b=fgH/j+/Kz1VgxoTL13HMO4yCnhfkXuhg51UyElPZ9LyanyuqJTcHvv6+w0ZxXdHt9/HbxP 7CPN2AGYFFdAfYhD5rFRdalIWKkStGMKPX9sh36pvlP/zFb5LbKR6x4QxuHw9tc/xdk7n9 YFVvKvX12XbSwmsYXjdZ1N82kCIJbNzrBde7QH2xXNpdaiqRwW+0ujrLUZIYKVcZNIEVF6 6WBUiLQ2nBB4OsUzbGdc5a1v3Sfae8tVWG1hoZxDCp8UFcUC311NmYI/bg2rNxZ9l+mfcI kGb3D43aT/vDjz6xfdJXSQV5DOCTMMRfOIMCjItYXOjRn38lyQO8/3fv0d9KPQ== From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 23 Sep 2024 23:32:49 +0200 Message-ID: <20240923213249.3256534-7-michael@niedermayer.cc> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20240923213249.3256534-1-michael@niedermayer.cc> References: <20240923213249.3256534-1-michael@niedermayer.cc> MIME-Version: 1.0 X-GND-Sasl: michael@niedermayer.cc Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/hevc/hevcdec: initialize qp_y_tab X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nBPdRYQMUIKF This does not replicate on my setup, thus this is a blind fix based on ossfuzz trace Fixes: use of uninitialized value Fixes: 71747/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5427736120721408 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index d915d74d22e..0b50bbd2754 100644 --- a/libavcodec/hevc/hevcdec.c +++ b/libavcodec/hevc/hevcdec.c @@ -127,7 +127,7 @@ static int pic_arrays_init(HEVCLayerContext *l, const HEVCSPS *sps) l->filter_slice_edges = av_mallocz(ctb_count); l->tab_slice_address = av_malloc_array(pic_size_in_ctb, sizeof(*l->tab_slice_address)); - l->qp_y_tab = av_malloc_array(pic_size_in_ctb, + l->qp_y_tab = av_calloc(pic_size_in_ctb, sizeof(*l->qp_y_tab)); if (!l->qp_y_tab || !l->filter_slice_edges || !l->tab_slice_address) goto fail;