diff mbox series

[FFmpeg-devel] tests/fate/filter-video: don't convert owdenoise test to mpeg range

Message ID 20240929153855.14603-1-ramiro.polla@gmail.com
State New
Headers show
Series [FFmpeg-devel] tests/fate/filter-video: don't convert owdenoise test to mpeg range | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Ramiro Polla Sept. 29, 2024, 3:38 p.m. UTC 
---
The new owdenoise-scenwin-jpeg.raw reference file is available at https://0x0.st/XguT.raw

 tests/fate/filter-video.mak | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Anton Khirnov Sept. 30, 2024, 7:18 a.m. UTC | #1 
Quoting Ramiro Polla (2024-09-29 17:38:55)
> ---
> The new owdenoise-scenwin-jpeg.raw reference file is available at https://0x0.st/XguT.raw

Changing an existing reference file would break fate for older versions
(e.g. releases, or for bisecting).
Ramiro Polla Sept. 30, 2024, 8:46 a.m. UTC | #2 
Hi Anton,

On Mon, Sep 30, 2024 at 9:19 AM Anton Khirnov <anton@khirnov.net> wrote:
> Quoting Ramiro Polla (2024-09-29 17:38:55)
> > ---
> > The new owdenoise-scenwin-jpeg.raw reference file is available at https://0x0.st/XguT.raw
>
> Changing an existing reference file would break fate for older versions
> (e.g. releases, or for bisecting).

Martin pointed that out as well. With this patch, a new reference file
for jpeg range is added, leaving the original reference file
untouched.

Ramiro
Anton Khirnov Sept. 30, 2024, 8:59 a.m. UTC | #3 
Quoting Ramiro Polla (2024-09-30 10:46:54)
> Hi Anton,
> 
> On Mon, Sep 30, 2024 at 9:19 AM Anton Khirnov <anton@khirnov.net> wrote:
> > Quoting Ramiro Polla (2024-09-29 17:38:55)
> > > ---
> > > The new owdenoise-scenwin-jpeg.raw reference file is available at https://0x0.st/XguT.raw
> >
> > Changing an existing reference file would break fate for older versions
> > (e.g. releases, or for bisecting).
> 
> Martin pointed that out as well. With this patch, a new reference file
> for jpeg range is added, leaving the original reference file
> untouched.

Oh, I didn't notice you're changing the filename as well. Disregard my
email then.
diff mbox series

Patch

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 5b8a294afd..0f351ea404 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -2,8 +2,8 @@ 
 VIDEO_FILTER = $(call ALLYES, $(1:%=%_FILTER) $(2) FILE_PROTOCOL IMAGE2_DEMUXER PGMYUV_DECODER RAWVIDEO_ENCODER NUT_MUXER MD5_PROTOCOL)
 
 FATE_FILTER_SAMPLES-$(call FILTERDEMDECENCMUX, PERMS OWDENOISE TRIM SCALE, SMJPEG, MJPEG, RAWVIDEO, RAWVIDEO, PIPE_PROTOCOL) += fate-filter-owdenoise-sample
-fate-filter-owdenoise-sample: CMD = ffmpeg -auto_conversion_filters -idct simple -i $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=0.5,perms=random,owdenoise=10:20:20:enable=not(between(t\,0.2\,1.2))" -an -f rawvideo -color_range mpeg -
-fate-filter-owdenoise-sample: REF = $(SAMPLES)/filter-reference/owdenoise-scenwin.raw
+fate-filter-owdenoise-sample: CMD = ffmpeg -auto_conversion_filters -idct simple -i $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=0.5,perms=random,owdenoise=10:20:20:enable=not(between(t\,0.2\,1.2))" -an -f rawvideo -
+fate-filter-owdenoise-sample: REF = $(SAMPLES)/filter-reference/owdenoise-scenwin-jpeg.raw
 fate-filter-owdenoise-sample: CMP_TARGET = 1
 fate-filter-owdenoise-sample: FUZZ = 3539
 fate-filter-owdenoise-sample: CMP = oneoff