diff mbox series

[FFmpeg-devel,v3] avformat/hlsenc: Respect `omit_endlist` flag in subtitle playlists

Message ID 20240930172749.16364-1-jonbae77@gmail.com
State New
Headers show
Series [FFmpeg-devel,v3] avformat/hlsenc: Respect `omit_endlist` flag in subtitle playlists | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Jonathan Baecker Sept. 30, 2024, 5:27 p.m. UTC 
This modification applies Steven's suggestion.

Original description was:
Ensure that when the `-hls_flags omit_endlist` option is set,
the `#EXT-X-ENDLIST` tag is also omitted from the `stream_vtt.m3u8`
subtitle playlist. This maintains consistency with the behavior
in other playlists when `omit_endlist` is specified.
---
 libavformat/hlsenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.46.2

Comments

Steven Liu Oct. 4, 2024, 10:06 a.m. UTC | #1 
Jonathan Baecker <jonbae77@gmail.com> 于2024年10月1日周二 07:56写道：
>
> This modification applies Steven's suggestion.
>
> Original description was:
> Ensure that when the `-hls_flags omit_endlist` option is set,
> the `#EXT-X-ENDLIST` tag is also omitted from the `stream_vtt.m3u8`
> subtitle playlist. This maintains consistency with the behavior
> in other playlists when `omit_endlist` is specified.
> ---
>  libavformat/hlsenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 571d6b2752..c258fc812d 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -1676,7 +1676,7 @@ static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
>              }
>          }
>
> -        if (last)
> +        if (last && !(hls->flags & HLS_OMIT_ENDLIST))
>              ff_hls_write_end_list(hls->sub_m3u8_out);
>
>      }
> --
> 2.46.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".


lgtm

Thanks
Steven
diff mbox series

Patch

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 571d6b2752..c258fc812d 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -1676,7 +1676,7 @@  static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
             }
         }

-        if (last)
+        if (last && !(hls->flags & HLS_OMIT_ENDLIST))
             ff_hls_write_end_list(hls->sub_m3u8_out);

     }