From patchwork Thu Oct 3 19:31:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 52008 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:b18c:0:b0:48e:c0f8:d0de with SMTP id q12csp584511vqn; Thu, 3 Oct 2024 12:33:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV02zIu9eatCCAJ+p+yQKEV7yTse5N/p6WT3rWgHFu2KWvAG322Lfq6UPbbWK6akvEfvy8t6znPP9hgdfw73c5W@gmail.com X-Google-Smtp-Source: AGHT+IHhretjAFJBT6tepB77O2rfFCn98iCXGw413FzNfUnzRccLS7v4QA3pqgNNHg2xv06A81WZ X-Received: by 2002:a17:907:d2d5:b0:a80:f358:5d55 with SMTP id a640c23a62f3a-a991bd45c2emr37582966b.33.1727983990035; Thu, 03 Oct 2024 12:33:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727983990; cv=none; d=google.com; s=arc-20240605; b=ixTNrdi8S8j/jCHfYoXWCuMMznGx9AknE4yhZTevhRERvDsIuBn2tr3YSd/PnmyoBa BFbh1/kTw+oEEegY0h1HtupTUrVcSxMpkB1zFFgVm49VrFe0guXJeDeLP16Jgu96TTYQ UOgNt3VSLxSMGXUnysq2FlwYkDd+w0jWwsA7daSEucPz3zTrj8Ds8jBUcK0ZyetkmzhC +2HniBoelMzoQp2I6zcPJ1Cp7CkGpKqaX8SKMQpWm3MUsydVbeSYSJQP1e6432aOTkvV Slk5wWceeKr5OUoAFoufj1fKTpCl+sG2XX2GPEWuOYrBP/1IJD+KTTYrNHta2/z4gMvw wmOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:dkim-signature:delivered-to; bh=wyTICMj9ialTpJ8suQVeDRZt7C8FpzxHT69v9oCzsb0=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=Bl1Q1DRmtyLLHGpXo0ggEDyZe/G5cisLw58nS+/BxHOTUFIwNww+FgozrWY20xtWyN ILVWQjJ/qX0ZnjrlZGYmyOmvQnOxyaxKXuCtYQd+YdBfIQ2GHc4zyxp+buE0ey3UTtf5 X8cBE0tAcyNa1Z32vfOB6zvYvb+811xhtKVnHdEDvQ73HURIF6NrAi/GUGpoMJKf9K3D 3ilbiIgvjWCEeCJLc7k6gCqs418KrNeX1Jj5MvGqmmreTZmp5WAqSFqAow+4Ugy7l/5M 1S4wqx0QtS17vWuxiHP37GlFoaNc1PGRmKjY32KN8KpmHkAFEH6+XqtUgR/YJxR6q/sg 2tIw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@khirnov.net header.s=mail header.b=T5a0cUk8; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a9910dcf00fsi111328366b.101.2024.10.03.12.33.08; Thu, 03 Oct 2024 12:33:10 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@khirnov.net header.s=mail header.b=T5a0cUk8; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 05C8968DAE4; Thu, 3 Oct 2024 22:32:35 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail1.khirnov.net (quelana.khirnov.net [94.230.150.81]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 456D068DA4D for ; Thu, 3 Oct 2024 22:32:24 +0300 (EEST) Authentication-Results: mail1.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=T5a0cUk8; dkim-atps=neutral Received: from localhost (mail1.khirnov.net [IPv6:::1]) by mail1.khirnov.net (Postfix) with ESMTP id 54D0B4E19 for ; Thu, 3 Oct 2024 21:32:23 +0200 (CEST) Received: from mail1.khirnov.net ([IPv6:::1]) by localhost (mail1.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 8Yf7s-d-CLDb for ; Thu, 3 Oct 2024 21:32:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1727983942; bh=kWoqzb00vkMsjG4XHVvwUoBFdQ3O8Ds87N8CxrmRndk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=T5a0cUk8/jFzV135ENgPGOLSGFcrQ2Q5+L7FsmlofKt8rvov75dcOgJE9MERRlmwu xazMR3fKqXhmXTTMiwXfb1et0/bBb2dBjJrkQHDGTcZrR1m3axpayFsl0j9NKC8EQC /wZr1XzdCz0pTO3p1rIcvHR2HJcfQHfgKTysOx/ukNcPPGJ2dPb5qZKB2s4qQGNtsh HyGyYA09xZbleKaykdcCqzPf2pmajCM24UHA6y/KFBAH5D4IY3xmVG5wYulASnWwp/ w2KWmZCI0Fk9WTwTv1Rtrj+rvrSajnEXKBEovQikQD7Cf3wbl6yTZGp4SRSo8vt5j6 HQbtGOJu1JE5A== Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail1.khirnov.net (Postfix) with ESMTPS id 0CA474E11 for ; Thu, 3 Oct 2024 21:32:22 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id C1E473A1A1B for ; Thu, 03 Oct 2024 21:32:15 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Thu, 3 Oct 2024 21:31:24 +0200 Message-ID: <20241003193127.15818-4-anton@khirnov.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241003193127.15818-1-anton@khirnov.net> References: <20241003193127.15818-1-anton@khirnov.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/7] lavfi/avfilter: document AVFilterContext.is_disabled as private X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 9Elnz++6cK5Z Ideally there should be three parts to the filter context - public, private to the filter, and private to generic code, but only the first and the last of these exist currently. Until the second is implemented, this is better than nothing. --- libavfilter/avfilter.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index a255d71700..d13a2df732 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter.h @@ -512,7 +512,12 @@ struct AVFilterContext { ///< @deprecated unused double *var_values; #endif - int is_disabled; ///< the enabled state from the last expression evaluation + /** + * MUST NOT be accessed from outside avfilter. + * + * the enabled state from the last expression evaluation + */ + int is_disabled; /** * For filters which will create hardware frames, sets the device the