Message ID | 20241007071541.1264660-1-dev@lynne.ee |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel] configure: add spirv_compiler to avfilter_suggest as well | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
On Mon, Oct 7, 2024 at 9:15 AM Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: > > If someone were to enable libglslang/libshaderc, and then disable > all Vulkan filters, they would have the same issue as the earlier > fix for libavcodec. If you run such a setup, shouldn't the code that uses this then be excluded? - Hendrik
On 07/10/2024 09:28, Hendrik Leppkes wrote: > On Mon, Oct 7, 2024 at 9:15 AM Lynne via ffmpeg-devel > <ffmpeg-devel@ffmpeg.org> wrote: >> >> If someone were to enable libglslang/libshaderc, and then disable >> all Vulkan filters, they would have the same issue as the earlier >> fix for libavcodec. > > If you run such a setup, shouldn't the code that uses this then be excluded? No, the files are always compiled if the user enabled support. > OBJS-$(CONFIG_LIBGLSLANG) += vulkan_glslang.o > OBJS-$(CONFIG_LIBSHADERC) += vulkan_shaderc.o We do the same for qsv. If we only supported a single SPIRV compiler, we could have instead added the file to every filter, but unfortunately, both libraries are used more or less equally by distributions and users.
diff --git a/configure b/configure index 1006ac98e2..461586cdb8 100755 --- a/configure +++ b/configure @@ -4043,7 +4043,7 @@ avcodec_suggest="libm stdatomic spirv_compiler" avdevice_deps="avformat avcodec avutil" avdevice_suggest="libm stdatomic" avfilter_deps="avutil" -avfilter_suggest="libm stdatomic" +avfilter_suggest="libm stdatomic spirv_compiler" avformat_deps="avcodec avutil" avformat_suggest="libm network zlib stdatomic" avutil_suggest="clock_gettime ffnvcodec gcrypt libm libdrm libmfx opencl openssl user32 vaapi vulkan videotoolbox corefoundation corevideo coremedia bcrypt stdatomic"