From patchwork Mon Oct 7 09:52:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lynne X-Patchwork-Id: 52085 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:938f:0:b0:48e:c0f8:d0de with SMTP id z15csp1804724vqg; Mon, 7 Oct 2024 02:52:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUK6GndfmlLWywxZzUaPEHXne6iuQTJvCqO/PaFde69zt3E8seP7B3IU+sWfqt7zzo55DUbwGhWUPqkV0tNdpB5@gmail.com X-Google-Smtp-Source: AGHT+IHRGgd8hyDSzk1+wpkdifKOmK2yFpb8pGqcalvnj+KtOlJyQx92G5OrWqWFdcZQg3CPdUqe X-Received: by 2002:a05:6402:2553:b0:5c8:7a90:6a71 with SMTP id 4fb4d7f45d1cf-5c8d2e1225dmr10232419a12.13.1728294777391; Mon, 07 Oct 2024 02:52:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728294777; cv=none; d=google.com; s=arc-20240605; b=NiKUnJIbj5oAhQO7fVI073lLfpJGIcG9PU2QracG84Ph5rVCpNdCpr39AuKuP7ZO7E q1xHL33LOiKFjbhZHE/aOwaCXWgyT2KZyra87LxpL9/ZbQQzYeFQfYdHvTnlfjBjIXSI YlE9HnvjYiI0bl48mokJNh2zxe52hEWPJS+wcaBcaBvhKRXOilH9beVlYct9IrTD1Tkt kU7sTO7iYtEyH8qd5p1aZOnIhzp6fbfaFqQrpTkoJ38uHilGp5vB7cgeCkzjKIs5ag5z IlNibwDjC2uzwHFx7jbIIMAsadN4l4lBpYxy9kdVeKIrmZB3NEJtSELNJPhNnYl0XchS sZyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:content-transfer-encoding:cc:reply-to:from :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to :delivered-to; bh=m0QAR/Oqslknmi/T6xYmD/lDtNYcvLii/d+4GpELSBs=; fh=nenT92/WZoU6unXd3J6UhGUdod4piddKfVtctNBOh6k=; b=IQ/n/iqAg9eGscEkIYhg2xrIjTEYckFAPCDilUbBG6IRDWJuCqEU0m+MSaKrRnLGB7 FS4tOiXURw71eLxh7u6cZAkgV77SwByBWhOfhNBALZVI+UHYdn1Pzo+/c7iaCnqjjM/z PNZB+JuUl1XT/feD4ke5VE2YTXgeYUtRoOKsPqCf7GYc0HKaSRB4cBB31MdpgjdXkgDX oi4JjAavgHojMNdB5O7vk5OkkXz4LyEARgzirnNu5ksVzmpTe4pLCDuYC2gN+U1T38Qy x2KvV+hde9mQ9WSWWUZEi7nkvmE+VuGhApwekU2WzhDyQh3CasHtz7P1ziarQJ/f/2dT Ot+Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5c8e0589427si3996591a12.128.2024.10.07.02.52.56; Mon, 07 Oct 2024 02:52:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C90C468D10D; Mon, 7 Oct 2024 12:52:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vidala.lynne.ee (vidala.pars.ee [116.203.72.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B76668D10D for ; Mon, 7 Oct 2024 12:52:46 +0300 (EEST) To: ffmpeg-devel@ffmpeg.org Date: Mon, 7 Oct 2024 11:52:37 +0200 Message-ID: <20241007095244.1405450-1-dev@lynne.ee> X-Mailer: git-send-email 2.45.2.753.g447d99e1c3b MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] configure: explicitly disable spirv_compiler X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lynne via ffmpeg-devel From: Lynne Reply-To: FFmpeg development discussions and patches Cc: Lynne Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 5/4uOV8kjy1Q spirv_compiler is an undeclared variable that was spontaneously enabled if libshaderc or libglslang were detected, and served as a way to enable filters. However, it being undeclared had the effect that it was neither considered explicitly disabled nor enabled if libshaderc or libglslang were detected. The only category we have which explicitly disables variables is EXTERNAL_LIBRARY_LIST, however, spirv_compiler is not a real external library, and making it present there would report its detection on ./configure. --- configure | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/configure b/configure index 1006ac98e2..8dfbf637d4 100755 --- a/configure +++ b/configure @@ -6553,6 +6553,15 @@ if test -n "$custom_allocator"; then add_extralibs "$custom_allocator_extralibs" fi +# Unlike other feature flags or libraries, spirv_compiler is not defined +# within any of our predefined categories of components. +# It gets defined if either libshaderc or libglslang check succeeds. +# As such, its in a state of neither being explicitly enabled, nor +# explicitly disabled, but even in this state, being mentioned in +# _deps results in it always passing. +# Disable it explicitly to fix this. +disable spirv_compiler + check_func_headers malloc.h _aligned_malloc && enable aligned_malloc check_func ${malloc_prefix}memalign && enable memalign check_func ${malloc_prefix}posix_memalign && enable posix_memalign