| Message ID | 26a7a46d-aa7e-b90d-12da-1f5ad31886f4@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 08/01/18 08:35, Jun Zhao wrote: > > From 72b242449086d7366ee524e608bb8f178c15b8cf Mon Sep 17 00:00:00 2001 > From: Jun Zhao <jun.zhao@intel.com> > Date: Mon, 8 Jan 2018 16:12:41 +0800 > Subject: [PATCH 4/5] lavfi: add ProcAmp(color balance) vaapi video filter. > > add ProcAmp(color balance) vaapi video filter, use the option > like -vf "procamp_vaapi=b=10:h=120:c=2.8:s=3.7" to set > brightness/hue/contrast/saturation. > > Signed-off-by: Yun Zhou <yunx.z.zhou@intel.com> > Signed-off-by: Jun Zhao <jun.zhao@intel.com> > --- > configure | 1 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_procamp_vaapi.c | 308 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 311 insertions(+) > create mode 100644 libavfilter/vf_procamp_vaapi.c git says: Applying: lavfi: add ProcAmp(color balance) vaapi video filter. .git/rebase-apply/patch:358: new blank line at EOF. + warning: 1 line adds whitespace errors. > > diff --git a/configure b/configure > index 1c3e505b04..366a67d327 100755 > --- a/configure > +++ b/configure > @@ -3245,6 +3245,7 @@ perspective_filter_deps="gpl" > phase_filter_deps="gpl" > pp7_filter_deps="gpl" > pp_filter_deps="gpl postproc" > +procamp_vaapi_filter_deps="vaapi VAProcPipelineParameterBuffer" > program_opencl_filter_deps="opencl" > pullup_filter_deps="gpl" > removelogo_filter_deps="avcodec avformat swscale" > diff --git a/libavfilter/Makefile b/libavfilter/Makefile > index bbc97a0831..43d0dd36e6 100644 > --- a/libavfilter/Makefile > +++ b/libavfilter/Makefile > @@ -275,6 +275,7 @@ OBJS-$(CONFIG_PP_FILTER) += vf_pp.o > OBJS-$(CONFIG_PP7_FILTER) += vf_pp7.o > OBJS-$(CONFIG_PREMULTIPLY_FILTER) += vf_premultiply.o framesync.o > OBJS-$(CONFIG_PREWITT_FILTER) += vf_convolution.o > +OBJS-$(CONFIG_PROCAMP_VAAPI_FILTER) += vf_procamp_vaapi.o vaapi_vpp.o > OBJS-$(CONFIG_PROGRAM_OPENCL_FILTER) += vf_program_opencl.o opencl.o framesync.o > OBJS-$(CONFIG_PSEUDOCOLOR_FILTER) += vf_pseudocolor.o > OBJS-$(CONFIG_PSNR_FILTER) += vf_psnr.o framesync.o > diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c > index 42516bbdf9..63550628e5 100644 > --- a/libavfilter/allfilters.c > +++ b/libavfilter/allfilters.c > @@ -284,6 +284,7 @@ static void register_all(void) > REGISTER_FILTER(PP7, pp7, vf); > REGISTER_FILTER(PREMULTIPLY, premultiply, vf); > REGISTER_FILTER(PREWITT, prewitt, vf); > + REGISTER_FILTER(PROCAMP_VAAPI, procamp_vaapi, vf); > REGISTER_FILTER(PROGRAM_OPENCL, program_opencl, vf); > REGISTER_FILTER(PSEUDOCOLOR, pseudocolor, vf); > REGISTER_FILTER(PSNR, psnr, vf); > diff --git a/libavfilter/vf_procamp_vaapi.c b/libavfilter/vf_procamp_vaapi.c > new file mode 100644 > index 0000000000..d169d54ebe > --- /dev/null > +++ b/libavfilter/vf_procamp_vaapi.c > @@ -0,0 +1,308 @@ > +/* > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > +#include <string.h> > + > +#include <va/va.h> > +#include <va/va_vpp.h> > + > +#include "libavutil/avassert.h" > +#include "libavutil/hwcontext.h" > +#include "libavutil/hwcontext_vaapi.h" > +#include "libavutil/mem.h" > +#include "libavutil/opt.h" > +#include "libavutil/pixdesc.h" > + > +#include "avfilter.h" > +#include "formats.h" > +#include "internal.h" > +#include "vaapi_vpp.h" > + > +typedef struct ProcampVAAPIContext { > + const AVClass *class; > + > + VAAPIVPPContext *vpp_ctx; > + > + float bright; > + float hue; > + float saturation; > + float contrast; > +} ProcampVAAPIContext; > + > +static int procamp_vaapi_query_formats(AVFilterContext *avctx) > +{ > + return vaapi_vpp_query_formats(avctx); > +} > + > +static int procamp_vaapi_pipeline_uninit(AVFilterContext *avctx) > +{ > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; > + > + return vaapi_vpp_pipeline_uninit(vpp_ctx); > +} > + > +static int procamp_vaapi_config_input(AVFilterLink *inlink) > +{ > + AVFilterContext *avctx = inlink->dst; > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; > + > + return vaapi_vpp_config_input(inlink, vpp_ctx); > +} > + > +static int procamp_vaapi_build_filter_params(AVFilterContext *avctx) > +{ > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; > + VAStatus vas; > + VAProcFilterParameterBufferColorBalance procamp_params[4]; > + VAProcFilterCapColorBalance procamp_caps[VAProcColorBalanceCount]; > + int num_caps; > + > + memset(&procamp_params, 0, sizeof(procamp_params)); > + memset(&procamp_caps, 0, sizeof(procamp_caps)); > + > + num_caps = VAProcColorBalanceCount; > + vas = vaQueryVideoProcFilterCaps(vpp_ctx->hwctx->display, vpp_ctx->va_context, > + VAProcFilterColorBalance, &procamp_caps, &num_caps); > + > + if (vas != VA_STATUS_SUCCESS) { > + av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " > + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); "Failed to query procamp filter caps", maybe? > + return AVERROR(EIO); > + } > + > + procamp_params[0].type = VAProcFilterColorBalance; > + procamp_params[0].attrib = VAProcColorBalanceBrightness; > + procamp_params[0].value = > + av_clip(ctx->bright, > + procamp_caps[VAProcColorBalanceBrightness-1].range.min_value, > + procamp_caps[VAProcColorBalanceBrightness-1].range.max_value); I don't think there is any requirement that these caps are returned in the same order such that "-1" works. Search for the one with the type matching what you want from the list? > + > + procamp_params[1].type = VAProcFilterColorBalance; > + procamp_params[1].attrib = VAProcColorBalanceContrast; > + procamp_params[1].value = > + av_clip(ctx->contrast, > + procamp_caps[VAProcColorBalanceContrast-1].range.min_value, > + procamp_caps[VAProcColorBalanceContrast-1].range.max_value); av_clip() works on integers, but these are floats. Observe that reducing saturation or contrast with numbers less than one doesn't work, because it gets clipped to zero and you end up with no colour at all or solid black respectively. > + > + procamp_params[2].type = VAProcFilterColorBalance; > + procamp_params[2].attrib = VAProcColorBalanceHue; > + procamp_params[2].value = > + av_clip(ctx->hue, > + procamp_caps[VAProcColorBalanceHue-1].range.min_value, > + procamp_caps[VAProcColorBalanceHue-1].range.max_value); > + > + procamp_params[3].type = VAProcFilterColorBalance; > + procamp_params[3].attrib = VAProcColorBalanceSaturation; > + procamp_params[3].value = > + av_clip(ctx->saturation, > + procamp_caps[VAProcColorBalanceSaturation-1].range.min_value, > + procamp_caps[VAProcColorBalanceSaturation-1].range.max_value); > + > + vaapi_vpp_make_param_buffers(vpp_ctx, > + VAProcFilterParameterBufferType, > + &procamp_params, > + sizeof(procamp_params[0]), > + 4); Can fail. > + > + return 0; > +} > + > +static int procamp_vaapi_config_output(AVFilterLink *outlink) > +{ > + AVFilterContext *avctx = outlink->src; > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; > + int err; > + > + ctx->vpp_ctx->output_width = avctx->inputs[0]->w; > + ctx->vpp_ctx->output_height = avctx->inputs[0]->h; > + > + err = vaapi_vpp_config_output(outlink, vpp_ctx); > + if (err < 0) > + goto fail; > + > + return 0; > + > +fail: > + return err; > +} > + > +static int procamp_vaapi_filter_frame(AVFilterLink *inlink, AVFrame *input_frame) > +{ > + AVFilterContext *avctx = inlink->dst; > + AVFilterLink *outlink = avctx->outputs[0]; > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; > + AVFrame *output_frame = NULL; > + VASurfaceID input_surface, output_surface; > + VAProcPipelineParameterBuffer params; > + VARectangle input_region; > + int err; > + > + av_log(ctx, AV_LOG_DEBUG, "Filter input: %s, %ux%u (%"PRId64").\n", > + av_get_pix_fmt_name(input_frame->format), > + input_frame->width, input_frame->height, input_frame->pts); > + > + if (vpp_ctx->va_context == VA_INVALID_ID) > + return AVERROR(EINVAL); > + > + input_surface = (VASurfaceID)(uintptr_t)input_frame->data[3]; > + av_log(ctx, AV_LOG_DEBUG, "Using surface %#x for procamp input.\n", > + input_surface); > + > + output_frame = av_frame_alloc(); > + if (!output_frame) { > + av_log(ctx, AV_LOG_ERROR, "Failed to allocate output frame."); > + err = AVERROR(ENOMEM); > + goto fail; > + } > + > + err = av_hwframe_get_buffer(vpp_ctx->output_frames_ref, output_frame, 0); > + if (err < 0) { > + av_log(ctx, AV_LOG_ERROR, "Failed to get surface for " > + "output: %d\n.", err); > + } Please use ff_get_video_buffer() on the output link rather than allocating directly from the hwframe context. > + > + output_surface = (VASurfaceID)(uintptr_t)output_frame->data[3]; > + av_log(ctx, AV_LOG_DEBUG, "Using surface %#x for procamp output.\n", > + output_surface); > + memset(¶ms, 0, sizeof(params)); > + input_region = (VARectangle) { > + .x = 0, > + .y = 0, > + .width = input_frame->width, > + .height = input_frame->height, > + }; > + > + params.surface = input_surface; > + params.surface_region = &input_region; > + params.surface_color_standard = > + vaapi_vpp_colour_standard(input_frame->colorspace); > + > + params.output_region = NULL; > + params.output_background_color = 0xff000000; > + params.output_color_standard = params.surface_color_standard; > + > + params.pipeline_flags = 0; > + params.filter_flags = VA_FRAME_PICTURE; > + > + params.filters = &vpp_ctx->filter_buffers[0]; > + params.num_filters = 1; > + > + err = vaapi_vpp_render_picture(vpp_ctx, ¶ms, output_surface); > + if (err < 0) > + goto fail; > + > + err = av_frame_copy_props(output_frame, input_frame); > + if (err < 0) > + goto fail; > + av_frame_free(&input_frame); > + > + av_log(ctx, AV_LOG_DEBUG, "Filter output: %s, %ux%u (%"PRId64").\n", > + av_get_pix_fmt_name(output_frame->format), > + output_frame->width, output_frame->height, output_frame->pts); > + > + return ff_filter_frame(outlink, output_frame); > + > +fail: > + av_frame_free(&output_frame); > + return err; I think this case leaks input_frame. > +} > + > +static av_cold int procamp_vaapi_init(AVFilterContext *avctx) > +{ > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx; > + > + ctx->vpp_ctx = av_mallocz(sizeof(VAAPIVPPContext)); > + if (!ctx->vpp_ctx) > + return AVERROR(ENOMEM); > + > + vpp_ctx = ctx->vpp_ctx; > + > + vaapi_vpp_ctx_init(vpp_ctx); > + vpp_ctx->pipeline_uninit = procamp_vaapi_pipeline_uninit; > + vpp_ctx->build_filter_params = procamp_vaapi_build_filter_params; > + vpp_ctx->output_format = AV_PIX_FMT_NONE; > + > + return 0; > +} > + > +static av_cold void procamp_vaapi_uninit(AVFilterContext *avctx) > +{ > + ProcampVAAPIContext *ctx = avctx->priv; > + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; > + > + vaapi_vpp_ctx_uninit(avctx, vpp_ctx); > +} > + > +#define OFFSET(x) offsetof(ProcampVAAPIContext, x) > +#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM) > +static const AVOption procamp_vaapi_options[] = { > + { "b", "Output video brightness", > + OFFSET(bright), AV_OPT_TYPE_FLOAT, { .dbl = 0.0 }, -100.0, 100.0, .flags = FLAGS }, > + { "s", "Output video saturation", > + OFFSET(saturation), AV_OPT_TYPE_FLOAT, { .dbl = 1.0 }, 0.0, 10.0, .flags = FLAGS }, > + { "c", "Output video contrast", > + OFFSET(contrast), AV_OPT_TYPE_FLOAT, { .dbl = 1.0 }, 0.0, 10.0, .flags = FLAGS }, > + { "h", "Output video hue", > + OFFSET(hue), AV_OPT_TYPE_FLOAT, { .dbl = 0.0 }, -180.0, 180.0, .flags = FLAGS }, Might be nice to allow the full names "brightness", "saturation", "contrast", "hue" as well as the short names? (Just duplicate each line with a different name.) > + { NULL }, > +}; > + > +static const AVClass procamp_vaapi_class = { > + .class_name = "procamp_vaapi", > + .item_name = av_default_item_name, > + .option = procamp_vaapi_options, > + .version = LIBAVUTIL_VERSION_INT, > +}; AVFILTER_DEFINE_CLASS() is nicer for this. > + > +static const AVFilterPad procamp_vaapi_inputs[] = { > + { > + .name = "default", > + .type = AVMEDIA_TYPE_VIDEO, > + .filter_frame = &procamp_vaapi_filter_frame, > + .config_props = &procamp_vaapi_config_input, > + }, > + { NULL } > +}; > + > +static const AVFilterPad procamp_vaapi_outputs[] = { > + { > + .name = "default", > + .type = AVMEDIA_TYPE_VIDEO, > + .config_props = &procamp_vaapi_config_output, > + }, > + { NULL } > +}; > + > +AVFilter ff_vf_procamp_vaapi = { > + .name = "procamp_vaapi", > + .description = NULL_IF_CONFIG_SMALL("ProcAmp (color balance) adjustments for hue, saturation, brightness, contrast"), > + .priv_size = sizeof(ProcampVAAPIContext), > + .init = &procamp_vaapi_init, > + .uninit = &procamp_vaapi_uninit, > + .query_formats = &procamp_vaapi_query_formats, > + .inputs = procamp_vaapi_inputs, > + .outputs = procamp_vaapi_outputs, > + .priv_class = &procamp_vaapi_class, > + .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > +}; > + > -- > 2.14.1 > I like the name, it's a lot clearer what it does than previous suggestions.
> On 08/01/18 08:35, Jun Zhao wrote: >> + VAStatus vas; >> + av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " >> + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); Is "%d" what it's supposed to be? Why is VAStatus needed then? Carl Eugen
On 14/01/18 22:59, Carl Eugen Hoyos wrote: >> On 08/01/18 08:35, Jun Zhao wrote: > >>> + VAStatus vas; > >>> + av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " >>> + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); > > Is "%d" what it's supposed to be? Why is VAStatus needed then? Yes: <https://github.com/01org/libva/blob/master/va/va.h#L170>. I guess VAStatus is there to suggest to the user to keep different namespaces of error codes apart? Since the types are the same the compiler unfortunately doesn't actually help to check it, though. - Mark
2018-01-15 0:14 GMT+01:00 Mark Thompson <sw@jkqxz.net>: > On 14/01/18 22:59, Carl Eugen Hoyos wrote: >>> On 08/01/18 08:35, Jun Zhao wrote: >> >>>> + VAStatus vas; >> >>>> + av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " >>>> + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); >> >> Is "%d" what it's supposed to be? Why is VAStatus needed then? > > Yes: <https://github.com/01org/libva/blob/master/va/va.h#L170>. Ok, I expected this. But my question was actually: If there is a typedef for a return value that you may be interested in printing, shouldn't there be a define that is the correct format? Carl Eugen
diff --git a/configure b/configure index 1c3e505b04..366a67d327 100755 --- a/configure +++ b/configure @@ -3245,6 +3245,7 @@ perspective_filter_deps="gpl" phase_filter_deps="gpl" pp7_filter_deps="gpl" pp_filter_deps="gpl postproc" +procamp_vaapi_filter_deps="vaapi VAProcPipelineParameterBuffer" program_opencl_filter_deps="opencl" pullup_filter_deps="gpl" removelogo_filter_deps="avcodec avformat swscale" diff --git a/libavfilter/Makefile b/libavfilter/Makefile index bbc97a0831..43d0dd36e6 100644 --- a/libavfilter/Makefile +++ b/libavfilter/Makefile @@ -275,6 +275,7 @@ OBJS-$(CONFIG_PP_FILTER) += vf_pp.o OBJS-$(CONFIG_PP7_FILTER) += vf_pp7.o OBJS-$(CONFIG_PREMULTIPLY_FILTER) += vf_premultiply.o framesync.o OBJS-$(CONFIG_PREWITT_FILTER) += vf_convolution.o +OBJS-$(CONFIG_PROCAMP_VAAPI_FILTER) += vf_procamp_vaapi.o vaapi_vpp.o OBJS-$(CONFIG_PROGRAM_OPENCL_FILTER) += vf_program_opencl.o opencl.o framesync.o OBJS-$(CONFIG_PSEUDOCOLOR_FILTER) += vf_pseudocolor.o OBJS-$(CONFIG_PSNR_FILTER) += vf_psnr.o framesync.o diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index 42516bbdf9..63550628e5 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c @@ -284,6 +284,7 @@ static void register_all(void) REGISTER_FILTER(PP7, pp7, vf); REGISTER_FILTER(PREMULTIPLY, premultiply, vf); REGISTER_FILTER(PREWITT, prewitt, vf); + REGISTER_FILTER(PROCAMP_VAAPI, procamp_vaapi, vf); REGISTER_FILTER(PROGRAM_OPENCL, program_opencl, vf); REGISTER_FILTER(PSEUDOCOLOR, pseudocolor, vf); REGISTER_FILTER(PSNR, psnr, vf); diff --git a/libavfilter/vf_procamp_vaapi.c b/libavfilter/vf_procamp_vaapi.c new file mode 100644 index 0000000000..d169d54ebe --- /dev/null +++ b/libavfilter/vf_procamp_vaapi.c @@ -0,0 +1,308 @@ +/* + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with FFmpeg; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ +#include <string.h> + +#include <va/va.h> +#include <va/va_vpp.h> + +#include "libavutil/avassert.h" +#include "libavutil/hwcontext.h" +#include "libavutil/hwcontext_vaapi.h" +#include "libavutil/mem.h" +#include "libavutil/opt.h" +#include "libavutil/pixdesc.h" + +#include "avfilter.h" +#include "formats.h" +#include "internal.h" +#include "vaapi_vpp.h" + +typedef struct ProcampVAAPIContext { + const AVClass *class; + + VAAPIVPPContext *vpp_ctx; + + float bright; + float hue; + float saturation; + float contrast; +} ProcampVAAPIContext; + +static int procamp_vaapi_query_formats(AVFilterContext *avctx) +{ + return vaapi_vpp_query_formats(avctx); +} + +static int procamp_vaapi_pipeline_uninit(AVFilterContext *avctx) +{ + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; + + return vaapi_vpp_pipeline_uninit(vpp_ctx); +} + +static int procamp_vaapi_config_input(AVFilterLink *inlink) +{ + AVFilterContext *avctx = inlink->dst; + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; + + return vaapi_vpp_config_input(inlink, vpp_ctx); +} + +static int procamp_vaapi_build_filter_params(AVFilterContext *avctx) +{ + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; + VAStatus vas; + VAProcFilterParameterBufferColorBalance procamp_params[4]; + VAProcFilterCapColorBalance procamp_caps[VAProcColorBalanceCount]; + int num_caps; + + memset(&procamp_params, 0, sizeof(procamp_params)); + memset(&procamp_caps, 0, sizeof(procamp_caps)); + + num_caps = VAProcColorBalanceCount; + vas = vaQueryVideoProcFilterCaps(vpp_ctx->hwctx->display, vpp_ctx->va_context, + VAProcFilterColorBalance, &procamp_caps, &num_caps); + + if (vas != VA_STATUS_SUCCESS) { + av_log(avctx, AV_LOG_ERROR, "Failed to Query procamp " + "query caps: %d (%s).\n", vas, vaErrorStr(vas)); + return AVERROR(EIO); + } + + procamp_params[0].type = VAProcFilterColorBalance; + procamp_params[0].attrib = VAProcColorBalanceBrightness; + procamp_params[0].value = + av_clip(ctx->bright, + procamp_caps[VAProcColorBalanceBrightness-1].range.min_value, + procamp_caps[VAProcColorBalanceBrightness-1].range.max_value); + + procamp_params[1].type = VAProcFilterColorBalance; + procamp_params[1].attrib = VAProcColorBalanceContrast; + procamp_params[1].value = + av_clip(ctx->contrast, + procamp_caps[VAProcColorBalanceContrast-1].range.min_value, + procamp_caps[VAProcColorBalanceContrast-1].range.max_value); + + procamp_params[2].type = VAProcFilterColorBalance; + procamp_params[2].attrib = VAProcColorBalanceHue; + procamp_params[2].value = + av_clip(ctx->hue, + procamp_caps[VAProcColorBalanceHue-1].range.min_value, + procamp_caps[VAProcColorBalanceHue-1].range.max_value); + + procamp_params[3].type = VAProcFilterColorBalance; + procamp_params[3].attrib = VAProcColorBalanceSaturation; + procamp_params[3].value = + av_clip(ctx->saturation, + procamp_caps[VAProcColorBalanceSaturation-1].range.min_value, + procamp_caps[VAProcColorBalanceSaturation-1].range.max_value); + + vaapi_vpp_make_param_buffers(vpp_ctx, + VAProcFilterParameterBufferType, + &procamp_params, + sizeof(procamp_params[0]), + 4); + + return 0; +} + +static int procamp_vaapi_config_output(AVFilterLink *outlink) +{ + AVFilterContext *avctx = outlink->src; + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; + int err; + + ctx->vpp_ctx->output_width = avctx->inputs[0]->w; + ctx->vpp_ctx->output_height = avctx->inputs[0]->h; + + err = vaapi_vpp_config_output(outlink, vpp_ctx); + if (err < 0) + goto fail; + + return 0; + +fail: + return err; +} + +static int procamp_vaapi_filter_frame(AVFilterLink *inlink, AVFrame *input_frame) +{ + AVFilterContext *avctx = inlink->dst; + AVFilterLink *outlink = avctx->outputs[0]; + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; + AVFrame *output_frame = NULL; + VASurfaceID input_surface, output_surface; + VAProcPipelineParameterBuffer params; + VARectangle input_region; + int err; + + av_log(ctx, AV_LOG_DEBUG, "Filter input: %s, %ux%u (%"PRId64").\n", + av_get_pix_fmt_name(input_frame->format), + input_frame->width, input_frame->height, input_frame->pts); + + if (vpp_ctx->va_context == VA_INVALID_ID) + return AVERROR(EINVAL); + + input_surface = (VASurfaceID)(uintptr_t)input_frame->data[3]; + av_log(ctx, AV_LOG_DEBUG, "Using surface %#x for procamp input.\n", + input_surface); + + output_frame = av_frame_alloc(); + if (!output_frame) { + av_log(ctx, AV_LOG_ERROR, "Failed to allocate output frame."); + err = AVERROR(ENOMEM); + goto fail; + } + + err = av_hwframe_get_buffer(vpp_ctx->output_frames_ref, output_frame, 0); + if (err < 0) { + av_log(ctx, AV_LOG_ERROR, "Failed to get surface for " + "output: %d\n.", err); + } + + output_surface = (VASurfaceID)(uintptr_t)output_frame->data[3]; + av_log(ctx, AV_LOG_DEBUG, "Using surface %#x for procamp output.\n", + output_surface); + memset(¶ms, 0, sizeof(params)); + input_region = (VARectangle) { + .x = 0, + .y = 0, + .width = input_frame->width, + .height = input_frame->height, + }; + + params.surface = input_surface; + params.surface_region = &input_region; + params.surface_color_standard = + vaapi_vpp_colour_standard(input_frame->colorspace); + + params.output_region = NULL; + params.output_background_color = 0xff000000; + params.output_color_standard = params.surface_color_standard; + + params.pipeline_flags = 0; + params.filter_flags = VA_FRAME_PICTURE; + + params.filters = &vpp_ctx->filter_buffers[0]; + params.num_filters = 1; + + err = vaapi_vpp_render_picture(vpp_ctx, ¶ms, output_surface); + if (err < 0) + goto fail; + + err = av_frame_copy_props(output_frame, input_frame); + if (err < 0) + goto fail; + av_frame_free(&input_frame); + + av_log(ctx, AV_LOG_DEBUG, "Filter output: %s, %ux%u (%"PRId64").\n", + av_get_pix_fmt_name(output_frame->format), + output_frame->width, output_frame->height, output_frame->pts); + + return ff_filter_frame(outlink, output_frame); + +fail: + av_frame_free(&output_frame); + return err; +} + +static av_cold int procamp_vaapi_init(AVFilterContext *avctx) +{ + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx; + + ctx->vpp_ctx = av_mallocz(sizeof(VAAPIVPPContext)); + if (!ctx->vpp_ctx) + return AVERROR(ENOMEM); + + vpp_ctx = ctx->vpp_ctx; + + vaapi_vpp_ctx_init(vpp_ctx); + vpp_ctx->pipeline_uninit = procamp_vaapi_pipeline_uninit; + vpp_ctx->build_filter_params = procamp_vaapi_build_filter_params; + vpp_ctx->output_format = AV_PIX_FMT_NONE; + + return 0; +} + +static av_cold void procamp_vaapi_uninit(AVFilterContext *avctx) +{ + ProcampVAAPIContext *ctx = avctx->priv; + VAAPIVPPContext *vpp_ctx = ctx->vpp_ctx; + + vaapi_vpp_ctx_uninit(avctx, vpp_ctx); +} + +#define OFFSET(x) offsetof(ProcampVAAPIContext, x) +#define FLAGS (AV_OPT_FLAG_VIDEO_PARAM) +static const AVOption procamp_vaapi_options[] = { + { "b", "Output video brightness", + OFFSET(bright), AV_OPT_TYPE_FLOAT, { .dbl = 0.0 }, -100.0, 100.0, .flags = FLAGS }, + { "s", "Output video saturation", + OFFSET(saturation), AV_OPT_TYPE_FLOAT, { .dbl = 1.0 }, 0.0, 10.0, .flags = FLAGS }, + { "c", "Output video contrast", + OFFSET(contrast), AV_OPT_TYPE_FLOAT, { .dbl = 1.0 }, 0.0, 10.0, .flags = FLAGS }, + { "h", "Output video hue", + OFFSET(hue), AV_OPT_TYPE_FLOAT, { .dbl = 0.0 }, -180.0, 180.0, .flags = FLAGS }, + { NULL }, +}; + +static const AVClass procamp_vaapi_class = { + .class_name = "procamp_vaapi", + .item_name = av_default_item_name, + .option = procamp_vaapi_options, + .version = LIBAVUTIL_VERSION_INT, +}; + +static const AVFilterPad procamp_vaapi_inputs[] = { + { + .name = "default", + .type = AVMEDIA_TYPE_VIDEO, + .filter_frame = &procamp_vaapi_filter_frame, + .config_props = &procamp_vaapi_config_input, + }, + { NULL } +}; + +static const AVFilterPad procamp_vaapi_outputs[] = { + { + .name = "default", + .type = AVMEDIA_TYPE_VIDEO, + .config_props = &procamp_vaapi_config_output, + }, + { NULL } +}; + +AVFilter ff_vf_procamp_vaapi = { + .name = "procamp_vaapi", + .description = NULL_IF_CONFIG_SMALL("ProcAmp (color balance) adjustments for hue, saturation, brightness, contrast"), + .priv_size = sizeof(ProcampVAAPIContext), + .init = &procamp_vaapi_init, + .uninit = &procamp_vaapi_uninit, + .query_formats = &procamp_vaapi_query_formats, + .inputs = procamp_vaapi_inputs, + .outputs = procamp_vaapi_outputs, + .priv_class = &procamp_vaapi_class, + .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, +}; +