From patchwork Wed May 29 22:13:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Tomas_H=C3=A4rdin?= X-Patchwork-Id: 49369 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:8f0d:0:b0:460:55fa:d5ed with SMTP id i13csp952168vqu; Wed, 29 May 2024 15:13:28 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUOaRmBEZUJPa+UJ47GuCprcBUUFF0/h+0AsmgWgLjNV77ibiltm9dt8WDqwLy/p7+Hj/g18K8Fo7iqjlMQPHyvwQF4yPl5PttUQg== X-Google-Smtp-Source: AGHT+IEHLdHRm40uJl/X8iJ9Br+b7a/nnD49sQHAX8VTxDCak8s2tn0ObBVOlEGsymhI6hTyAcFQ X-Received: by 2002:a17:906:1cdb:b0:a62:de58:b350 with SMTP id a640c23a62f3a-a65e91010b8mr34857566b.59.1717020807794; Wed, 29 May 2024 15:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717020807; cv=none; d=google.com; s=arc-20160816; b=EP5zBjEyIVCyE1YNVYVY4Husxj9GwGGITMpfQGUYsxpd7apzFXOkJ2eVjBX68h1Zo/ C9u0EXJ6WWkaNTnFMkJcYpZLH6yPlVOMeNZqwkPJmXM05iltgFBYu47dNj92cXhPMTZM L6F6bdmVFpzMnGxwdiTtEdl3KFjcz37vaQ8tyCTND2jPkPw+sEmUAg4QcUHc3w2PyBJz CNoVILHvcmhbE1qjX1XKYfzzH70S6F/BFtSrMmPk29TRDcj200woOamFtHl0v+01XW7G o4zFm3uq0wf9nqYBtwWG2/dJGvEMuCwH0zOv53nzoSe2czCc0uyf42HoYgThZTSV6mXd 1pMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:user-agent:date:to:from:message-id:delivered-to; bh=ROuWsszSSgSDrQdZLD02uHtYLYaSnlKH8CdYA+VkCMM=; fh=e5zN9xSzcxLA6bGo3lF+CqTbY/oLwzApV03EO/RBfgQ=; b=xyLMOar3DVhLGQ94lZNwezT3iRrod5aJnSuUq8ax1HzR4NxWcSWRjV0mScx+IKlD/0 I1vcC7J5bLAyvxXSSlBlLJLB3f8dtinEATpPQjM3zN2eqG24kyK6qVinOfHYxW156yb7 TBH+arZcKmXa3mVQb5gGIADWjeDn/hn0fxgCr8G52nXAbIJioILJEsdlDblgCaMBh2zQ PatKFLQMBKMpRWn/zZlpxsmwWTMtcPWqvH0ARPwKKdt/FROVNCINw5CfpMbIt2qL8vvJ jv+gNbms1TfJFrONdNoxZ47NuMD0GyIm5o7iCmoJSCCGktN0T//Q0KViWiQB+plmvJv+ hPnQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626cc37f04si694147666b.358.2024.05.29.15.13.27; Wed, 29 May 2024 15:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7311A68D390; Thu, 30 May 2024 01:13:23 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from glom.nmugroup.com (glom.nmugroup.com [193.183.80.6]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 57EA568BFFF for ; Thu, 30 May 2024 01:13:16 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by glom.nmugroup.com (Postfix) with ESMTP id 4824954292DE for ; Thu, 30 May 2024 00:13:15 +0200 (CEST) Received: from debian.lan (unknown [IPv6:2a00:66c0:a::72c]) (Authenticated sender: git01) by glom.nmugroup.com (Postfix) with ESMTPSA id 099A45429274 for ; Thu, 30 May 2024 00:13:14 +0200 (CEST) Message-ID: <27e5f614496e729f68326a31c3ac70d5923cfa97.camel@haerdin.se> From: Tomas =?iso-8859-1?q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Thu, 30 May 2024 00:13:14 +0200 User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vssNKqbKqapk The entire patchset passes FATE /Tomas From c000b8a5e90883f28ce6c58960227e5825ac20d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 15 May 2024 21:03:47 +0200 Subject: [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c() Found by value analysis --- libavutil/common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/common.h b/libavutil/common.h index 3e4c339893..ac68c0cfff 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -252,8 +252,8 @@ static av_always_inline av_const int16_t av_clip_int16_c(int a) */ static av_always_inline av_const int32_t av_clipl_int32_c(int64_t a) { - if ((a+0x80000000u) & ~UINT64_C(0xFFFFFFFF)) return (int32_t)((a>>63) ^ 0x7FFFFFFF); - else return (int32_t)a; + if ((a+UINT64_C(0x80000000)) & ~UINT64_C(0xFFFFFFFF)) return (int32_t)((a>>63) ^ 0x7FFFFFFF); + else return (int32_t)a; } /** -- 2.39.2