diff mbox

[FFmpeg-devel] avutil/tests/random_seed: seeds[] is uint32_t, therefore use PRIX32 macro

Message ID 2c4d0a679a1d41083028f6b739f68415f2ff6925.1544839584.git.pross@xvid.org
State Accepted
Commit 436bffaca2312ce1b0fae149c50e77e411bcaa8e
Headers show

Commit Message

Peter Ross Dec. 15, 2018, 2:07 a.m. UTC
squelch format type warning
---
 libavutil/tests/random_seed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carl Eugen Hoyos Dec. 15, 2018, 2:10 a.m. UTC | #1
2018-12-15 3:07 GMT+01:00, Peter Ross <pross@xvid.org>:
> squelch format type warning
> ---
>  libavutil/tests/random_seed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c
> index 78067dbe41..bf0c6c7986 100644
> --- a/libavutil/tests/random_seed.c
> +++ b/libavutil/tests/random_seed.c
> @@ -47,7 +47,7 @@ int main(void)
>              retry:;
>          }
>          if (retry >= 3) {
> -            printf("rsf %d: FAIL at %d with %X\n", rsf, j, seeds[j]);
> +            printf("rsf %d: FAIL at %d with %"PRIX32"\n", rsf, j,
> seeds[j]);

Just curious: What shows a warning here?

Carl Eugen
Peter Ross Dec. 15, 2018, 2:13 a.m. UTC | #2
On Sat, Dec 15, 2018 at 03:10:52AM +0100, Carl Eugen Hoyos wrote:
> 2018-12-15 3:07 GMT+01:00, Peter Ross <pross@xvid.org>:
> > squelch format type warning
> > ---
> >  libavutil/tests/random_seed.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c
> > index 78067dbe41..bf0c6c7986 100644
> > --- a/libavutil/tests/random_seed.c
> > +++ b/libavutil/tests/random_seed.c
> > @@ -47,7 +47,7 @@ int main(void)
> >              retry:;
> >          }
> >          if (retry >= 3) {
> > -            printf("rsf %d: FAIL at %d with %X\n", rsf, j, seeds[j]);
> > +            printf("rsf %d: FAIL at %d with %"PRIX32"\n", rsf, j,
> > seeds[j]);
> 
> Just curious: What shows a warning here?

djgpp: uint32_t is an unsigned long there.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
Michael Niedermayer Dec. 16, 2018, 1:34 a.m. UTC | #3
On Sat, Dec 15, 2018 at 01:07:18PM +1100, Peter Ross wrote:
> squelch format type warning
> ---
>  libavutil/tests/random_seed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c
> index 78067dbe41..bf0c6c7986 100644
> --- a/libavutil/tests/random_seed.c
> +++ b/libavutil/tests/random_seed.c
> @@ -47,7 +47,7 @@ int main(void)
>              retry:;
>          }
>          if (retry >= 3) {
> -            printf("rsf %d: FAIL at %d with %X\n", rsf, j, seeds[j]);
> +            printf("rsf %d: FAIL at %d with %"PRIX32"\n", rsf, j, seeds[j]);
>              return 1;

should do no harm ...
LGTM

thx

[...]
diff mbox

Patch

diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c
index 78067dbe41..bf0c6c7986 100644
--- a/libavutil/tests/random_seed.c
+++ b/libavutil/tests/random_seed.c
@@ -47,7 +47,7 @@  int main(void)
             retry:;
         }
         if (retry >= 3) {
-            printf("rsf %d: FAIL at %d with %X\n", rsf, j, seeds[j]);
+            printf("rsf %d: FAIL at %d with %"PRIX32"\n", rsf, j, seeds[j]);
             return 1;
         }
     }