From patchwork Thu Dec 8 16:26:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 1717 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.65.86 with SMTP id o83csp961762vsa; Thu, 8 Dec 2016 08:26:46 -0800 (PST) X-Received: by 10.28.139.131 with SMTP id n125mr2938163wmd.116.1481214406561; Thu, 08 Dec 2016 08:26:46 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y67si13912908wmg.136.2016.12.08.08.26.46; Thu, 08 Dec 2016 08:26:46 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9EA5468A1DB; Thu, 8 Dec 2016 18:26:40 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 27EA668A1B9 for ; Thu, 8 Dec 2016 18:26:34 +0200 (EET) Received: by mail-wm0-f48.google.com with SMTP id t79so33666972wmt.0 for ; Thu, 08 Dec 2016 08:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=LbstEp3iMHr8KugMoOqI8Yk5XFDDQ137KC9JVdsp31Y=; b=xHC+6P1mXsoxJDeZ2gfIfBGzhPuXPgNvjyruOLWr8vviFXy7k069TW5Yl3kIXVmqH0 0ZQXMt6nERbT30n8PrcdXw81Kx/2s6jJ6vHmCjGgwtQmTb1VZsNzpvY0+fjktoxPIOx0 IVXKmwjraaQ2POtidcYGzpdZqlFpwO4xvvM0ez+TvUiVehoIUUH47Bjqj7sK9gotqvgm TDj0s076Mx3scpMd0XtaV4da2ZDUyY3S9l1wqh9/KdZPp9cVCM4lXxZZ5Dyg0Hptyjvb H9+69BcfM8GfOVzQ9sCkO/li4Z4gHd/o1kF7TCEFBwElpn39drD4/Sh5p/W2hzk3O0z9 Oo3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=LbstEp3iMHr8KugMoOqI8Yk5XFDDQ137KC9JVdsp31Y=; b=Egs3qzfBc9uWUVpuq4gE23ThewavIGMRBz7xOfb9VcDLmQ060TjbMsaSF2Us8dD4aB 1YLVti9+DiTK295i40jEhTCaQgeEwXOz8tXA7yGvNkxuLYMr0mivbWhdmgpOXJOVAR53 GCqm+ymLjgsPslofrb347/f3rzQguj2xHAU7/4p0rnY214VCIt/JJ9I108gxsXZwgGml o9LTX/GvEFg91eIKqJwrBgew0BZNjWHg1Mfb3AiraPCO1J5WX1zCOPAITtcnZhWS6lk5 Qn6WIUe+nkkEJGWIhCzTA14QFyHLmrXb1a4oPeZ4i8qzxwGYeXlEpc0A0rAMMPT4PeaG umCw== X-Gm-Message-State: AKaTC025yDlHhV57u0ntBXNxtaqnV0+hb+6flbSessy4Uz3t671M3OeuUQ6UCQ4y6iKVwQ== X-Received: by 10.28.166.20 with SMTP id p20mr3092413wme.87.1481214396594; Thu, 08 Dec 2016 08:26:36 -0800 (PST) Received: from [10.0.0.193] ([213.210.30.6]) by smtp.gmail.com with ESMTPSA id w79sm16058264wmw.0.2016.12.08.08.26.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 08:26:35 -0800 (PST) To: FFmpeg development discussions and patches References: <20161205203259.2479-1-matmaul@gmail.com> <20161205203259.2479-2-matmaul@gmail.com> <01ee65fc-c93d-7142-333f-aad786d3384b@jkqxz.net> <11288a1f-edec-68c3-1f6c-7dc9a85cef35@jkqxz.net> <49ef16c5-7f21-ed1a-b3fe-d6e669153a7e@gmail.com> From: Mark Thompson Message-ID: <31492c0c-fce2-9841-a9df-a483519175a5@jkqxz.net> Date: Thu, 8 Dec 2016 16:26:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <49ef16c5-7f21-ed1a-b3fe-d6e669153a7e@gmail.com> Subject: [FFmpeg-devel] [PATCH] configure: Require bit_depth field for VAAPI VP9 decode hwaccel X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" libva versions from 1.6.0 to 1.6.2 do not include it, and therefore cannot work with VP9 profile >= 2. --- On 08/12/16 16:13, James Almer wrote: > On 12/8/2016 12:55 PM, Mark Thompson wrote: >> On 08/12/16 15:51, Mark Thompson wrote: >>> Hacky fix enclosing, only compile tested. >>> >>> A configure test for this might be better, because we could then check it sensibly in the generic code and bail out earlier? (Which would permit software decode, this will attempt hardware decode and fail.) >> >> Or maybe change the current configure test to drop support for VP9 in those versions entirely? Newer versions of libva including the field already existed when the first hardware which could do VP9 at all through this was released. >> >> - Mark > > Definitely make the first version with that field the minimum in that case. > The least amount of ifdeffery the better. Alternate version taking this approach. configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 21ec552..810e7ab 100755 --- a/configure +++ b/configure @@ -2689,7 +2689,7 @@ vp9_dxva2_hwaccel_deps="dxva2 DXVA_PicParams_VP9" vp9_dxva2_hwaccel_select="vp9_decoder" vp9_mediacodec_decoder_deps="mediacodec" vp9_mediacodec_hwaccel_deps="mediacodec" -vp9_vaapi_hwaccel_deps="vaapi VADecPictureParameterBufferVP9" +vp9_vaapi_hwaccel_deps="vaapi VADecPictureParameterBufferVP9_bit_depth" vp9_vaapi_hwaccel_select="vp9_decoder" wmv3_crystalhd_decoder_select="crystalhd" wmv3_d3d11va_hwaccel_select="vc1_d3d11va_hwaccel" @@ -5610,7 +5610,7 @@ check_type "windows.h d3d11.h" "ID3D11VideoContext" check_type "d3d9.h dxva2api.h" DXVA2_ConfigPictureDecode -D_WIN32_WINNT=0x0602 check_type "va/va.h" "VAPictureParameterBufferHEVC" -check_type "va/va.h" "VADecPictureParameterBufferVP9" +check_struct "va/va.h" "VADecPictureParameterBufferVP9" bit_depth check_type "va/va.h va/va_vpp.h" "VAProcPipelineParameterBuffer" check_type "va/va.h va/va_enc_h264.h" "VAEncPictureParameterBufferH264" check_type "va/va.h va/va_enc_hevc.h" "VAEncPictureParameterBufferHEVC"