From patchwork Mon Oct 17 19:16:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Behrisch X-Patchwork-Id: 1038 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.133 with SMTP id o127csp422182vsd; Mon, 17 Oct 2016 12:16:50 -0700 (PDT) X-Received: by 10.28.68.213 with SMTP id r204mr4283380wma.105.1476731810363; Mon, 17 Oct 2016 12:16:50 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id jc5si43236422wjb.204.2016.10.17.12.16.49; Mon, 17 Oct 2016 12:16:50 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 72CA968988C; Mon, 17 Oct 2016 22:16:45 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from lupus.uberspace.de (lupus.uberspace.de [95.143.172.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F0DA2680D34 for ; Mon, 17 Oct 2016 22:16:38 +0300 (EEST) Received: (qmail 30659 invoked from network); 17 Oct 2016 19:16:40 -0000 Received: from localhost (HELO ?IPv6:2a02:8109:8840:26f4:52b7:c3ff:fe52:caf3?) (127.0.0.1) by behrisch.lupus.uberspace.de with SMTP; 17 Oct 2016 19:16:40 -0000 From: Michael Behrisch To: ffmpeg-devel@ffmpeg.org References: <20161016212448.GA28223@kimiko.pkh.me> <0962f2bb-e5b3-2634-e784-685f4bc5042a@behrisch.de> <20161017030833.GY4602@nb4> <20161017080742.GA340907@phare.normalesup.org> <20161017110936.GB4602@nb4> <20161017133455.46a9157e@debian> <20161017132929.GC4602@nb4> Message-ID: <32628342-3331-eac1-7d85-ec80add64ed3@behrisch.de> Date: Mon, 17 Oct 2016 21:16:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161017132929.GC4602@nb4> X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] comma at the end of enumerator lists X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: >> On Mon, 17 Oct 2016 13:09:36 +0200 >> Michael Niedermayer wrote: >> >>> On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: >>>> Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : >>>>> probably, yes >>>> >>>> I would have said exactly the opposite. It is nothing but a waste of time >>>> and a pollution of the history. >>> >>> My idea here is to maximize the number of developers >>> And if in cases where one doesnt really care much either way and >>> someone else seems caring more one says, "ok" that may result in a happy >>> new contributor. >>> Saying "no" is more likely to turn someone away. >>> and again, it doesnt really matter if the , is there after a >>> final sentinel /count entry as no next field would ever be added >> >> Are you kidding me. Patches should be judged on their technical merrit, >> not whether you might piss someone off by rejecting it. > > this is about a cosmetic change having no real technical effect So here are my cosmetics for libavutil. It simply helps with keeping track of real warnings in downstream projects. Best regards, Michael diff -rup FFmpeg-master/libavutil/log.h FFmpeg/libavutil/log.h --- FFmpeg-master/libavutil/log.h 2016-10-17 19:47:57.000000000 +0200 +++ FFmpeg/libavutil/log.h 2016-10-17 20:30:38.545498875 +0200 @@ -44,7 +44,7 @@ typedef enum { AV_CLASS_CATEGORY_DEVICE_AUDIO_INPUT, AV_CLASS_CATEGORY_DEVICE_OUTPUT, AV_CLASS_CATEGORY_DEVICE_INPUT, - AV_CLASS_CATEGORY_NB, ///< not part of ABI/API + AV_CLASS_CATEGORY_NB ///< not part of ABI/API }AVClassCategory; #define AV_IS_INPUT_DEVICE(category) \ diff -rup FFmpeg-master/libavutil/pixfmt.h FFmpeg/libavutil/pixfmt.h --- FFmpeg-master/libavutil/pixfmt.h 2016-10-17 19:47:57.000000000 +0200 +++ FFmpeg/libavutil/pixfmt.h 2016-10-17 20:30:38.565499123 +0200 @@ -306,7 +306,7 @@ enum AVPixelFormat { AV_PIX_FMT_MEDIACODEC, ///< hardware decoding through MediaCodec - AV_PIX_FMT_NB, ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions + AV_PIX_FMT_NB ///< number of pixel formats, DO NOT USE THIS if you want to link with shared libav* because the number of formats might differ between versions }; #if AV_HAVE_BIGENDIAN @@ -401,7 +401,7 @@ enum AVColorPrimaries { AVCOL_PRI_SMPTEST428_1 = 10, ///< SMPTE ST 428-1 (CIE 1931 XYZ) AVCOL_PRI_SMPTE431 = 11, ///< SMPTE ST 431-2 (2011) AVCOL_PRI_SMPTE432 = 12, ///< SMPTE ST 432-1 D65 (2010) - AVCOL_PRI_NB, ///< Not part of ABI + AVCOL_PRI_NB ///< Not part of ABI }; /** @@ -427,7 +427,7 @@ enum AVColorTransferCharacteristic { AVCOL_TRC_SMPTEST2084 = 16, ///< SMPTE ST 2084 for 10-, 12-, 14- and 16-bit systems AVCOL_TRC_SMPTEST428_1 = 17, ///< SMPTE ST 428-1 AVCOL_TRC_ARIB_STD_B67 = 18, ///< ARIB STD-B67, known as "Hybrid log-gamma" - AVCOL_TRC_NB, ///< Not part of ABI + AVCOL_TRC_NB ///< Not part of ABI }; /** @@ -446,7 +446,7 @@ enum AVColorSpace { AVCOL_SPC_BT2020_NCL = 9, ///< ITU-R BT2020 non-constant luminance system AVCOL_SPC_BT2020_CL = 10, ///< ITU-R BT2020 constant luminance system AVCOL_SPC_SMPTE2085 = 11, ///< SMPTE 2085, Y'D'zD'x - AVCOL_SPC_NB, ///< Not part of ABI + AVCOL_SPC_NB ///< Not part of ABI }; #define AVCOL_SPC_YCGCO AVCOL_SPC_YCOCG @@ -458,7 +458,7 @@ enum AVColorRange { AVCOL_RANGE_UNSPECIFIED = 0, AVCOL_RANGE_MPEG = 1, ///< the normal 219*2^(n-8) "MPEG" YUV ranges AVCOL_RANGE_JPEG = 2, ///< the normal 2^n-1 "JPEG" YUV ranges - AVCOL_RANGE_NB, ///< Not part of ABI + AVCOL_RANGE_NB ///< Not part of ABI }; /** @@ -484,7 +484,7 @@ enum AVChromaLocation { AVCHROMA_LOC_TOP = 4, AVCHROMA_LOC_BOTTOMLEFT = 5, AVCHROMA_LOC_BOTTOM = 6, - AVCHROMA_LOC_NB, ///< Not part of ABI + AVCHROMA_LOC_NB ///< Not part of ABI }; #endif /* AVUTIL_PIXFMT_H */