From patchwork Wed May 24 00:45:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joseph Chris X-Patchwork-Id: 41809 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c51c:b0:10c:5e6f:955f with SMTP id gm28csp9689pzb; Tue, 23 May 2023 17:46:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ROJK2znQ5FzionzpyK/U3dZZx+Q/F2r46HKf6sbE42EPZ5GVBYgVaK60QUZ8hwYwZoFkc X-Received: by 2002:a17:907:6288:b0:969:b2e2:4f3b with SMTP id nd8-20020a170907628800b00969b2e24f3bmr14779505ejc.51.1684889176920; Tue, 23 May 2023 17:46:16 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id vu12-20020a170907a64c00b00965cd4ae2c7si524980ejc.232.2023.05.23.17.46.04; Tue, 23 May 2023 17:46:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@josephcz.xyz header.s=zmail header.b=ZBqJZnqQ; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=josephcz.xyz Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 82B0468C0DF; Wed, 24 May 2023 03:45:59 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE9EB6807A1 for ; Wed, 24 May 2023 03:45:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; t=1684889146; cv=none; d=zohomail.com; s=zohoarc; b=IT7L8YqLdwqafTQ1683ajR7XnRWDMfB+c67FTlwW6azl8Alt+Y/6NzqJn96bOSbnTHva9miG0tGVuGlSbp6M5Qq9gLaNNx2G/jgfHrBBNt40rG4tqt/WGqvASlIpqaHltcekg4or/NocdMgIo+WqZ9QCn0W+eiGhnkZFb7yNJx8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684889146; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=/jTqpUViQ8CLz4K0LQdYegQeQuO3kYKDstXHQy6LSSQ=; b=lDuhkG+5TrqTv+U8TNRp80n5Si7bzcpof5gAAqNWRt6/hLsG4tLDODCSNh+KS12fzyAM7MIwIrXhkh7TcTxYw62lhuCr2YL8neWMaNJkDv+N4hXwIqBeKSEFAHNtmD8x00Bpw8up8izr9crvovignl8feraFql7kRPB0weUed4s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=josephcz.xyz; spf=pass smtp.mailfrom=joseph@josephcz.xyz; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1684889146; s=zmail; d=josephcz.xyz; i=joseph@josephcz.xyz; h=Message-ID:Date:Date:MIME-Version:To:To:From:From:Subject:Subject:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=/jTqpUViQ8CLz4K0LQdYegQeQuO3kYKDstXHQy6LSSQ=; b=ZBqJZnqQ5gvwYs3dQ/U7WL697SqMeyx2/xO4Gr+JSg0xL9UkuHiX1K3n40e/Ezj/ RMMPq89VgUjUxrSyImrqYqgKyKV+wUXaeAPDfCgq4d3jCZVwCLwx5UHMp3zNZ1Y6DqY /h7z9Qda+FOQt7qxM6yalwtyFGgml0j0kUppTWjQ= Received: from [10.0.0.8] (071-095-033-172.res.spectrum.com [71.95.33.172]) by mx.zohomail.com with SMTPS id 1684889144530812.8006684485613; Tue, 23 May 2023 17:45:44 -0700 (PDT) Message-ID: <39118c1b-50b2-7d8b-4df8-ca7619ef3878@josephcz.xyz> Date: Tue, 23 May 2023 17:45:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: FFmpeg development discussions and patches Content-Language: en-US From: Joseph Chris X-ZohoMailClient: External Subject: [FFmpeg-devel] Request: consider use codec id "sowt" instead of "ipcm" for LPCM_S16LE in mp4 muxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: FwgFCfXFHcFA Hello, I am writing this mail for request consider use codec id "sowt" instead of "ipcm" for AV_CODEC_ID_PCM_S16LE in mp4 muxer, and AV_CODEC_ID_PCM_S16BE accordingly. This only needs a minor change on code: Many players like VLC and potplayer, can recognize "sowt", but they can not recognize "ipcm" or "lpcm" (lpcm is defined on mp4ra). Even ffmpeg it self (current git master, d81558) can't recognize it. So this change can improve compatibility and interoperability of ffmpeg. This change is related to #9219 and #10185. This change fails fate-mov-mp4-pcm but passes all other tests. fate-mov-mp4-pcm checks the MD5 of output file, as the codec id changes also makes the MD5 change. So we have to rewrite the test while changing the code. diff --git a/libavformat/movenc.c b/libavformat/movenc.c index a9c8e104f0..2b984789f5 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -7816,6 +7816,9 @@ static const AVCodecTag codec_mp4_tags[] = {      { AV_CODEC_ID_TTML,            MOV_MP4_TTML_TAG          },      { AV_CODEC_ID_TTML,            MOV_ISMV_TTML_TAG         }, +    // To improve compatibility +    { AV_CODEC_ID_PCM_S16BE,       MKTAG('t', 'w', 'o', 's') }, +    { AV_CODEC_ID_PCM_S16LE,       MKTAG('s', 'o', 'w', 't') },      /* ISO/IEC 23003-5 integer formats */      { AV_CODEC_ID_PCM_S16BE,       MOV_MP4_IPCM_TAG          },      { AV_CODEC_ID_PCM_S16LE,       MOV_MP4_IPCM_TAG          },