From patchwork Sun Sep 17 14:58:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5qGD5rqQ6ICB5bir?= X-Patchwork-Id: 5172 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.36.26 with SMTP id f26csp2605174jaa; Sun, 17 Sep 2017 07:58:41 -0700 (PDT) X-Google-Smtp-Source: AOwi7QA8QsoLtQuMTw0JlV5lwi1m7aJJus+vLU7hkqDJ7mSxRaRTjzYohNRHkFJqCz4Up/7UnxWb X-Received: by 10.28.178.12 with SMTP id b12mr6575288wmf.97.1505660321160; Sun, 17 Sep 2017 07:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505660321; cv=none; d=google.com; s=arc-20160816; b=ns2shTbjHyns1VK3BTAIJ44VDsdWYyfxzCwsnwpn3qdVKNcV/X07DQK871Vhq9q/rm JpGvgKwfPmyMZGU2Pss1niBh1zfygkPmoCTro+Sh2N6ePSUrsld396jgdKyTUdqohUa3 p9RUbDsVbSnY8X6KNFxUG90AZHQZ3A4VwNDLHZ8/mP06fRO6hYAl29ooS+FFlq8vZaw4 Q6dMsQSswly95ECDtznqAfJP1PAVQqa5iybI/wthw+wK8P+iBkAXduDMzPeHbdts0dmQ bYAyYRZ4E/cjaWewXvXIWnOgXqWMIBPdTaHoAY7uugPez2G0tqisufXAJsatpYwFrBEe ph/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to:date :message-id:mime-version:from:delivered-to :arc-authentication-results; bh=9wa68dsWU2YAeyh+kvmr+/i4fgPG1kG0T/VQssUzTmA=; b=neaObyg5lchmYY96/6Wgx038CPHCRKbjucWrV6BPST4VYm/0L++Sn/IYAfxPoYJVNh ZMaJHv2Vr+0+JocNnDqeV6whepnb0v5KHYmSgda6Tpe7D/phe8j1y3IAENmA/xwuk7FK h/aAUBPC+i9u6rZVmNEnrf3nL0dpzdOdZv1G6jiFP4nhBNtbZAtgBPel52BymjQqSqF2 maoaI50ZVcnr+Bz871i2vbWZBm0jcl7mEksnjMkYQnviLFlH+K7qWtklpWKna6l3j69P CFc9J3hGxQpR+QFjIoCWNqc7UFQ5OUhE/rZ5c8iI51e/j3Khsk4pNQFhpLiQo3TCuWSA 1+yQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=dream.jp Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c2si4353833wrf.530.2017.09.17.07.58.40; Sun, 17 Sep 2017 07:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=dream.jp Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0424D6882E2; Sun, 17 Sep 2017 17:58:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vsmtp02.cm2.dti.ne.jp (gw2.cm.dream.jp [59.157.133.2]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B62046882AE for ; Sun, 17 Sep 2017 17:58:22 +0300 (EEST) Received: from [192.168.1.3] (205.217.232.153.ap.dti.ne.jp [153.232.217.205]) by vsmtp02.cm2.dti.ne.jp (3.11v) with ESMTP AUTH id v8HEwRAp021331 for ; Sun, 17 Sep 2017 23:58:28 +0900 (JST) From: =?utf-8?B?5qGD5rqQ6ICB5bir?= Mime-Version: 1.0 (Mac OS X Mail 11.0 \(3445.1.6\)) Message-Id: <3DE198F6-FA9E-4880-BF3E-2FC26273323B@dream.jp> Date: Sun, 17 Sep 2017 23:58:27 +0900 To: ffmpeg-devel@ffmpeg.org X-Mailer: Apple Mail (2.3445.1.6) X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] Configure Script change request to support libcdio on macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hello, In fact, I'm not a kind of ffmpeg developer at all. While trying to link libcdio library with ffmpeg, I just happened to find out the way... So I'm not sure I can answer any question about this configure script change... I have tried to use libcdio function with ffmpeg on macOS. Then I get an information from libcdio team. That is ffmpeg configure script should read libcdio's pkgconfig file, libcdio.pc. So I tried and error, then found that the below change should be done to link libcdio library with ffmpeg on macOS. $ diff -u a/configure b/configure Please review it and make it acceptable for everyone... Best Regards, // Miya aka. TougenRoushi --- a/configure 2017-09-16 15:02:06.000000000 +0900 +++ b/configure 2017-09-17 04:53:34.000000000 +0900 @@ -6151,7 +6151,7 @@ if enabled libcdio; then check_lib libcdio "cdio/cdda.h cdio/paranoia.h" cdio_cddap_open -lcdio_paranoia -lcdio_cdda -lcdio || - check_lib libcdio "cdio/paranoia/cdda.h cdio/paranoia/paranoia.h" cdio_cddap_open -lcdio_paranoia -lcdio_cdda -lcdio || + require_pkg_config libcdio "cdio/paranoia/cdda.h cdio/paranoia/paranoia.h" cdio_cddap_open -lcdio_paranoia -lcdio_cdda -lcdio && check_lib libcdio "cdio/paranoia/cdda.h cdio/paranoia/paranoia.h" cdio_cddap_open -lcdio_paranoia -lcdio_cdda -lcdio || die "ERROR: No usable libcdio/cdparanoia found" fi