From patchwork Sat Mar 31 13:09:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JDQu9C10LrRgdCw0L3QtNGAINCn0LjRgNGP0YLRjNC10LI=?= X-Patchwork-Id: 8257 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp889734jad; Sat, 31 Mar 2018 11:07:06 -0700 (PDT) X-Google-Smtp-Source: AIpwx49LlMOHmOlmlgU3I+gi1AHxJTjIVE1az1fwmo/vaCinYFnI5oYwF+BULkCiB7pX6tx6rN/n X-Received: by 10.28.124.24 with SMTP id x24mr5522770wmc.6.1522519626096; Sat, 31 Mar 2018 11:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522519626; cv=none; d=google.com; s=arc-20160816; b=Kt3rsMjsTQOuN8vQaosczkytNtZdzA1zk15cFn71tFRUvsfFWdjXldEPRP+l2zi2aZ g6LCi2PPVzusUK9U8VmX9Wm/A9fLrXHvcRW5bPOCbSvp2Kv4rzNq9BfEwufdoNNC3aid qKXyWBVZ7JJqOcSY6uVj/WKoHZHGcIHnejrfj6BDqDbwYWe1Mu1QmQrvs8waplxjuiTr XiLa+g8ei9uBswSvIdIACm6cLDfxC8u5pXqFLNjHAVpflEArjB3uGJrdqG79GEVTmz3q iNnXodBH/KPhnzwclJ/2R+DfyEgS/3DZBzKmSY/uJqB/sjM488O+BfcFtt4LVQqJhUfx Wg/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:mime-version:user-agent:date:message-id:from:to :dkim-signature:delivered-to:arc-authentication-results; bh=8T3/z8ieXdQ4XOd3RDoVIS+bsy3bA9f7TTXrwSEwNWI=; b=p07WO+aS3MQ6oEMlgbNLkVKSW+aaMAAD7SxbdS2cCiqc7kQ0yH7ZRW+QdkYBKUngCB dexldxrIqdYZwh5fH6Bl7FUDW3iTAEiduZh+M76Tjkicn7GE/utd4NhaAaXKsudyxaTV kCug/PhGg0zP5MrImqyuMEOouVHVxgs4j7AaS2iQJLtO9IRi7npWl6V6BD9QXAdkAgw/ GUkEBvj2QWRMOKB+NyycbOEV9gWiLiNaF6t6qxjkk1KHaUBQij9f8ugafcPBUvXTCqoq JhVyE3rMdnwnVR3bIrWISc2vt3MsfR5oCxK8bEwtO+hpezT037n4s6MkqECKa4btqHkV YswQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ngs.ru header.s=mail1 header.b=C3hNKPcW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=REJECT sp=REJECT dis=QUARANTINE) header.from=ngs.ru Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 44si8753979wrl.258.2018.03.31.11.07.04; Sat, 31 Mar 2018 11:07:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ngs.ru header.s=mail1 header.b=C3hNKPcW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=REJECT sp=REJECT dis=QUARANTINE) header.from=ngs.ru Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 82075689CD4; Sat, 31 Mar 2018 21:06:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpout.ngs.ru (smtpout23.ngs.ru [195.19.71.6]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 61668689925 for ; Sat, 31 Mar 2018 16:09:20 +0300 (EEST) Received: from [10.1.10.81] (unknown [195.208.147.138]) (Authenticated sender: heimdallr@ngs.ru) by mail.ngs.ru (smtp) with ESMTPA id A7552201D63 for ; Sat, 31 Mar 2018 20:09:36 +0700 (+07) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ngs.ru; s=mail1; t=1522501778; bh=AO1iIM7OlJxGEVrZMeeNMYB6JeIlaQKfN45ydn04XCg=; l=2680; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type; b=C3hNKPcWOGUyWaplzg61kDqCKI7Fh/0Bje0d9EJ8JYL2jZ4pUTGlk7HB4Ynk4Z/tW WZTnO3YHyedLNQ0wyOpWoZDvTettn805fv45VqyQqP1eePxthzMfxbZ0uSyPZhgts2 UWHqLNemd7d4vCBuJvgYxy+5e8IHd0TkRW3OxLt0= To: ffmpeg-devel@ffmpeg.org From: =?UTF-8?B?0JDQu9C10LrRgdCw0L3QtNGAINCn0LjRgNGP0YLRjNC10LI=?= Message-ID: <3d6b0130-2135-5c20-b934-2b09cb5d20db@ngs.ru> Date: Sat, 31 Mar 2018 20:09:38 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Language: ru X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 123092 [Mar 31 2018] X-KLMS-AntiSpam-Version: 5.7.102.0 X-KLMS-AntiSpam-Envelope-From: heimdallr@ngs.ru X-KLMS-AntiSpam-Rate: 55 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Info: LuaCore: 118 118 1d3ca9104b311f1f878f20ec1484836dccfbc23a, {Tracking_mailer_too_long, mailerh2}, {relay has no DNS name}, d41d8cd98f00b204e9800998ecf8427e.com:7.1.1; 127.0.0.199:7.1.2; ngs.ru:4.0.3,4.0.4,7.1.1, Auth:dmarc=fail header.from=ngs.ru policy=reject; spf=softfail smtp.mailfrom=ngs.ru; dkim=none, DmarcAF: none, {rdns complete}, dmarc_local_policy_1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: not scanned, disabled by settings X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.705, not scanned, license restriction X-Virus-Scanned: clamav-milter 0.98.6 at mc-filter2 X-Virus-Status: Clean X-Mailman-Approved-At: Sat, 31 Mar 2018 21:06:42 +0300 Subject: [FFmpeg-devel] [PATCH] bug in avcodec_find_best_pix_fmt_of_list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hello! Let me propose to review my patch for avcodec_find_best_pix_fmt_of_list. It's very old bug. Here is example: AVPixelFormat pixFmts[] = { AV_PIX_FMT_RGB24, AV_PIX_FMT_RGBA }; int loss = 0; AVPixelFormat best_fmt = avcodec_find_best_pix_fmt_of_list(pixFmts, AV_PIX_FMT_BGRA, 1, &loss); Now best_fmt is AV_PIX_FMT_RGB24. But AV_PIX_FMT_RGBA is better. Regards, Alexander Chiryatev. From 4e9caf7d208a6de065ba0ee9f164ccf577fb7e89 Mon Sep 17 00:00:00 2001 From: heimdallr Date: Sat, 31 Mar 2018 19:37:23 +0700 Subject: [PATCH] bug in avcodec_find_best_pix_fmt_of_list example: AVPixelFormat pixFmts[] = { AV_PIX_FMT_RGB24, AV_PIX_FMT_RGBA }; int loss = 0; AVPixelFormat best = avcodec_find_best_pix_fmt_of_list(pixFmts, AV_PIX_FMT_BGRA, 1, &loss); best is AV_PIX_FMT_RGB24. But AV_PIX_FMT_RGBA is better. --- libavcodec/imgconvert.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c index 1547f18966..7b0005b308 100644 --- a/libavcodec/imgconvert.c +++ b/libavcodec/imgconvert.c @@ -69,10 +69,14 @@ enum AVPixelFormat avcodec_find_best_pix_fmt_of_list(const enum AVPixelFormat *p int i; enum AVPixelFormat best = AV_PIX_FMT_NONE; + int loss; - for(i=0; pix_fmt_list[i] != AV_PIX_FMT_NONE; i++) - best = avcodec_find_best_pix_fmt_of_2(best, pix_fmt_list[i], src_pix_fmt, has_alpha, loss_ptr); + for (i=0; pix_fmt_list[i] != AV_PIX_FMT_NONE; i++) { + loss = *loss_ptr; + best = avcodec_find_best_pix_fmt_of_2(best, pix_fmt_list[i], src_pix_fmt, has_alpha, &loss); + } + *loss_ptr = loss; return best; }