From patchwork Tue May 8 00:30:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 8859 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:155:0:0:0:0:0 with SMTP id c82-v6csp3437708jad; Mon, 7 May 2018 17:30:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZojTqDuHirgvW+FR7mK3zYFzdSfQ0qoJGyOF1djXvZ8eqvn886zbGTy7TpB8O6PITptliWu X-Received: by 2002:adf:b88f:: with SMTP id i15-v6mr29345119wrf.163.1525739423892; Mon, 07 May 2018 17:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525739423; cv=none; d=google.com; s=arc-20160816; b=BrRgvUqawF4IhudWW6pd+79ja6u1FqAu5373pd0l5Xh0jPnTZLHQkBQA6R9+2A8qgc RUEyKrORByMAyaoYITCj54cAMmgxJ4QmnE7pdAz9zkalCe0Tpu/Z1pslU16LGGFabrX2 SqXZfNM5l7FF2mv0ij/DKIDLObtC3DxlGxgb6tYJgd3j23/mRWEz05zVK7q/3WYua3lM IgWahRuAJ2hU6Nozi0ftQhb8A3334X33+GaY5sfgijFjCVHmr3T0vA8ExyM3ahUYn5n6 /HHZB7NOzQFo5BveHqagM5js3vgz0GLwDZO2BNYXxieKL1Xmxj/FdlDMWQZfPzJITs7W WrVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:dkim-signature :delivered-to:arc-authentication-results; bh=dks9uJbybUfNPb9loW3PS3TXRfKR3g+J9hb8mNmY27Q=; b=CBHYAp5P7gAOMmx75JEq9eKdeCH2+Y5iOW3+J1QJHF4LVhYzR2ljEg40EwV39OvEJ6 Hy/2FkC6jsW+zQuGoptAwf429h53w13OwVk/iKyxEQ4+gADsb47wckGwb63uI0CPmYoY Crfwi6IX2SVFfOkb+DnvAVJWDPNfMmClYrnfJHVsXmTnrFzPXmS/UoVDDvujRhKr9ger rWeilXpU/IH2ZyFZgjaBek9NnlGu8ZmswqPUmf3LxI7EL5OBXzdrRReTCPGMWyGQnJSe +Et3qPyPTEe4fph94OuEO/yQL2QDnvcEN/pCLu1g96/0158JALXpAMbJWrfIWo4yvSer mHqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=ak65IRex; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id p10-v6si13686504wrb.296.2018.05.07.17.30.14; Mon, 07 May 2018 17:30:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@jkqxz-net.20150623.gappssmtp.com header.s=20150623 header.b=ak65IRex; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F488689960; Tue, 8 May 2018 03:29:37 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4217A6891D9 for ; Tue, 8 May 2018 03:29:30 +0300 (EEST) Received: by mail-wm0-f41.google.com with SMTP id a137-v6so17053317wme.1 for ; Mon, 07 May 2018 17:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=QIjJ4fu2XABBCkrviHF7TyIEdn9WD6JsfdJj8KcmcPo=; b=ak65IRexnWJOQPU9Ws20Ds5ouAzDAlagkJAXrwjCrOWESKfxdxmyYF237uqUcuTw+X iQFMoPGZMaYxRtZ15Id25eUX+1zxUKOxByHYea9XldOH7dTtr4OsOk6mcDFs4NJcgu14 Ns4ZfkWOmaPwLRuElLEpC+7M/QIM5rTTktaX2jA/5KATBm5OusJgK86neL3xlIyvmcuH 8ydWS4FR80OVGcAW+PbuMRB3bwrItsZ9J2fo7CvX0CEX0vbMG/bKE7zDw/vp3DBBfZJh XGYKYpimWRmXcFrm8COZ6esfsXYgz/Imq2JsYrwtjoP4stugfgHTn+21bqMjhD3GoPi3 YSHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QIjJ4fu2XABBCkrviHF7TyIEdn9WD6JsfdJj8KcmcPo=; b=bXcsqBOO8eg5hq9JMO8vMkADoMPc0OtChPbi4edCzuHD7TTyaHE2gr772e6/45Zf31 N5zAlQY0rQhW37AYZW4AnRB2oEInB3TeUz8DHB9WXv1RXkZ1GOxdgnF3namhJJb69XbN oYEdLTKCuLJs1gNpdFFrC98DHUsERkz6BbffmR8OcrdQcRMpg8X82MpVFtcmfwk2RTCE p5wfx5tV5qZxRe+/x3noCk4MD7D1GeQjSZz4w6clt2FdLv9ROinF2cFEZkLCQRWaKtkw J7PXfWeB1rodWGPvtpt48Mn3Pcv/+rYcSEo8WVJZr6RHx5YHtTfy41+Zt+F6lSfvrMvo bRSw== X-Gm-Message-State: ALKqPwcF27yx+ORtUJDBE31Gsas+g1M0WXW+zX/L2XcRLWmnZ7bLwcRX mYyE6bFflpq0iqMZ21PBlByYX6eU X-Received: by 10.28.170.84 with SMTP id t81mr2015875wme.130.1525739405351; Mon, 07 May 2018 17:30:05 -0700 (PDT) Received: from [192.168.0.3] (cpc91242-cmbg18-2-0-cust650.5-4.cable.virginm.net. [82.8.130.139]) by smtp.gmail.com with ESMTPSA id t196-v6sm8346683wme.11.2018.05.07.17.30.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 17:30:04 -0700 (PDT) To: ffmpeg-devel@ffmpeg.org References: <20180507231131.29840-1-sw@jkqxz.net> <20180507231131.29840-6-sw@jkqxz.net> <5a791000-1f5a-f493-55d8-c732dfc34a75@gmail.com> From: Mark Thompson Message-ID: <45ce6c28-9721-c2fc-3ea1-081f744e2ab6@jkqxz.net> Date: Tue, 8 May 2018 01:30:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <5a791000-1f5a-f493-55d8-c732dfc34a75@gmail.com> Content-Language: en-US Subject: Re: [FFmpeg-devel] [PATCH 6/6] fate/cbs: Add an SEI test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 08/05/18 01:06, James Almer wrote: > On 5/7/2018 8:11 PM, Mark Thompson wrote: >> The artificial sample file sei-1.h264 contains five frames (IDR P B I B) >> and the following SEI message types: >> * Buffering period >> * Picture timing >> * Pan-scan rectangle (display as 4:3) >> * User data registered, containing A/53 closed captions (captions match >> frame content, including reordering) >> * Recovery point (at the I frame) >> * Display orientation (identity transformation) >> * Mastering display (with arbitrary contents) >> * Undefined SEI type 1234 (containing ascending bytes) >> --- >> Sample file at . (Named -1 anticipating the possibility of adding more in future.) >> >> 140ddba635960ac73935a0fb268748a43c647151 fate/h264/sei-1.h264 > > If you crafted this file using the mastering display implementation from > patch 5/6 then you may need to create it again with the fixed element sizes. It didn't change because the numbers I had there were < 2^16, but I've regenerated anyway with a larger number as max so that it does get tested. b8f3b5443c8e437a83d36a72657478529c2afcfc fate/h264/sei-1.h264 >> >> >> tests/fate/cbs.mak | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak >> index bee349ed45..911e7704aa 100644 >> --- a/tests/fate/cbs.mak >> +++ b/tests/fate/cbs.mak >> @@ -14,7 +14,7 @@ endef >> >> # H.264 read/write >> >> -FATE_CBS_H264_SAMPLES = \ >> +FATE_CBS_H264_CONFORMANCE_SAMPLES = \ >> SVA_Base_B.264 \ >> BASQP1_Sony_C.jsv \ >> FM1_BT_B.h264 \ >> @@ -30,7 +30,11 @@ FATE_CBS_H264_SAMPLES = \ >> CVSE2_Sony_B.jsv \ >> CABACI3_Sony_B.jsv >> >> -$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264))) >> +FATE_CBS_H264_SAMPLES = \ >> + sei-1.h264 >> + >> +$(foreach N,$(FATE_CBS_H264_CONFORMANCE_SAMPLES),$(eval $(call FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264))) >> +$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call FATE_CBS_TEST,h264,$(basename $(N)),h264/$(N),h264))) > > Missing ref files? Or it doesn't generate them? Missed, sorry: >> >> FATE_CBS_H264-$(call FATE_CBS_DEPS, H264, H264, H264, H264, H264) = $(FATE_CBS_h264) >> FATE_SAMPLES_AVCONV += $(FATE_CBS_H264-yes) >> Thanks, - Mark diff --git a/tests/ref/fate/cbs-h264-sei-1 b/tests/ref/fate/cbs-h264-sei-1 new file mode 100644 index 0000000000..2d1cb1fe7f --- /dev/null +++ b/tests/ref/fate/cbs-h264-sei-1 @@ -0,0 +1 @@ +5f537551b7dfab76a172f1aebb028986