diff mbox

[FFmpeg-devel] tiff: fix leaking yuv_line

Message ID 4c3cd1d8-0ccd-b668-3ff7-b22efbbde584@googlemail.com
State Superseded
Headers show

Commit Message

Andreas Cadhalpun Feb. 15, 2017, 11:23 p.m. UTC 
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
---
 libavcodec/tiff.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Niedermayer Feb. 16, 2017, 2:15 a.m. UTC | #1 
On Thu, Feb 16, 2017 at 12:23:28AM +0100, Andreas Cadhalpun wrote:
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
> ---
>  libavcodec/tiff.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index efbd9791a5..474ea90015 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -1386,6 +1386,7 @@ static av_cold int tiff_end(AVCodecContext *avctx)
>  
>      ff_lzw_decode_close(&s->lzw);
>      av_freep(&s->deinvert_buf);
> +    av_freep(&s->yuv_line);
>      return 0;

I assume we are missing a test in fate for the yuv case
adding such test would be usefull

yuv_line_size should be reset to 0, not sure its ever needed but it
feels more proper

thx

[...]
diff mbox

Patch

diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index efbd9791a5..474ea90015 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -1386,6 +1386,7 @@  static av_cold int tiff_end(AVCodecContext *avctx)
 
     ff_lzw_decode_close(&s->lzw);
     av_freep(&s->deinvert_buf);
+    av_freep(&s->yuv_line);
     return 0;
 }