From patchwork Mon Sep 4 21:58:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=C3=A9r=C3=A9my_Demeule?= X-Patchwork-Id: 43548 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4f16:b0:149:dfde:5c0a with SMTP id gi22csp1469133pzb; Mon, 4 Sep 2023 14:58:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHnRl57paWQkZASolgtSw1BjkDBa9UqmEgv96uvhyNEQ6lfc/xhn3MqbOJQlm5lvMhBVIw X-Received: by 2002:a05:6512:e9d:b0:4fc:df79:3781 with SMTP id bi29-20020a0565120e9d00b004fcdf793781mr9343446lfb.66.1693864716135; Mon, 04 Sep 2023 14:58:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693864716; cv=none; d=google.com; s=arc-20160816; b=YX5vEc+gKgGdxs66/MCXg5lDmjld7pzxnINQgkBsXCAy9PncPbg0MAUDNwE5H+jPSR MbN5w3YTGFG6cnjy4nwN8lwJGoJAa7ZMz4VtJkyS44wQkL1iiadA/Xyh7IVPjrL25CrW v6WStpFpoNq3GQSbyiQseF7cRh1GSf6g0Phb6g8hDyKgLgppL4UAIQVLnJztv9PGg1BR 4WAB9VYDZKVcWt0VBBZYNuoRnZjghTSzrNXAQC+l+t94MEWNWe8qGwvfpWJhTMuFPvvg t+ZDcQOd3kXrFZVdgH9NAAYzZpmdYE8BGDCYsbBK9gSju3HkkX+DGchPCajW/URy6u18 UGcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:date:message-id:mime-version:from :dkim-signature:delivered-to; bh=O8GuJPZhN05Y+v6aL9s8/Chvsba0yzbBTSDTwMo+pZY=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=YpSZWMo7B+odprb8SIVLmCemGZrVIcJJZ6fmtDa7OWZMwiv/fimTpuatIZEKNKJ+Gb 3WU3Y8nDAvLPubpAjhbhgwGdB1lLZxfO79OKbT9hHn+WxmUg4VPIP/ExO+k4wB+3Jj95 KDi1BDMoreDALkfcRT/9WYymzF69iW7gluKr9mXhqcrC2JZbnH/izLdEWxLJO2iQQHrA qdXHq6UTVCgx5u6ZVBEQWK6we44JCoUrAAHwu7BYKHB49CPPlrr32WaRUk4uDkDoObA6 EqH4lst5Tho90oaHU5i0LVuMMg/a25kBZQbiFxha6EZH5SWwfba5jccbxu9ocmfeH56w 29Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=PbjQgZtV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dk24-20020a170906f0d800b009a5f1d1563fsi6699872ejb.809.2023.09.04.14.58.35; Mon, 04 Sep 2023 14:58:36 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20221208 header.b=PbjQgZtV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F0C068C7BA; Tue, 5 Sep 2023 00:58:32 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF64E68C66B for ; Tue, 5 Sep 2023 00:58:25 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-401b3ea0656so17932075e9.0 for ; Mon, 04 Sep 2023 14:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693864705; x=1694469505; darn=ffmpeg.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=na3SfgV/HJXr5t7Iso8XlJrkbzSMKttbzhxh7Sdyu/s=; b=PbjQgZtVygp5U2wTm1jW1wuO9WNAE6BhXUYyOnADKhUhFROQWYlKRCnn4DUuKFLu+/ HpW+GKb0QH9Ac0OsbUHJxf/FDNkRct1gpUeXU+GLPwz+M4L/lLqwEGeWi2n+/yeE149p Wc/4pQKX3K47HTilW+zXWE+CQUDsKGo9u/qLWhtFD3vAqNar9VkdLOmr+gE6j2NMl2+e klTW2KPkVNpLnBWZO+8JDygJpwm3WKPHD3UiwoXx6hQiTUK+rKVqhF3teZj/XEO9V856 H49QA6gI9LEgchkWvSNICRt+7/mxBR5dL69CCwk6Hjqy5NQARcdbqehtSiczTdz8lUE8 GTvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693864705; x=1694469505; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=na3SfgV/HJXr5t7Iso8XlJrkbzSMKttbzhxh7Sdyu/s=; b=CFB7boI2OgL1xI864Xby5EMT2H2b2uPR3HE3mkmJTbyWxgXMILHmJkN3SFAPVmL2Ol geZXCe5eCeF1AWWQl7Fsc1oPnozya9HosUI3FXNbRgVwIx6gse9sZv9pubZuc0824Z9P RT3hddIv7MjSlqESEgdQXFS3EzxdVVbYo8v76551WV+nQxrCWMto5lRc00nxAeQsrUOM BhFFtEKiFZw1elX6s+TX9BfeeVGt739Bis8zlVT07OI1QcG8aKLU8l1Pqq/g3a/0Pslu 8lpMm0BpM+21Atay42bqiZoXFL2HBh4eIxbZ/Ormy1C2mKuw0dpmVsXGRASQkBuUtzwE 365A== X-Gm-Message-State: AOJu0YxiGyLRQimM0G6AKlYupckzuLyDR2aEIj4Q/UIqKRchg625X9Dx POdwKQJXjeDjo10LmJCtmR67B3ZHXTM= X-Received: by 2002:a1c:770e:0:b0:3fe:173e:4a34 with SMTP id t14-20020a1c770e000000b003fe173e4a34mr8218152wmi.40.1693864704520; Mon, 04 Sep 2023 14:58:24 -0700 (PDT) Received: from smtpclient.apple ([2a01:e0a:1de:f9c0:811e:2988:1b3a:45ad]) by smtp.gmail.com with ESMTPSA id q13-20020a7bce8d000000b003fe4548188bsm18356012wmj.48.2023.09.04.14.58.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2023 14:58:24 -0700 (PDT) From: =?utf-8?q?J=C3=A9r=C3=A9my_Demeule?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Message-Id: <5B54A9AC-BC65-4159-8CE4-B3A1214A8454@gmail.com> Date: Mon, 4 Sep 2023 23:58:13 +0200 To: ffmpeg-devel@ffmpeg.org X-Mailer: Apple Mail (2.3731.200.110.1.12) Subject: [FFmpeg-devel] [PATCH] metal: Add hint to select low power device instead of the default one X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: UaVTq5wuoAdH SDL >= 2.28.3 introduce a renderer hint to allow selection of low-power device on default macOS backend (i.e. metal). On some system like MacBook Pro Intel with AMD card, asking for the default device will always return the AMD GPU. This is not an issue for 99% of the case when the renderer context is here to provide the maximum performance level like for game. However, for video application using GPU for 1 quad and 1 texture, using the discrete GPU for that lead to an important power consumption (4 to 8W), heat increase, and fan noise. With this patch, ffplay will use the integrated GPU (i.e. the Intel one), instead of the discrete GPU (i.e. the AMD one). Signed-off-by: Jérémy Demeule --- fftools/ffplay.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 5212ad053e..e766d502a8 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -3712,6 +3712,9 @@ int main(int argc, char **argv) #endif window = SDL_CreateWindow(program_name, SDL_WINDOWPOS_UNDEFINED, SDL_WINDOWPOS_UNDEFINED, default_width, default_height, flags); SDL_SetHint(SDL_HINT_RENDER_SCALE_QUALITY, "linear"); +#if SDL_VERSION_ATLEAST(2,28,3) + SDL_SetHint(SDL_HINT_RENDER_METAL_PREFER_LOW_POWER_DEVICE, "true"); +#endif if (window) { renderer = SDL_CreateRenderer(window, -1, SDL_RENDERER_ACCELERATED | SDL_RENDERER_PRESENTVSYNC); if (!renderer) {