diff mbox

[FFmpeg-devel] avformat/segafilmenc - set keyframe bit correctly

Message ID 5e802c56-bce7-8904-6f87-248c215ce5de@gmail.com
State Accepted
Commit 0683ad709b0eafc6e863612e5f80784efaf0e04e
Headers show

Commit Message

Gyan May 6, 2018, 4:53 a.m. UTC 
On 5/6/2018 4:39 AM, James Almer wrote:
> On 5/5/2018 8:06 PM, Michael Niedermayer wrote:
>> On Sat, May 05, 2018 at 05:16:09PM +0530, Gyan Doshi wrote:
>>> Since the muxer author hasn't made the change, the patch is submitted.
>>>
>>> Reference:
>>>
>>> http://www.ffmpeg.org/pipermail/ffmpeg-devel/2018-April/228602.html
>>
> 
> A micro bump should be enough.

Micro version bumped.
From 1d84745b8a7131523c89c46de70666d56684cb69 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg@gyani.pro>
Date: Sat, 5 May 2018 17:04:53 +0530
Subject: [PATCH] avformat/segafilmenc - set keyframe bit correctly

As per
https://web.archive.org/web/20020803104640/http://www.pcisys.net:80/~melanson/codecs/film-format.txt,

the top bit of the info1 chunk is set as 1 for inter-coded frames and 0
otherwise.
---
 libavformat/segafilmenc.c | 2 +-
 libavformat/version.h     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Gyan May 7, 2018, 5:14 p.m. UTC | #1 
On 5/6/2018 10:23 AM, Gyan Doshi wrote:
> 
> 
> On 5/6/2018 4:39 AM, James Almer wrote:
>> On 5/5/2018 8:06 PM, Michael Niedermayer wrote:
>>> On Sat, May 05, 2018 at 05:16:09PM +0530, Gyan Doshi wrote:
>>>> Since the muxer author hasn't made the change, the patch is submitted.
>>>>
>>>> Reference:
>>>>
>>>> http://www.ffmpeg.org/pipermail/ffmpeg-devel/2018-April/228602.html
>>>
>>
>> A micro bump should be enough.
> 
> Micro version bumped.

Will push tomorrow.
diff mbox

Patch

diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c
index 5b0d7e69e8..524230e461 100644
--- a/libavformat/segafilmenc.c
+++ b/libavformat/segafilmenc.c
@@ -69,7 +69,7 @@  static int film_write_packet_to_header(AVFormatContext *format_context, FILMPack
         info1 = pkt->pts;
         info2 = pkt->duration;
         /* The top bit being set indicates a key frame */
-        if (pkt->keyframe)
+        if (!pkt->keyframe)
             info1 |= (1 << 31);
     }
 
diff --git a/libavformat/version.h b/libavformat/version.h
index e589d77798..49e40e9494 100644
--- a/libavformat/version.h
+++ b/libavformat/version.h
@@ -33,7 +33,7 @@ 
 // Also please add any ticket numbers that you believe might be affected here
 #define LIBAVFORMAT_VERSION_MAJOR  58
 #define LIBAVFORMAT_VERSION_MINOR  13
-#define LIBAVFORMAT_VERSION_MICRO 101
+#define LIBAVFORMAT_VERSION_MICRO 102
 
 #define LIBAVFORMAT_VERSION_INT AV_VERSION_INT(LIBAVFORMAT_VERSION_MAJOR, \
                                                LIBAVFORMAT_VERSION_MINOR, \