| Message ID | 659a2a72-2d4f-7fa1-8665-595b675fb136@carpalis.nl |
|---|---|
| State | Accepted |
| Commit | fac5849915973ac09286d2c027237bfd99cc27fe |
| Headers | show |
On Sun, May 20, 2018 at 01:45:56PM +0200, Jerome Borsboom wrote: > If v->fieldtx_is_raw is not reset to zero, it may spill over from a previous > interlaced frame I/BI picture. > > Signed-off-by: Jerome Borsboom <jerome.borsboom@carpalis.nl> > --- > This may address the concerns. Will make a mental note to clean up the parser > at a later time. > > Thank you for the review. will apply thanks [...]
diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index 949fec6bee..98b24e8e57 100644 --- a/libavcodec/vc1.c +++ b/libavcodec/vc1.c @@ -1010,7 +1010,8 @@ int ff_vc1_parse_frame_header_adv(VC1Context *v, GetBitContext* gb) return -1; av_log(v->s.avctx, AV_LOG_DEBUG, "FIELDTX plane encoding: " "Imode: %i, Invert: %i\n", status>>1, status&1); - } + } else + v->fieldtx_is_raw = 0; status = bitplane_decoding(v->acpred_plane, &v->acpred_is_raw, v); if (status < 0) return -1;
If v->fieldtx_is_raw is not reset to zero, it may spill over from a previous interlaced frame I/BI picture. Signed-off-by: Jerome Borsboom <jerome.borsboom@carpalis.nl> --- This may address the concerns. Will make a mental note to clean up the parser at a later time. Thank you for the review. libavcodec/vc1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)