From patchwork Fri Feb 17 01:05:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Cadhalpun X-Patchwork-Id: 2588 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp2754154vsb; Thu, 16 Feb 2017 17:05:17 -0800 (PST) X-Received: by 10.28.88.6 with SMTP id m6mr133124wmb.4.1487293517786; Thu, 16 Feb 2017 17:05:17 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 17si164809wmu.159.2017.02.16.17.05.17; Thu, 16 Feb 2017 17:05:17 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A744068973B; Fri, 17 Feb 2017 03:05:08 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 86680680B01 for ; Fri, 17 Feb 2017 03:05:02 +0200 (EET) Received: by mail-wm0-f66.google.com with SMTP id v77so158986wmv.0 for ; Thu, 16 Feb 2017 17:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to; bh=yLiz/qairBYVwp2bXAVcxuB5pYmGGxMMhW1cC0kXpeI=; b=kNWxXMpR/Y5GqxeBIg5F4vN2HcQ3oKDYtWvjTYWKgQbddLYc/JvpIWzZj8lTFJ5JDR EXmqgLnCillEv9z9QEL9Jp/sO/MXHU7dIl1oQcE+tJFfSxuHcLCYoqu6o5wpkt7ceZBx s2rVCBEF625NvyaRTvT9opzt0nBF8daMeKgz/2KpdcIzrh+ZpzJidfgx5IxBFPBVDsIy 4Y9AA38dANaw38YHO5c0mAnVzzXRb/RUUOh/nT9RbhXwIHr5/TyihFDnZN4PFSs8/ceW Wd1isv7ulbHDZtvvny53hMbVMyHROvN8bQeIWAdo/pNgrmmhFI65xt7OIaK/F5F4dIiO AZsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to; bh=yLiz/qairBYVwp2bXAVcxuB5pYmGGxMMhW1cC0kXpeI=; b=mxJO4y/6JG0EdL+brUm5brEWL1nA7JTxUTeJQxHg2bLbjGMnlY9hjXvLvO3cT0f5hb kjxf/ejop3q+pSi+0d0uGSi1nLUniQ0UiLj58vJRXOjqE3nazQeMGlS+jB7+1yXyQw9y llNC+Rd3IVJt/8+gLzPTGNXAl8Y82PzA+zVwrMtlfFR9CM/k1fbWtwWk87iUIn0x1qgk TqXqzJhwkHNsMVjig6FqnjSxhtB5ifHgRPOKN6559Z6CXfcLTiBLSG9o4aZcY0QnxjJO 13FRnRL2s3cgF/uIGnSW8EjQXejILTnOA4ArpRhaf6X/dnmTiEQVt91+mU2QSVYjNuFr Uw3g== X-Gm-Message-State: AMke39nXaB39r4hqQJYOA+IQvTiq/V8xk8FccDVfF55hVEQzJ0Ie/86U55SSFpuT6nzh5g== X-Received: by 10.28.196.2 with SMTP id u2mr106493wmf.109.1487293508515; Thu, 16 Feb 2017 17:05:08 -0800 (PST) Received: from [192.168.2.21] (p5B095E61.dip0.t-ipconnect.de. [91.9.94.97]) by smtp.googlemail.com with ESMTPSA id 186sm148969wmw.24.2017.02.16.17.05.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 17:05:07 -0800 (PST) From: Andreas Cadhalpun X-Google-Original-From: Andreas Cadhalpun To: ffmpeg-devel@ffmpeg.org References: <4c3cd1d8-0ccd-b668-3ff7-b22efbbde584@googlemail.com> <20170216021535.GD5776@nb4> Message-ID: <6621eb3e-0b84-6a61-da31-eb2c78b23607@googlemail.com> Date: Fri, 17 Feb 2017 02:05:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170216021535.GD5776@nb4> Subject: Re: [FFmpeg-devel] [PATCH] tiff: fix leaking yuv_line X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 16.02.2017 03:15, Michael Niedermayer wrote: > On Thu, Feb 16, 2017 at 12:23:28AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/tiff.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c >> index efbd9791a5..474ea90015 100644 >> --- a/libavcodec/tiff.c >> +++ b/libavcodec/tiff.c >> @@ -1386,6 +1386,7 @@ static av_cold int tiff_end(AVCodecContext *avctx) >> >> ff_lzw_decode_close(&s->lzw); >> av_freep(&s->deinvert_buf); >> + av_freep(&s->yuv_line); >> return 0; > > I assume we are missing a test in fate for the yuv case > adding such test would be usefull Indeed, I'll send a patch adding one. > yuv_line_size should be reset to 0, not sure its ever needed but it > feels more proper It's in the close function, so it's unlikely to be needed, but I added it now anyway. Updated patch is attached. Best regards, Andreas From c9a5c531c1d0434c989998eab6cb1ac352200695 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Thu, 16 Feb 2017 00:07:24 +0100 Subject: [PATCH] tiff: fix leaking yuv_line Signed-off-by: Andreas Cadhalpun --- libavcodec/tiff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index efbd9791a5..650a9d89ef 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1386,6 +1386,8 @@ static av_cold int tiff_end(AVCodecContext *avctx) ff_lzw_decode_close(&s->lzw); av_freep(&s->deinvert_buf); + av_freep(&s->yuv_line); + s->yuv_line_size = 0; return 0; } -- 2.11.0