| Message ID | 67939932c67d883bd62b5c0fa9c38dc172e3da44.1648013166.git.pross@xvid.org |
|---|---|
| State | Accepted |
| Commit | 7f534d022e719a2d98aa7f6ac17cf4fcca5d3779 |
| Headers | show |
| Series | [FFmpeg-devel] avformat/codec2: remove surplus include 'memory.h' statement | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_aarch64_jetson | success | Make finished |
| andriy/make_fate_aarch64_jetson | success | Make fate finished |
| andriy/make_armv7_RPi4 | success | Make finished |
| andriy/make_fate_armv7_RPi4 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Peter Ross: > on glibc memory.h drags in string.h, but codec2 does not use any > str* or mem* functions. additionally, memory.h is not part of the > C99 or POSIX standards. > --- > libavformat/codec2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/codec2.c b/libavformat/codec2.c > index cd0521299c..400c5acbdb 100644 > --- a/libavformat/codec2.c > +++ b/libavformat/codec2.c > @@ -21,7 +21,6 @@ > > #include "config_components.h" > > -#include <memory.h> > #include "libavcodec/codec2utils.h" > #include "libavutil/channel_layout.h" > #include "libavutil/intreadwrite.h" > LGTM. - Andreas
ons 2022-03-23 klockan 16:26 +1100 skrev Peter Ross: > on glibc memory.h drags in string.h, but codec2 does not use any > str* or mem* functions. additionally, memory.h is not part of the > C99 or POSIX standards. > --- > libavformat/codec2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/codec2.c b/libavformat/codec2.c > index cd0521299c..400c5acbdb 100644 > --- a/libavformat/codec2.c > +++ b/libavformat/codec2.c > @@ -21,7 +21,6 @@ > > #include "config_components.h" > > -#include <memory.h> > #include "libavcodec/codec2utils.h" > #include "libavutil/channel_layout.h" > #include "libavutil/intreadwrite.h" Looks fine /Tomas
On Thu, 24 Mar 2022, Tomas Härdin wrote: > ons 2022-03-23 klockan 16:26 +1100 skrev Peter Ross: >> on glibc memory.h drags in string.h, but codec2 does not use any >> str* or mem* functions. additionally, memory.h is not part of the >> C99 or POSIX standards. >> --- >> libavformat/codec2.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavformat/codec2.c b/libavformat/codec2.c >> index cd0521299c..400c5acbdb 100644 >> --- a/libavformat/codec2.c >> +++ b/libavformat/codec2.c >> @@ -21,7 +21,6 @@ >> >> #include "config_components.h" >> >> -#include <memory.h> >> #include "libavcodec/codec2utils.h" >> #include "libavutil/channel_layout.h" >> #include "libavutil/intreadwrite.h" > > Looks fine Thanks, applied. Regards, Marton
diff --git a/libavformat/codec2.c b/libavformat/codec2.c index cd0521299c..400c5acbdb 100644 --- a/libavformat/codec2.c +++ b/libavformat/codec2.c @@ -21,7 +21,6 @@ #include "config_components.h" -#include <memory.h> #include "libavcodec/codec2utils.h" #include "libavutil/channel_layout.h" #include "libavutil/intreadwrite.h"