From patchwork Fri Oct 13 18:20:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 5556 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp981328jah; Fri, 13 Oct 2017 11:20:22 -0700 (PDT) X-Received: by 10.223.147.166 with SMTP id 35mr2393766wrp.90.1507918822689; Fri, 13 Oct 2017 11:20:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507918822; cv=none; d=google.com; s=arc-20160816; b=alG51D2UgItD/hhvyvnx3ppu55wImtndjP3DaYw7stvRoj3UFUIzvr0RJ6mvgFKHMj e+/kkijG7m/KWDMSQDnVzRNzD7/TQSI69JVW0WYr/LKrZ6HnRvn1IOvHRXQ22EHZBB18 Te/b4Jerkwn4OiDQy98HPZF56eFFrOrmWD3OBJiwCuoQkmMR7JRSNadK6Z2U4/8bXcTe T/hhjMjVboZt/RXB8u8uBsVXHKGmnKd+LrtxMxXX7ByCryWETDxNvH9Vd6hWdVa784+f onkhFvwO6RXH3tQs5K2I2X/wIWcOpEABf3TiCXOzseW31pYZiysSAoetYbGwPAOxgf7w XKwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=/DMpfes7Umu5wwPOI9LzekzjJF32JstDlb88SfihgSg=; b=qUYdQdBS/YHetYSkYXiuxH60NUASUfYDn54CT9B02BR+fUWFlSbTEFOrmQxPb9N0Pk /gEI2tV9Ql7/JSJ8ZrpA+Ni+1e9aUAdHVKkzx9/lrAmivUBlamptaM0lj1C9lB1I2Val ZllRXaRqlPrVQvoWqrU4AxWr+gcy9FJadBsFdEEmrNBXtsoBiHTK2WFAs9DuPHIszzYk FXKR3nSrMR561proPQ/kcGOmEqDL+H3I7xcIUTyAUXJFK85LuNK3uIJjH57quw3sc70r s/gyaK69PXAuJqZQ1vUJmrkXmPkJfxA19G+L+pSDd+coOzwO3e7uLZwP07dRzqu7FMUj 2Glw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=G4qWdQSk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id p14si1337968wmf.213.2017.10.13.11.20.22; Fri, 13 Oct 2017 11:20:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=G4qWdQSk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C640F68A0F0; Fri, 13 Oct 2017 21:20:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk0-f172.google.com (mail-qk0-f172.google.com [209.85.220.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 814DC68A0D4 for ; Fri, 13 Oct 2017 21:20:11 +0300 (EEST) Received: by mail-qk0-f172.google.com with SMTP id r64so6047817qkc.1 for ; Fri, 13 Oct 2017 11:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=yWSicOFsMKAQFndhsrTibL8o7EXuEb5Iv4qtGx3JWxA=; b=G4qWdQSkixYFBvgUR9Dl1OxqBowT1LazMSKMjkS2SKP0LutyUaK1g+1KsnvzqTKVts Hb1TL16wqbibNa8jkECUZ4J9VojKlO6XelLAp5ty98qxX5jkZTC4oB/grZ6KL5+mcGfw YffXtqb91OBd/3iGB03Jl++aXM/a1RVgly/7QgY7syMaESTawqbxFn2mH8RbsGFs7Rr2 QoXJ/gVu6jBHDl81HKxCZRpA6f/K9PkuWZpSPegaU/jEZyXZZ6BIcXR3NuhF1INHp1YV nJDJvKFylo5s+pABrDkmS0vrsICdk4ZNVTDJ23OVC0xU9UGD7PtjkQNdDo2+Ac5I0qtV VLxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=yWSicOFsMKAQFndhsrTibL8o7EXuEb5Iv4qtGx3JWxA=; b=c+cC8m8MzEnFsDSpcpi6BQPkxaw9puhC3ic/jhZAJtRtr85jp1OiTlL4O0oqMs69ts xt3BNo0TzWk0fdbns8tW95rL35whaKZu+AzfDnXJYOFznMQINwnFCkB6AoAL+2CNuaLA sKicNWOb+XftIXqc38U3STV7wV9+krF2VmS1oL659NBZWcJd72xDRFXX3AGGolSnR+/p EHLjesXjznbeswR1Ovc4ST/zsCLOEXbRX7MRzU4p3LDJ7d1z9SR1JuiJINqSvmic5dHq ayfHpsTaw9lHXOfLu0jpEI2DEPt+9FTmMkwA4saJC515Ju1bX0VSlUvfuHNQ9BDVX5PE S6Dg== X-Gm-Message-State: AMCzsaWYbrqQjeJMKQ14W/OQjltW5M50Tej1PmAygjKU5/BCv03ZoZIb YLitxvzQsFMmILYny4R/DYEgh9eV X-Google-Smtp-Source: ABhQp+RFJadPmbkVOR0MSKbBZ3kWU8jTXx5XhBfPa/+B61YM+PmNV/a7MbEbRUANJClJa4R9u8/XWw== X-Received: by 10.55.9.203 with SMTP id 194mr3431186qkj.3.1507918813665; Fri, 13 Oct 2017 11:20:13 -0700 (PDT) Received: from [192.168.0.4] ([181.231.68.242]) by smtp.gmail.com with ESMTPSA id r189sm874124qkd.86.2017.10.13.11.20.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 11:20:12 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20171011212622.A0E83175447@albiero.videolan.org> <20171012002236.GB11608@nb4> <34e27316-ffc8-f815-d03d-37bbd4b922c5@gmail.com> <20171012165656.GG6009@nb4> <80511c36-5370-c366-8889-d31204c7e9b6@gmail.com> <59DFE1C9.2040402@xs4all.nl> <87ae3d79-23ab-0525-1d9e-5c898fd4b647@gmail.com> <59E0E446.9010400@xs4all.nl> <5b648ae5-dcbd-07f9-71dd-9a5e34f51b4d@gmail.com> Message-ID: <67b69aab-f6b7-869a-aca0-d0de17ec4f81@gmail.com> Date: Fri, 13 Oct 2017 15:20:09 -0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5b648ae5-dcbd-07f9-71dd-9a5e34f51b4d@gmail.com> Content-Language: en-US Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 10/13/2017 1:48 PM, James Almer wrote: > So in here it's including the libraries libopenmpt.pc said it needed > (using pkg-config --static). Are "-lshlwapi -lpthread -lcrypt32" > extralibs you added manually, or were they derived from dependencies > like libmpg123, vorbis, etc by pkg-config? > > Also, all the errors below mention functions from the c++ standard > library, so it looks like libopenmpt.pc should be including -lstdc++ > in Libs.private but it doesn't? I see that libopempt depends on > PortAudiocpp to build, so i'm guessing that's indeed the case. > > See if adding -lstdc++ fixes it. If it does then it means that, before > the commit that introduced these issues, a previous library you > requested (maybe libgme) added -lstdc++ to the global ldflags. > It would for that matter help a lot if you post the exact configure line > you're using. The attached patch adds the -lstdc++ flag to the check as i mentioned above. See if it fixes it. From 276ed55b9427aa21cd56b9511614b0d5df1081bc Mon Sep 17 00:00:00 2001 From: James Almer Date: Fri, 13 Oct 2017 15:16:55 -0300 Subject: [PATCH] configure: add a -lstdc++ flag to the libopenmpt check It's missing in the pkg-config file, so add it here as a workaround. Signed-off-by: James Almer --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 64fd088208..14b3b9f6c0 100755 --- a/configure +++ b/configure @@ -6030,7 +6030,7 @@ enabled libopenjpeg && { { check_lib libopenjpeg openjpeg-2.3/openjpeg.h o { check_lib libopenjpeg openjpeg-1.5/openjpeg.h opj_version -lopenjpeg -DOPJ_STATIC && add_cppflags -DOPJ_STATIC; } || { check_lib libopenjpeg openjpeg.h opj_version -lopenjpeg -DOPJ_STATIC && add_cppflags -DOPJ_STATIC; } || die "ERROR: libopenjpeg not found"; } -enabled libopenmpt && require_pkg_config libopenmpt "libopenmpt >= 0.2.6557" libopenmpt/libopenmpt.h openmpt_module_create +enabled libopenmpt && require_pkg_config libopenmpt "libopenmpt >= 0.2.6557" libopenmpt/libopenmpt.h openmpt_module_create -lstdc++ enabled libopus && { enabled libopus_decoder && { require_pkg_config libopus opus opus_multistream.h opus_multistream_decoder_create