From patchwork Tue Dec 12 14:53:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Matouschek X-Patchwork-Id: 6725 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.94 with SMTP id m30csp4170822jah; Tue, 12 Dec 2017 06:53:16 -0800 (PST) X-Google-Smtp-Source: ACJfBoulKsbjSWG1m1q4Ab/cnO9yN7gG4MhKoq0SPit68ifYqt0unmaJ1xCh+5dyOPXpa8KPxtfn X-Received: by 10.28.230.208 with SMTP id e77mr2064783wmi.86.1513090396313; Tue, 12 Dec 2017 06:53:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513090396; cv=none; d=google.com; s=arc-20160816; b=Jt+Gw3YjJdWyD/fHvEbefKNcVQluMai6410epb39kzpvH1lqX6zjl6u9jV8xFexdZt sGnqvaj1wRRavylC51M58rppb4ez7M8i5eMgZ0xlR6drKxxPdxFWDDzO1VymU3yFMW90 C+DxtOOFMjgVqhEQUwQDvlVQsO2KdiD5A0ZKAy7csO15rL7XRkUA1xBFEyZuDz+aOVec x630G1gRXNTmDLPGGdZkL7soPIpwebibVjoUF3IhuXIyEz6wgiTa5En9pvPCoq+UMV42 wLx2SSztysl/P40tfyOdp3T6M/KgIHiQDzHOWr235oLcHTR3W8ut4tNqeW19Sdo/IE0q ktEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:message-id :references:in-reply-to:to:from:date:mime-version:dkim-signature :delivered-to:arc-authentication-results; bh=1rfMGtrqYsIvFAGo6m0frSeYW/hGFB4/J0voQDfw0w0=; b=cTXwUIZ419sfAR/vDBjY15vHGNLYGJPoLkdTg/L+7Ci3HGmMlkhqwIHPNfFZxubSrd IjIIdX10Q8NfLQd7+cmXuDnmmm1FqUyaKZKX7LXXj/cqjhDrPqm5Jxuqi+4HOq8pbhV8 XPCet6mTivBJxBCi0khtVIbJxELBcx8i1vcGv5pvunrcnFwx1u/Zsp6qsIY/QZ2NO61f 7zBwsGXTT28xzwphCugwRy5LR9nE31jTGIhZbOuQdiPfMYgkKWYMGIAHm633InQ4+NBj LJ0MmEQsaybm/U8TfmfHmBNgbuu+BkM4lQiyrh4tss8JfuOQ7R1ZrSA/Yo6I9W6oognA MLVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@matouschek.org header.s=mail header.b=FRoHyUTy; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=matouschek.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q124si7116441wma.132.2017.12.12.06.53.15; Tue, 12 Dec 2017 06:53:16 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@matouschek.org header.s=mail header.b=FRoHyUTy; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=matouschek.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA51368A602; Tue, 12 Dec 2017 16:53:04 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.fmat.eu (mail.fmat.eu [37.120.191.63]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B60CE68A219 for ; Tue, 12 Dec 2017 16:52:58 +0200 (EET) Received: from authenticated-user (mail.fmat.eu [37.120.191.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.fmat.eu (Postfix) with ESMTPSA id 558841A085D; Tue, 12 Dec 2017 15:53:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=matouschek.org; s=mail; t=1513090386; bh=Xr+YJTDnDNT1ZzkV/ECo2CRyxm9M+y0ffhVdPxktrEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FRoHyUTyGOKkLLYGzhjU00+ACv7+US0Y07AKtCmgIjRxS0Bin3iT8K9mW2+y8CsEn NeEODDJXdJ/gnM6s8QtaaENGhK5ufrPZx94JeNUvxg5kEYin1qHbcNWcu8WLIPKvBi CDt4y1a1g8wZjJcSR1WBiUMimD9VQuV8loMyXBhgdIyaiVPDzNoS6l5zzZE6nMKpq/ Lb5es+G3OFS2TDRCY6YYeX15CiYW01jO2yZSPbyWVRFsg46Tf41B5bxTFUF49OsKSS 48LGWYbWjME68oxMx3HUTOxibusvAsvcjsWLoeIXaVV6l4l7U6ezdGT2YCvVnmWLoV 6Tb1pM0ZQWR+w== MIME-Version: 1.0 Date: Tue, 12 Dec 2017 15:53:06 +0100 From: Felix Matouschek To: FFmpeg development discussions and patches In-Reply-To: References: <376c61a3f8d786b2ed63983bbb1591e0@matouschek.org> Message-ID: <6a1df4ea6f578904bd2d63d681d77133@matouschek.org> X-Sender: felix@matouschek.org Subject: Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: James Almer Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Am 12.12.2017 15:37, schrieb James Almer: > No, this is not correct. If anything has to be added here, it would be > $libm_extralibs. -lm is not needed/available on some systems. Ok, changed it. > Also, you should be using pkg-config. Its job is to make sure all the > cflags and ldflags are correct for your system. > This shitty fallback shouldn't be here in the first place, but some > people are too stubborn about it. The Android NDK has no pkg-config so it is somehow useful. From b2f30f087aaf7d1284ebe08a09adc478df80ba22 Mon Sep 17 00:00:00 2001 From: Felix Matouschek Date: Tue, 12 Dec 2017 10:42:40 +0100 Subject: [PATCH] configure: Fix detection of vp9 decoder/encoder To: ffmpeg-devel@ffmpeg.org At least on Android the vp9 decoder/encoder needs $libm_extralibs to successfully link, it was missing in the check_lib calls for vp9 Signed-off-by: Felix Matouschek --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 8cf48ae1cf..df149024d3 100755 --- a/configure +++ b/configure @@ -5918,11 +5918,11 @@ enabled libvpx && { } enabled libvpx_vp9_decoder && { check_pkg_config libvpx_vp9_decoder "vpx >= 1.4.0" "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_vp9_dx || - check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" -lvpx + check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" -lvpx $libm_extralibs } enabled libvpx_vp9_encoder && { check_pkg_config libvpx_vp9_encoder "vpx >= 1.4.0" "vpx/vpx_encoder.h vpx/vp8cx.h" vpx_codec_vp9_cx || - check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" -lvpx + check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" -lvpx $libm_extralibs } if disabled_all libvpx_vp8_decoder libvpx_vp9_decoder libvpx_vp8_encoder libvpx_vp9_encoder; then die "libvpx enabled but no supported decoders found" -- 2.14.1.windows.1