From patchwork Thu Apr 12 08:23:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bodecs Bela X-Patchwork-Id: 8417 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp1628620jad; Thu, 12 Apr 2018 01:23:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+mStiNk6Dcx3KEvLbPB9J3gxK0j5FI6DTwNmyPjiqKaxjP5usPVFuej6Miw4dE2kT/a8a4 X-Received: by 10.223.201.146 with SMTP id f18mr2481027wrh.202.1523521393423; Thu, 12 Apr 2018 01:23:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523521393; cv=none; d=google.com; s=arc-20160816; b=IsK3kSEaOOhJzRo6j3VhBIU4kSb8yB5Iwx0ho5525IXIUIQ5perKV2E1tl/9IVPrP4 2R+WbWP/hkeF4ZYZLN0ECtvJsxQl1iVVuNCjzViDMHvT6gZ0lhx9/hkA3i2Pytam6Wqr F7P4TP8nB0t9Ku60oLoky15l93jfVxYNePUoUreoY4Wnyddke+y3dKKHkPB3t1sdH+M0 k+ZdUpnitUP+UEvey/qS7nfV/mLcX0Ofzn2sI+LjHm98lEFBDnnsOi1sZtfKiPt/57ld xHEdGp+nq4cPYLyv5srceaJcvWtxKTK3gKbRn5f7P+Systg0mvagIE7kqTQwoRbdu0Tn HfcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:delivered-to :arc-authentication-results; bh=p8Muxig8iYvPoQ6xVxlfJSqzFE9aEIUfisMKiEqhdNI=; b=XAgCWPKidHEk0aqX6FMBG28Jyc4Xscg9AdyYGzrV47AezRI2gChLg3MO8LDKCclk1h hLXELoUdMOLCZ4FTT5UK5ZooDBupLtFARsX09CntvAXjyp/utTdYCd1IjVT/758bwoYy DLwj4syfCgwJXDj6PJJio5vPHkDQqMwh4js13wKsBlwufha9g49jM+IIwaQSPUOhtei/ I6R2cHcEtLGfYwZz5RqD2LbcsECSPDTEVuDGRxf5a7YMNELuQMItB16UkLR6k9L1gop7 ZZd+EVl9AS5XNra/xx50eewfrmEwpQnz5Chbg6PYnyhTaPQIuqrJuN49mpx9Jm34Un/l 86Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a2si2082575wrd.201.2018.04.12.01.23.13; Thu, 12 Apr 2018 01:23:13 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 66F3B68A35F; Thu, 12 Apr 2018 11:22:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-xsmtp1.externet.hu (mail-xsmtp4.externet.hu [212.40.96.155]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 20F57689FFF for ; Thu, 12 Apr 2018 11:22:41 +0300 (EEST) Received: (qmail 3127 invoked from network); 12 Apr 2018 08:23:05 -0000 Received: from mail.officeline.hu (HELO ?10.0.0.10?) (bodecsb@vivanet.hu@217.173.32.91) by 0 with ESMTPA; 12 Apr 2018 08:23:05 -0000 To: ffmpeg-devel@ffmpeg.org References: <0b533ebc-731a-137c-1884-b5b6667c2b1e@vivanet.hu> <20180404003740.GR20131@michaelspb> <9d4b5879-a899-a93c-51f7-4988b324476d@vivanet.hu> <20180411222607.GD20131@michaelspb> From: Bodecs Bela Message-ID: <6d59fe75-5674-67c7-a2b5-faaea1de79a7@vivanet.hu> Date: Thu, 12 Apr 2018 10:23:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180411222607.GD20131@michaelspb> Content-Language: hu X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: Re: [FFmpeg-devel] [PATCH] avformat/utils: Stream specifier enhancement X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2018.04.12. 0:26 keltezéssel, Michael Niedermayer írta: > On Wed, Apr 11, 2018 at 10:37:41PM +0200, Bodecs Bela wrote: >> fate test enclosed >> >> >> 2018.04.04. 10:39 keltezéssel, Bodecs Bela írta: >>> >>> 2018.04.04. 2:37 keltezéssel, Michael Niedermayer írta: >>>> On Sun, Apr 01, 2018 at 11:42:34PM +0200, Bodecs Bela wrote: >>>>> Dear All, >>>>> >>>>> currently when specifying the program id you can only decide to select >>>>> all stream of the specified program (e.g. p:103 will select all streams >>>>> of program 103) or narrow the selection to a specific stream sub index >>>>> (e.g. p:145:1 will select 2nd stream of program 145.) But you can not >>>>> specify like all audio streams of program 145 or 3rd video stream of >>>>> program 311. >>>>> In some case, mainly working with multiprogram mpeg-ts containers as >>>>> input, this feature would be handy. >>>>> This patch makes it possible to narrow the stream selection among >>>>> streams of the specified program by stream type and optionally its >>>>> index. Handled types: a, v, s, d. >>>>> Examples: p:601:a  will select all audio streams of program 601, >>>>> p:603:a:1 will select 2nd audio streams of program 603, >>>>> p:604:v:0 will select first video stream of program 604. >>>>> This syntax enhancement does not interfere in any way with >>>>> current/exiting syntax or working command lines >>>> I think this is a good idea. >>>> Can you also add fate test(s) for this ? (can be in a seperate patch >>>> later of course) >>>> >>> ok, I will try. >>> >>> bb >>> >>>> thx >>>> >>>> [...] >>>> >>>> >>>> >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> mpegts.mak | 6 ++++++ >> 1 file changed, 6 insertions(+) >> da6c059eab100872d0f61d14e40e46012f031bfe 0002-fate-to-test-program-sub-stream-selection-by-its-typ.patch >> From 093bdb47d1c5093cbd9427fbd2383a1c802464bb Mon Sep 17 00:00:00 2001 >> From: Bela Bodecs >> Date: Wed, 11 Apr 2018 22:33:02 +0200 >> Subject: [PATCH] fate: to test program sub stream selection by its type in >> mpegts >> >> Signed-off-by: Bela Bodecs >> --- >> tests/fate/mpegts.mak | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/tests/fate/mpegts.mak b/tests/fate/mpegts.mak >> index bb0d9d9..2b12849 100644 >> --- a/tests/fate/mpegts.mak >> +++ b/tests/fate/mpegts.mak >> @@ -9,6 +9,12 @@ FATE_MPEGTS_PROBE-$(call DEMDEC, MPEGTS, HEVC, AAC_LATM) += fate-mpegts-probe-la >> fate-mpegts-probe-latm: SRC = $(TARGET_SAMPLES)/mpegts/loewe.ts >> fate-mpegts-probe-latm: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)" >> >> + >> +FATE_MPEGTS_PROBE-$(call DEMDEC, MPEGTS, HEVC, AAC_LATM) += fate-mpegts-probe-program >> +fate-mpegts-probe-program: SRC = $(TARGET_SAMPLES)/mpegts/loewe.ts >> +fate-mpegts-probe-program: CMD = run $(PROBE_CODEC_NAME_COMMAND) -select_streams p:769:v:0 -i "$(SRC)" >> + >> + >> FATE_SAMPLES_FFPROBE += $(FATE_MPEGTS_PROBE-yes) > missing reference file > > reference file './tests/ref/fate/mpegts-probe-program' not found > ./tests/fate-run.sh: 419: ./tests/fate-run.sh: cannot open tests/data/fate/mpegts-probe-program.diff: No such file > Test mpegts-probe-program failed. Look at tests/data/fate/mpegts-probe-program.err for details. > make: *** [fate-mpegts-probe-program] Error 1 > make: *** Waiting for unfinished jobs.... > > [...] > > sorry, ref file was not included. Corrected patch enclosed. bb > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel From 9df4f0261f475b0e84aad299f190f1c35a9e62c0 Mon Sep 17 00:00:00 2001 From: Bela Bodecs Date: Wed, 11 Apr 2018 22:33:02 +0200 Subject: [PATCH] fate: to test program sub stream selection by its type in mpegts Signed-off-by: Bela Bodecs --- tests/fate/mpegts.mak | 6 ++++++ tests/ref/fate/mpegts-probe-program | 8 ++++++++ 2 files changed, 14 insertions(+) create mode 100644 tests/ref/fate/mpegts-probe-program diff --git a/tests/fate/mpegts.mak b/tests/fate/mpegts.mak index bb0d9d9..2b12849 100644 --- a/tests/fate/mpegts.mak +++ b/tests/fate/mpegts.mak @@ -9,6 +9,12 @@ FATE_MPEGTS_PROBE-$(call DEMDEC, MPEGTS, HEVC, AAC_LATM) += fate-mpegts-probe-la fate-mpegts-probe-latm: SRC = $(TARGET_SAMPLES)/mpegts/loewe.ts fate-mpegts-probe-latm: CMD = run $(PROBE_CODEC_NAME_COMMAND) -i "$(SRC)" + +FATE_MPEGTS_PROBE-$(call DEMDEC, MPEGTS, HEVC, AAC_LATM) += fate-mpegts-probe-program +fate-mpegts-probe-program: SRC = $(TARGET_SAMPLES)/mpegts/loewe.ts +fate-mpegts-probe-program: CMD = run $(PROBE_CODEC_NAME_COMMAND) -select_streams p:769:v:0 -i "$(SRC)" + + FATE_SAMPLES_FFPROBE += $(FATE_MPEGTS_PROBE-yes) fate-mpegts: $(FATE_MPEGTS_PROBE-yes) diff --git a/tests/ref/fate/mpegts-probe-program b/tests/ref/fate/mpegts-probe-program new file mode 100644 index 0000000..bb1012c --- /dev/null +++ b/tests/ref/fate/mpegts-probe-program @@ -0,0 +1,8 @@ +[PROGRAM] +[STREAM] +codec_name=hevc +[/STREAM] +[/PROGRAM] +[STREAM] +codec_name=hevc +[/STREAM]