From patchwork Mon Jul 31 10:13:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manojkumar Bhosale X-Patchwork-Id: 4528 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.1.85 with SMTP id 82csp2226117vsb; Mon, 31 Jul 2017 03:13:24 -0700 (PDT) X-Received: by 10.28.19.205 with SMTP id 196mr10356247wmt.122.1501496004610; Mon, 31 Jul 2017 03:13:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501496004; cv=none; d=google.com; s=arc-20160816; b=sghFEIbbbr7fzBSXE/+1fjq0urUpEAs62xF31yOckjsf2nOyH416Jy2LQsZKg7W0KR BuZUpHIlJ4QfZChVcyINhVtEhCUO7z82Sq7+paASenTyhiwqGJrcOWes5sCJqbWte/w5 MTxsfiQjfDm5lQn2hRKf76+P6THmKRjJX8lf6ys1kMv32FENO7kmbNTnABUivQrn4ctz H/azzeLV267ghGfRHPJutuqLHLh71FuiB34VRhAgyFbhChHZQeIE5RxjZno/GR6UynHA JhIagcbiQaXU3ZURbN+uW/CcFz+I0iLEgIXViWv6whTAb0b008ZD7GSns7kGmJoIrF0T kUIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:to:from:delivered-to:arc-authentication-results; bh=s2f3QFi8oeAZNunKsrwzwzHXZQcrciAVxQuA1qVr0K0=; b=NQ7L1DsInRTZtD2RI1ZFv/VsEn4slRfgMJBxeU8fY0hfZNWUvLzFt5bZdcNhXgSTU4 SXVrZ3yblY3FHxqE3VQnpoZbY2kHOWX9Qw/DCwqhILqEtvomG6gdQSJqkXYSJEA9apZx W8ix1okAZ3lW4ZqWJjaKi2i6GG4wPQjtbZ2w9nVO97XReDVB6Nju4F9tn1ik+MpRo22r 2s3yP0rzSc8IZ1ATYlYBr2QKAcWrqih/1dkcZpfSaf+EhmJowQjKJXd2TZcLR/EpXgvQ Vp9+auwfcKqy0hjXKVGKmshnl3iUZTzMZDOBj291RyG/6c2xBxlRxOmeFXWAgvE0nD1+ OEnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y35si11935386wrc.190.2017.07.31.03.13.22; Mon, 31 Jul 2017 03:13:24 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4C11868A19F; Mon, 31 Jul 2017 13:13:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 52C5A68A134 for ; Mon, 31 Jul 2017 13:13:10 +0300 (EEST) Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Forcepoint Email with ESMTPS id CF6DAD68E877F for ; Mon, 31 Jul 2017 11:13:08 +0100 (IST) Received: from HHMAIL-X.hh.imgtec.org (10.100.10.113) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.294.0; Mon, 31 Jul 2017 11:13:11 +0100 Received: from PUMAIL01.pu.imgtec.org (192.168.91.250) by HHMAIL-X.hh.imgtec.org (10.100.10.113) with Microsoft SMTP Server (TLS) id 14.3.294.0; Mon, 31 Jul 2017 11:13:11 +0100 Received: from PUMAIL01.pu.imgtec.org ([::1]) by PUMAIL01.pu.imgtec.org ([::1]) with mapi id 14.03.0266.001; Mon, 31 Jul 2017 15:43:09 +0530 From: Manojkumar Bhosale To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function Thread-Index: AQHTCcdaWPj6zh4H00a9t1VY4glGSaJtt5GA Date: Mon, 31 Jul 2017 10:13:08 +0000 Message-ID: <70293ACCC3BA6A4E81FFCA024C7A86E1E058C582@PUMAIL01.pu.imgtec.org> References: <1501483023-30703-1-git-send-email-kaustubh.raste@imgtec.com> In-Reply-To: <1501483023-30703-1-git-send-email-kaustubh.raste@imgtec.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.91.86] MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Kaustubh Raste Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" LGTM thx -----Original Message----- From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of kaustubh.raste@imgtec.com Sent: Monday, July 31, 2017 12:07 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function From: Kaustubh Raste Replace memset call with msa stores. Signed-off-by: Kaustubh Raste --- libavcodec/mips/h264idct_msa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel diff --git a/libavcodec/mips/h264idct_msa.c b/libavcodec/mips/h264idct_msa.c index 861befe..1e1a5c8 100644 --- a/libavcodec/mips/h264idct_msa.c +++ b/libavcodec/mips/h264idct_msa.c @@ -120,11 +120,12 @@ static void avc_idct8_addblk_msa(uint8_t *dst, int16_t *src, int32_t dst_stride) v4i32 res0_r, res1_r, res2_r, res3_r, res4_r, res5_r, res6_r, res7_r; v4i32 res0_l, res1_l, res2_l, res3_l, res4_l, res5_l, res6_l, res7_l; v16i8 dst0, dst1, dst2, dst3, dst4, dst5, dst6, dst7; - v16i8 zeros = { 0 }; + v8i16 zeros = { 0 }; src[0] += 32; LD_SH8(src, 8, src0, src1, src2, src3, src4, src5, src6, src7); + ST_SH8(zeros, zeros, zeros, zeros, zeros, zeros, zeros, zeros, src, + 8); vec0 = src0 + src4; vec1 = src0 - src4; @@ -318,7 +319,6 @@ void ff_h264_idct8_addblk_msa(uint8_t *dst, int16_t *src, int32_t dst_stride) { avc_idct8_addblk_msa(dst, src, dst_stride); - memset(src, 0, 64 * sizeof(dctcoef)); } void ff_h264_idct4x4_addblk_dc_msa(uint8_t *dst, int16_t *src, -- 1.7.9.5