From patchwork Fri Aug 11 09:44:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kaustubh.raste@imgtec.com X-Patchwork-Id: 4690 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.46.211 with SMTP id u202csp604566vsu; Fri, 11 Aug 2017 02:44:24 -0700 (PDT) X-Received: by 10.223.174.199 with SMTP id y65mr10935666wrc.182.1502444664110; Fri, 11 Aug 2017 02:44:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502444664; cv=none; d=google.com; s=arc-20160816; b=WuCrZHRHEVj0dlyvUJRJcu2iSNf14TAwepH4zhm+3qMBubK+FwdOVQ+UnyBAM7tlWg BZixfgKKW5FtuioRNuasNurVxmFRxuJ7rUaAQpaoEpkUo+uvbgmOnnPp9+8IMll6llBb KcuvpbrYU+fpQoC12sri2QjM0jWkythUc1U+K8b4JsVPkRtcdH9x+Us/cxQgO0tdoV9p Yq1reiaz+/shYruOL3INRbLj1zLKilH6SuljMH9hrySUpfcg0jRMpZMqAaLdmy8rZHIe iL6PhoxcwykhA7EYjOaOmCRtoCqFu33Ea5lFi8IhmoL9ccwTjZY3XshJt3rNji6U6M0C EZwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:content-language:accept-language :in-reply-to:references:message-id:date:thread-index:thread-topic:to :from:delivered-to:arc-authentication-results; bh=QKHxe5hTmjdAeCthrOtkkENGpMXQZbUoxEZ4h/eH/j0=; b=jzull9J4JIeQvkeKQ5OunpzdQKsITkP5PxAi/ZYwD2d9qssAHaCtsvcLxK6zXprt/8 D7EOVPad7hH7NDJdR/VhalK7L86w65Ng6F+pkhBofONjz6ImCCe3DwQsWgIvCo6mCGn6 4/XKm1AZc9p3slfvVb4Say43Upp73UQlO+N1z83vFg3Cayj4gNHLT8uAY/1Zm7uwl84c AbpNCfuYjLDy21UZiFUSuHQFA74/urOGY+BuLs06mZFVF6qk1d+gIcEmOBhaXjgwyEAh R+tZ3qnvCRPwN7czIWE7brR6d3KCZFjyNBQR4OXlNHhgXBxzJ5y7klHcjkeU1ddMuYe7 VYfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j20si393122wrb.31.2017.08.11.02.44.23; Fri, 11 Aug 2017 02:44:24 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3EE2689250; Fri, 11 Aug 2017 12:44:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7DAA36882B4 for ; Fri, 11 Aug 2017 12:44:11 +0300 (EEST) Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Forcepoint Email with ESMTPS id 1F0FF2A458A3D for ; Fri, 11 Aug 2017 10:44:10 +0100 (IST) Received: from HHMAIL-X.hh.imgtec.org (10.100.10.113) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.294.0; Fri, 11 Aug 2017 10:44:12 +0100 Received: from PUMAIL01.pu.imgtec.org (192.168.91.250) by HHMAIL-X.hh.imgtec.org (10.100.10.113) with Microsoft SMTP Server (TLS) id 14.3.294.0; Fri, 11 Aug 2017 10:44:12 +0100 Received: from PUMAIL01.pu.imgtec.org ([::1]) by PUMAIL01.pu.imgtec.org ([::1]) with mapi id 14.03.0266.001; Fri, 11 Aug 2017 15:14:10 +0530 From: Kaustubh Raste To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function Thread-Index: AQHTDRhv3DiomGLE00iKgbqayGUOV6J+8iCg Date: Fri, 11 Aug 2017 09:44:08 +0000 Message-ID: <7AC45BA9D7010549B1787997D11B8C30E086514E@PUMAIL01.pu.imgtec.org> References: <1501483023-30703-1-git-send-email-kaustubh.raste@imgtec.com> <70293ACCC3BA6A4E81FFCA024C7A86E1E058C582@PUMAIL01.pu.imgtec.org> <7AC45BA9D7010549B1787997D11B8C30E0864761@PUMAIL01.pu.imgtec.org> In-Reply-To: <7AC45BA9D7010549B1787997D11B8C30E0864761@PUMAIL01.pu.imgtec.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.91.73] MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Please review the patch. -----Original Message----- From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of Kaustubh Raste Sent: Friday, August 4, 2017 5:24 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function Ping. -----Original Message----- From: Manojkumar Bhosale Sent: Monday, July 31, 2017 3:43 PM To: FFmpeg development discussions and patches Cc: Kaustubh Raste Subject: RE: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function LGTM thx -----Original Message----- From: ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of kaustubh.raste@imgtec.com Sent: Monday, July 31, 2017 12:07 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc idct8 msa function From: Kaustubh Raste Replace memset call with msa stores. Signed-off-by: Kaustubh Raste --- libavcodec/mips/h264idct_msa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel diff --git a/libavcodec/mips/h264idct_msa.c b/libavcodec/mips/h264idct_msa.c index 861befe..1e1a5c8 100644 --- a/libavcodec/mips/h264idct_msa.c +++ b/libavcodec/mips/h264idct_msa.c @@ -120,11 +120,12 @@ static void avc_idct8_addblk_msa(uint8_t *dst, int16_t *src, int32_t dst_stride) v4i32 res0_r, res1_r, res2_r, res3_r, res4_r, res5_r, res6_r, res7_r; v4i32 res0_l, res1_l, res2_l, res3_l, res4_l, res5_l, res6_l, res7_l; v16i8 dst0, dst1, dst2, dst3, dst4, dst5, dst6, dst7; - v16i8 zeros = { 0 }; + v8i16 zeros = { 0 }; src[0] += 32; LD_SH8(src, 8, src0, src1, src2, src3, src4, src5, src6, src7); + ST_SH8(zeros, zeros, zeros, zeros, zeros, zeros, zeros, zeros, src, + 8); vec0 = src0 + src4; vec1 = src0 - src4; @@ -318,7 +319,6 @@ void ff_h264_idct8_addblk_msa(uint8_t *dst, int16_t *src, int32_t dst_stride) { avc_idct8_addblk_msa(dst, src, dst_stride); - memset(src, 0, 64 * sizeof(dctcoef)); } void ff_h264_idct4x4_addblk_dc_msa(uint8_t *dst, int16_t *src, -- 1.7.9.5